@@ -25,13 +25,13 @@ define void @test_not_crash(i32 %in_a) #0 {
entry:
%cmp0 = icmp eq i32 %in_a, -1
%cmp1 = icmp ne i32 %in_a, 0
- %cond0 = and i1 %cmp0, %cmp1
+ %cond0 = or i1 %cmp0, %cmp1
arsenm wrote:
Original tests still changing? Needs new copies
https://github.com/mahtohappy updated
https://github.com/llvm/llvm-project/pull/72522
Sorry, this diff is unavailable.
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Brad Smith
Date: 2023-11-30T23:14:46-05:00
New Revision: a37c69ec315b9526a3532022be3ebe1af9ca356a
URL:
https://github.com/llvm/llvm-project/commit/a37c69ec315b9526a3532022be3ebe1af9ca356a
DIFF:
https://github.com/llvm/llvm-project/commit/a37c69ec315b9526a3532022be3ebe1af9ca356a.diff
LO
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/73981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Brad Smith (brad0)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/74036.diff
1 Files Affected:
- (modified) lldb/packages/Python/lldbsuite/test/lldbplatformutil.py (+2)
``diff
diff --git a/lldb/packages/Pyth
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/74036
None
>From 260de5f42f3216321349ff316ff800c5fa2c60f9 Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Thu, 30 Nov 2023 23:07:45 -0500
Subject: [PATCH] [lldb/test] Add OpenBSD to _get_platform_os
---
lldb/packages/P
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Brad Smith (brad0)
Changes
FreeBSD 10.x and 11.x support has been dropped leaving 12.x as the minimum
version. This FreeBSD check can be simplified.
https://github.com/llvm/llvm-project/commit/812dad536ed50abe94d6e2b2519f351791c24c59
---
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/74019
FreeBSD 10.x and 11.x support has been dropped leaving 12.x as the minimum
version. This FreeBSD check can be simplified.
https://github.com/llvm/llvm-project/commit/812dad536ed50abe94d6e2b2519f351791c24c59
>From
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/74012
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
brad0 wrote:
> If [this man page](https://man.openbsd.org/pipe2) is to be believed, this
> seems alright to do.
Yes, that is correct. 8+ years ago / 18 releases ago at 5.7.
https://github.com/llvm/llvm-project/pull/74012
___
lldb-commits mailing list
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Brad Smith (brad0)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/74017.diff
2 Files Affected:
- (modified) lldb/packages/Python/lldbsuite/test/lldbplatformutil.py (+1-1)
- (modified) lldb/test/API/lit.cfg.py (+1-1)
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/74017
None
>From adf0027c83805290dd259b8f431c91a19c15955a Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Thu, 30 Nov 2023 20:14:22 -0500
Subject: [PATCH] [lldb] Make use of LD_LIBRARY_PATH on OpenBSD
---
lldb/packages
https://github.com/bulbazord approved this pull request.
If [this man page](https://man.openbsd.org/pipe2) is to be believed, this seems
alright to do.
https://github.com/llvm/llvm-project/pull/74012
___
lldb-commits mailing list
lldb-commits@lists.ll
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Brad Smith (brad0)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/74012.diff
1 Files Affected:
- (modified) lldb/source/Host/posix/PipePosix.cpp (+1-1)
``diff
diff --git a/lldb/source/Host/posix/PipePosix.cp
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/74012
None
>From e3d6d0b6040516ee761c1b635093fd13244e9d2a Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Thu, 30 Nov 2023 19:17:53 -0500
Subject: [PATCH] [lldb] pipe2(2) is also supported by OpenBSD
---
lldb/source/Ho
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
In some situations it may be useful to have a separate DiagnosticManager
instance, and then later of move the contents of that instance back to the
"main" DiagnosticManager. For example, when silently
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/74011
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/74011
In some situations it may be useful to have a separate DiagnosticManager
instance, and then later of move the contents of that instance back to the
"main" DiagnosticManager. For example, when silently retryi
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/71771
>From 06c4cf02dfb4b20c8349c5f3c7209276f6d56edf Mon Sep 17 00:00:00 2001
From: zijunzhao
Date: Thu, 9 Nov 2023 02:21:46 +
Subject: [PATCH 1/3] Fix clang to recognize new C23 modifiers %w and %wf when
pri
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
+ /// @param [in] report_type Enum value indicating how the progress is being
+ /// reported. Progress reports considered "aggregate" are reports done for
+ /// oper
Author: Jason Molenda
Date: 2023-11-30T14:59:10-08:00
New Revision: 9e77d666d88d407a7705caa623f7bfc8dc90287d
URL:
https://github.com/llvm/llvm-project/commit/9e77d666d88d407a7705caa623f7bfc8dc90287d
DIFF:
https://github.com/llvm/llvm-project/commit/9e77d666d88d407a7705caa623f7bfc8dc90287d.diff
Author: Jason Molenda
Date: 2023-11-30T14:59:10-08:00
New Revision: 162e4b8c494459ea7509f598d15addd6ffc3dc9c
URL:
https://github.com/llvm/llvm-project/commit/162e4b8c494459ea7509f598d15addd6ffc3dc9c
DIFF:
https://github.com/llvm/llvm-project/commit/162e4b8c494459ea7509f598d15addd6ffc3dc9c.diff
Author: Nico Weber
Date: 2023-11-30T14:59:10-08:00
New Revision: 22f72642fe6cd8f049bc905e0f0a69243b650f89
URL:
https://github.com/llvm/llvm-project/commit/22f72642fe6cd8f049bc905e0f0a69243b650f89
DIFF:
https://github.com/llvm/llvm-project/commit/22f72642fe6cd8f049bc905e0f0a69243b650f89.diff
LO
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From b04c85dbed0b369e747aa2a3823789203156736b Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/9] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've plumb
@@ -97,6 +119,10 @@ class Progress {
/// The title of the progress activity.
std::string m_title;
std::mutex m_mutex;
+ /// Set to true if the progress event is aggregate; meaning it will happen
+ /// multiple times during a debug session as individual progress events
-
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 417d99ff038517fed596ebf6605e203110e88e6f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
@@ -1451,7 +1451,8 @@ static lldb::SectionType GetSectionType(uint32_t flags,
static ConstString g_sect_name_dwarf_debug_line_str("__debug_line_str");
static ConstString g_sect_name_dwarf_debug_loc("__debug_loc");
static ConstString g_sect_name_dwarf_debug_loclists("__deb
brad0 wrote:
> From the look of it, it looks like the minimum version of GCC that is
> currently supported is 7.1. (See:
> `llvm/cmake/modules/CheckCompilerVersion.cmake`)
It was 7.1, it is now 7.4.
https://reviews.llvm.org/D156286
https://github.com/llvm/llvm-project/pull/73981
@@ -97,6 +119,10 @@ class Progress {
/// The title of the progress activity.
std::string m_title;
std::mutex m_mutex;
+ /// Set to true if the progress event is aggregate; meaning it will happen
+ /// multiple times during a debug session as individual progress events
-
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
+ /// @param [in] report_type Enum value indicating how the progress is being
+ /// reported. Progress reports considered "aggregate" are reports done for
+ /// oper
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
+ /// @param [in] report_type Enum value indicating how the progress is being
+ /// reported. Progress reports considered "aggregate" are reports done for
+ /// oper
https://github.com/bulbazord approved this pull request.
LGTM
>From the look of it, it looks like the minimum version of GCC that is
>currently supported is 7.1. (See:
>`llvm/cmake/modules/CheckCompilerVersion.cmake`)
https://github.com/llvm/llvm-project/pull/73981
___
https://github.com/bulbazord requested changes to this pull request.
There looks to be a ton of unrelated changes in ObjectFileMachO.cpp. Mostly
formatting from what I can tell. Please revert to preserve blame history.
https://github.com/llvm/llvm-project/pull/69516
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1451,7 +1451,8 @@ static lldb::SectionType GetSectionType(uint32_t flags,
static ConstString g_sect_name_dwarf_debug_line_str("__debug_line_str");
static ConstString g_sect_name_dwarf_debug_loc("__debug_loc");
static ConstString g_sect_name_dwarf_debug_loclists("__deb
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Brad Smith (brad0)
Changes
The minimum GCC version was bumped up from 4.8 to 5.1 and then even newer
awhile ago so garbage collect the pre 4.8 workaround.
https://reviews.llvm.org/D66188
---
Full diff: https://github.com/llvm/llvm-project/
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/73981
The minimum GCC version was bumped up from 4.8 to 5.1 and then even newer
awhile ago so garbage collect the pre 4.8 workaround.
https://reviews.llvm.org/D66188
>From a79e4d06f16e2460c7521874c13370022bbb5952 Mon Sep
Author: John Harrison
Date: 2023-11-30T15:17:12-05:00
New Revision: c8f72856dbdd0039fc16eae51726da105ea679c0
URL:
https://github.com/llvm/llvm-project/commit/c8f72856dbdd0039fc16eae51726da105ea679c0
DIFF:
https://github.com/llvm/llvm-project/commit/c8f72856dbdd0039fc16eae51726da105ea679c0.diff
https://github.com/DavidGoldman closed
https://github.com/llvm/llvm-project/pull/72292
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1296,10 +1296,11 @@ enum CompletionType {
eRemoteDiskFileCompletion = (1u << 22),
eRemoteDiskDirectoryCompletion = (1u << 23),
eTypeCategoryNameCompletion = (1u << 24),
+ eThreadIDCompletion = (1u << 25),
clayborg wrote:
> @clayborg Is there anythin
@@ -7909,6 +7903,37 @@ bool
Sema::CheckTemplateTemplateArgument(TemplateTemplateParmDecl *Param,
Arg.getLocation());
}
+static Sema::SemaDiagnosticBuilder noteLocation(Sema &S, const NamedDecl &Decl,
+
@@ -1296,10 +1296,11 @@ enum CompletionType {
eRemoteDiskFileCompletion = (1u << 22),
eRemoteDiskDirectoryCompletion = (1u << 23),
eTypeCategoryNameCompletion = (1u << 24),
+ eThreadIDCompletion = (1u << 25),
mdko wrote:
@clayborg Is there anything spec
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 83ca6c8e94ded4378b4c0cd067aaeca1d92719d0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
@@ -7909,6 +7903,37 @@ bool
Sema::CheckTemplateTemplateArgument(TemplateTemplateParmDecl *Param,
Arg.getLocation());
}
+static Sema::SemaDiagnosticBuilder noteLocation(Sema &S, const NamedDecl &Decl,
+
@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S,
SourceLocation IdentLoc,
: IdentLoc);
}
+static ImplicitConversionKind getConversionKind(QualType FromType,
+
@@ -101,6 +101,8 @@ class CompilerInvocation : public CompilerInvocationBase {
bool warnAsErr = false;
+ const char *argv0;
kiranchandramohan wrote:
Nit: This is probably obvious but will be good to add executable name as a
comment above.
https://github
https://github.com/kiranchandramohan edited
https://github.com/llvm/llvm-project/pull/73254
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kiranchandramohan approved this pull request.
LG.
https://github.com/llvm/llvm-project/pull/73254
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 004e0e6a8a09b34bdc694ca7eb5ef02483693e5f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
https://github.com/jimingham closed
https://github.com/llvm/llvm-project/pull/72565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: jimingham
Date: 2023-11-30T09:48:04-08:00
New Revision: d1bf1947e4e4f3ef75f2ba3ac9aa77dc38214de1
URL:
https://github.com/llvm/llvm-project/commit/d1bf1947e4e4f3ef75f2ba3ac9aa77dc38214de1
DIFF:
https://github.com/llvm/llvm-project/commit/d1bf1947e4e4f3ef75f2ba3ac9aa77dc38214de1.diff
LOG
DanielCChen wrote:
The changes look good to me. I will wait a day to see if other reviewers have
any more comments before approving it.
https://github.com/llvm/llvm-project/pull/73254
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://l
https://github.com/bogner updated
https://github.com/llvm/llvm-project/pull/71264
>From cab6bcd73081fcbe9807adbf60b345f8d9e654e4 Mon Sep 17 00:00:00 2001
From: Justin Bogner
Date: Fri, 3 Nov 2023 18:59:49 -0700
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?UTF-
clayborg wrote:
The original patch that added the ability for the CU and TU indexes being able
to exceed 4GB was this:
https://reviews.llvm.org/D137882
https://github.com/llvm/llvm-project/pull/73736
___
lldb-commits mailing list
lldb-commits@lists.ll
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/73879
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bogner updated
https://github.com/llvm/llvm-project/pull/71264
>From cab6bcd73081fcbe9807adbf60b345f8d9e654e4 Mon Sep 17 00:00:00 2001
From: Justin Bogner
Date: Fri, 3 Nov 2023 18:59:49 -0700
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?UTF-
https://github.com/kevinfrei updated
https://github.com/llvm/llvm-project/pull/70996
>From b04c85dbed0b369e747aa2a3823789203156736b Mon Sep 17 00:00:00 2001
From: Kevin Frei
Date: Wed, 18 Oct 2023 14:37:34 -0700
Subject: [PATCH 1/8] DEBUGINFOD based DWP acquisition for LLDB
Summary:
I've plumb
@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S,
SourceLocation IdentLoc,
: IdentLoc);
}
+static ImplicitConversionKind getConversionKind(QualType FromType,
+
@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S,
SourceLocation IdentLoc,
: IdentLoc);
}
+static ImplicitConversionKind getConversionKind(QualType FromType,
+
@@ -484,6 +484,26 @@ bool
clang::analyze_format_string::parseFormatStringHasFormattingSpecifiers(
return false;
}
+ArgType clang::analyze_format_string::wToArgType(
+int size, bool fast, ASTContext &C) {
+ ArgType fastType = C.getTargetInfo().getTriple().isArch64Bit()
https://github.com/piotrAMD closed
https://github.com/llvm/llvm-project/pull/73786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -286,7 +286,33 @@
clang::analyze_format_string::ParseLengthModifier(FormatSpecifier &FS,
lmKind = LengthModifier::AsInt3264;
break;
case 'w':
- lmKind = LengthModifier::AsWide; ++I; break;
+ ++I;
+ if (I == E) return false;
+ if (*I == 'f
https://github.com/jrtc27 edited https://github.com/llvm/llvm-project/pull/71771
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -286,7 +286,33 @@
clang::analyze_format_string::ParseLengthModifier(FormatSpecifier &FS,
lmKind = LengthModifier::AsInt3264;
break;
case 'w':
- lmKind = LengthModifier::AsWide; ++I; break;
+ ++I;
+ if (I == E) return false;
+ if (*I == 'f
@@ -286,7 +286,33 @@
clang::analyze_format_string::ParseLengthModifier(FormatSpecifier &FS,
lmKind = LengthModifier::AsInt3264;
break;
case 'w':
- lmKind = LengthModifier::AsWide; ++I; break;
+ ++I;
+ if (I == E) return false;
+ if (*I == 'f
@@ -286,7 +286,33 @@
clang::analyze_format_string::ParseLengthModifier(FormatSpecifier &FS,
lmKind = LengthModifier::AsInt3264;
break;
case 'w':
- lmKind = LengthModifier::AsWide; ++I; break;
+ ++I;
+ if (I == E) return false;
+ if (*I == 'f
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/73099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/73099
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -14240,6 +14294,114 @@ StmtResult Sema::ActOnCXXForRangeIdentifier(Scope *S,
SourceLocation IdentLoc,
: IdentLoc);
}
+static ImplicitConversionKind getConversionKind(QualType FromType,
+
https://github.com/gchatelet closed
https://github.com/llvm/llvm-project/pull/73814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/gchatelet updated
https://github.com/llvm/llvm-project/pull/73814
>From bdd0a0855c0dd98c93977db6982e480ab270b3cd Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet
Date: Wed, 29 Nov 2023 16:29:12 +
Subject: [PATCH 1/8] [libc] Add more functions in CPP/bit.h
---
libc/src/
https://github.com/gchatelet updated
https://github.com/llvm/llvm-project/pull/73814
>From bdd0a0855c0dd98c93977db6982e480ab270b3cd Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet
Date: Wed, 29 Nov 2023 16:29:12 +
Subject: [PATCH 1/7] [libc] Add more functions in CPP/bit.h
---
libc/src/
davemgreen wrote:
Do you have any analysis on the expected magnitude of the inaccuracy we might
expect from performing the fdiv/trunc/fma vs the call to fmod?
https://github.com/llvm/llvm-project/pull/67642
___
lldb-commits mailing list
lldb-commits@l
piotrAMD wrote:
Rebased and added missing live-throughs.
https://github.com/llvm/llvm-project/pull/73786
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/73099
>From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 19 Sep 2023 08:37:18 -0700
Subject: [PATCH 1/6] [C23] Implement N3018: The constexpr specifier f
@@ -2485,12 +2485,12 @@ bool VarDecl::mightBeUsableInConstantExpressions(const
ASTContext &C) const {
// In C++, const, non-volatile variables of integral or enumeration types
// can be used in constant expressions.
- if (getType()->isIntegralOrEnumerationType())
+ if (
https://github.com/Fznamznon updated
https://github.com/llvm/llvm-project/pull/73099
>From 1d70b7726e7d1f11622a6d5c8246b0737e024c8d Mon Sep 17 00:00:00 2001
From: "Podchishchaeva, Mariya"
Date: Tue, 19 Sep 2023 08:37:18 -0700
Subject: [PATCH 1/6] [C23] Implement N3018: The constexpr specifier f
=?utf-8?q?Jos=C3=A9?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Nominating @JDevlieghere to review this.
https://github.com/llvm/llvm-project/pull/69422
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/69422
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
@@ -252,11 +253,16 @@ void Symbol::GetDescription(Stream *s,
lldb::DescriptionLevel level,
s
DavidSpickett wrote:
If this code is calling a library - which itself is already tested, that's fine
but any smoke test we can do would be good.
E.g. set a bogus URL and expect that it fails to use it (assuming it does so
visibly). Just to check the integration.
https://github.com/llvm/llvm-p
DavidSpickett wrote:
Please add a note to
https://github.com/llvm/llvm-project/blob/main/llvm/docs/ReleaseNotes.rst#changes-to-lldb,
since this is quite a substantial new feature.
> Test Plan:
Did this get discussed? I don't see any tests here.
https://github.com/llvm/llvm-project/pull/70996
83 matches
Mail list logo
