=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
Author: José Lira Junior
Date: 2023-11-24T15:48:16Z
New Revision: bd8f1068cad06b0f0342ac7ef351bf01c2e27322
URL:
https://github.com/llvm/llvm-project/commit/bd8f1068cad06b0f0342ac7ef351bf01c2e27322
DIFF:
https://github.com/llvm/llvm-project/commit/bd8f1068cad06b0f0342ac7ef351bf01c2e27322.diff
L
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
> Also, I tried using the --fixup flag on the second commit, does that mean the
> squashing is automatic or I need to squash the commits and push again?
Honestly I've never used that flag. I'm not sure it matters with t
junior-jl wrote:
> Opinions differ on what goes in a commit message but this seems fine to me,
> I'd just remove the sub-headings. My usual rule is that folks can choose not
> to read it if they don't want to, include as much information as you would
> want to see if you yourself had to come b
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/73321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/73321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I might be butchering the meaning of the message, but you see what I'm going
for.
https://github.com/llvm/llvm-project/pull/73321
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
@@ -1926,12 +1930,13 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
// TypeSystemClang is always in C++ mode, but some compilers such as
// GCC and Clang give empty structs a size of 0 in C mode (in contrast to
// the size of 1 for emp
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: David Spickett (DavidSpickett)
Changes
…rpreter
It was:
```
error: there is no embedded script interpreter in this mode.
```
1. What does "mode" mean?
2. It implies there might be an embedded script interpreter for some other
"mode", what
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/73321
…rpreter
It was:
```
error: there is no embedded script interpreter in this mode.
```
1. What does "mode" mean?
2. It implies there might be an embedded script interpreter for some other
"mode", whatever
@@ -1926,12 +1930,13 @@ DWARFASTParserClang::ParseStructureLikeDIE(const
SymbolContext &sc,
// TypeSystemClang is always in C++ mode, but some compilers such as
// GCC and Clang give empty structs a size of 0 in C mode (in contrast to
// the size of 1 for emp
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6b87d84ff45d03c244e7511fba9359776ce27977
5fb8fd532fe767feb2d361f9552ff31ea7770663 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Haojian Wu (hokein)
Changes
Part of fixes for #72913.
clang emits `DW_AT_alignment` attribute, however LLDB didn't respect it,
resulting in incorrect RecordDecls built by lldb.
This only fixes non-inheritance cases. The inheritance case w
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/73307
Part of fixes for #72913.
clang emits `DW_AT_alignment` attribute, however LLDB didn't respect it,
resulting in incorrect RecordDecls built by lldb.
This only fixes non-inheritance cases. The inheritance case wi
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett approved this pull request.
This LGTM just fixup the PR message and you can merge it.
(if you don't have the permissions to do that, I can do it for you, let me know
when you're ready)
https://github.com/ll
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Opinions differ on what goes in a commit message but this seems fine to me, I'd
just remove the sub-headings. My usual rule is that folks can choose not to
read it if they don't want to, include as much information as y
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
https://github.com/taalhaataahir0102 updated
https://github.com/llvm/llvm-project/pull/69422
>From
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior
Message-ID:
In-Reply-To:
https://github.com/taalhaataahir0102 updated
https://github.com/llvm/llvm-project/pull/69422
>From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 M
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>,
=?utf-8?q?José?= L. Junior ,
=?utf-8?q?José?= L. Junior ,taalhaataahir0102
<23100...@lums.edu.pk>
Message-ID:
In-Reply-To:
https://github.com/taalhaataahir0102 updated
https://github.com/llvm/llvm-project/pull/69422
>From
20 matches
Mail list logo
