junior-jl wrote:
> Also could you include a bit more explanation of the problem in the commit
> message. The issue is great, but it'll save someone a few clicks if you just
> include a sentence or two more in the commit message.
I added more information. Now that you taught me that the PR desc
junior-jl wrote:
> I was about to tell you about the `process launch -m` shortcut, then I
> realised you added that yourself :) (I'm using it all the time now)
Haha, that's great to know! 🥹
> This is actually good news then, we already have test coverage. Please
> re-order the expected output
@@ -265,8 +265,6 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
process_sp->SyncIOHandler(0, std::chrono::seconds(2));
llvm::StringRef data = stream.GetString();
junior-jl wrote:
Done! Yes, as you expected,
@@ -282,6 +280,8 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
exe_module_sp->GetFileSpec().GetPath().c_str(), archname);
}
result.SetStatus(eReturnStatusSuccessFinishResult);
+if (!data.empty())
---
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/73173
From e451fe7a466f90557c301f0775d65caaa8955a8c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Wed, 22 Nov 2023 18:26:14 -0300
Subject: [PATCH 1/2] [lldb] correct inconsistent order of
DavidSpickett wrote:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests
LLVM is "the pull request title and description", from my experience. You get a
final chance to edit it
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
junior-jl wrote:
> When you're doing these updates, remember that the PR's message is the one
> used for the final merge. You can update both if you like, but the PR message
> wins.
(for llvm-project that is, this is a per-repository setting)
I was Googling about this now. Thank you for the cl
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/73173
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
When you're doing these updates, remember that the PR's message is the one used
for the final merge. You can update both if you like, but the PR message wins.
(for llvm-project that is, this is a per-repository setting)
https://github.com/llvm/llvm-project/pull/69422
_
junior-jl wrote:
Hi @emaste, I've updated the commit message. When squashing the commits, the
commit message defaulted to the names of the previous commits. I've added a
brief description of the contribution – please let me know if this needs any
adjustments.
https://github.com/llvm/llvm-proj
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From c416443a93f7113a7f57d337682ec4862438522d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH] [lldb] colorize symbols in image lookup
https://github.com/yi-wu-arm updated
https://github.com/llvm/llvm-project/pull/71222
>From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001
From: Yi Wu
Date: Mon, 6 Nov 2023 19:55:06 +
Subject: [PATCH 1/8] FDATE extension implementation: get date and time in
ctime format
emaste wrote:
commit message has typo `coreected`
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Also could you include a bit more explanation of the problem in the commit
message. The issue is great, but it'll save someone a few clicks if you just
include a sentence or two more in the commit message.
https://github.com/llvm/llvm-project/pull/73173
___
DavidSpickett wrote:
You can use a few specific terms to auto close an issue when a related PR
lands:
https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests
`Fixes #12345` for example.
https://github.com/llvm/llvm-p
DavidSpickett wrote:
I was about to tell you about the `process launch -m` shortcut, then I realised
you added that yourself :)
> Upon implementing this change, two tests failed:
> lldb/test/Shell/Breakpoint/jit-loader_jitlink_elf.test and
> lldb/test/Shell/Breakpoint/jit-loader_rtdyld_elf.te
@@ -282,6 +280,8 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
exe_module_sp->GetFileSpec().GetPath().c_str(), archname);
}
result.SetStatus(eReturnStatusSuccessFinishResult);
+if (!data.empty())
---
@@ -265,8 +265,6 @@ class CommandObjectProcessLaunch : public
CommandObjectProcessLaunchOrAttach {
process_sp->SyncIOHandler(0, std::chrono::seconds(2));
llvm::StringRef data = stream.GetString();
DavidSpickett wrote:
If we don't need `data`
DavidSpickett wrote:
I took the liberty of adding some blank lines to the PR message, just for
readability. Also, I suspect that git might prefer having the co-author line
separated from the message, but it probably doesn't matter anyway.
https://github.com/llvm/llvm-project/pull/69422
___
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I expected this coming out of draft to do something with subscribers, but that
hasn't happened. No problem, I'll do it manually.
@llvm/pr-subscribers-lldb This change is now ready for review. There is a lot
of discussion here already but it has all been resolved so you can
https://github.com/taalhaataahir0102 edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -163,7 +166,10 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub for: ");
- symbol->GetName().Dump(s);
+ if (p
DavidSpickett wrote:
> This is the current issue for symbol search:
> https://github.com/llvm/llvm-project/issues/57372
Put `Fixes 57372` instead.
> Co-author: @junior-jl
This needs to be in the `Co-authored-by: NAME ` format.
https://github.com/llvm/llvm-project/pull/69422
__
28 matches
Mail list logo
