@@ -450,9 +450,9 @@ bool FlattenCFGOpt::MergeIfRegion(BasicBlock *BB,
IRBuilder<> &Builder) {
if (!CompareIfRegionBlock(IfTrue1, IfTrue2, SecondEntryBlock))
return false;
} else if (IfTrue1 == FirstEntryBlock) {
-// The then-path is empty, so we must use "and"
https://github.com/mahtohappy updated
https://github.com/llvm/llvm-project/pull/72522
>From ce4f4fc02e25359c8f38ff9ecf2a2d82aa90df72 Mon Sep 17 00:00:00 2001
From: mahtohappy
Date: Thu, 16 Nov 2023 06:53:24 -0800
Subject: [PATCH 1/3] Fix Logical expression used for merged conditional if
---
l
https://github.com/mahtohappy updated
https://github.com/llvm/llvm-project/pull/72522
>From ce4f4fc02e25359c8f38ff9ecf2a2d82aa90df72 Mon Sep 17 00:00:00 2001
From: mahtohappy
Date: Thu, 16 Nov 2023 06:53:24 -0800
Subject: [PATCH 1/2] Fix Logical expression used for merged conditional if
---
l
@@ -450,9 +450,9 @@ bool FlattenCFGOpt::MergeIfRegion(BasicBlock *BB,
IRBuilder<> &Builder) {
if (!CompareIfRegionBlock(IfTrue1, IfTrue2, SecondEntryBlock))
return false;
} else if (IfTrue1 == FirstEntryBlock) {
-// The then-path is empty, so we must use "and"
@@ -0,0 +1,31 @@
+//===- SPIRVToLLVMIRTranslation.cpp - Translate SPIRV to LLVM IR
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -61,6 +63,7 @@ registerAllGPUToLLVMIRTranslations(DialectRegistry ®istry)
{
registerLLVMDialectTranslation(registry);
registerNVVMDialectTranslation(registry);
registerROCDLDialectTranslation(registry);
+ registerSPIRVDialectTranslation(registry);
jo
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From 749453ae9878dbc38c49db3a3086882ae886d849 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Thu, 16 Nov 2023 15:46:33 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
lldb/
@@ -184,6 +184,7 @@ class LLDB_API SBTarget {
SBProcess LoadCore(const char *core_file);
SBProcess LoadCore(const char *core_file, lldb::SBError &error);
+ SBProcess LoadCore(SBFile &file, lldb::SBError &error);
bulbazord wrote:
Actually, can the `SBFile
https://github.com/bulbazord approved this pull request.
LGTM I think, but wait a little bit for Jonas and/or Greg to give it another
pass.
https://github.com/llvm/llvm-project/pull/71769
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https
https://github.com/bulbazord approved this pull request.
Awesome!
https://github.com/llvm/llvm-project/pull/72579
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -25,13 +25,13 @@ define void @test_not_crash(i32 %in_a) #0 {
entry:
%cmp0 = icmp eq i32 %in_a, -1
%cmp1 = icmp ne i32 %in_a, 0
- %cond0 = and i1 %cmp0, %cmp1
+ %cond0 = or i1 %cmp0, %cmp1
br i1 %cond0, label %b0, label %b1
b0:; pre
@@ -450,9 +450,9 @@ bool FlattenCFGOpt::MergeIfRegion(BasicBlock *BB,
IRBuilder<> &Builder) {
if (!CompareIfRegionBlock(IfTrue1, IfTrue2, SecondEntryBlock))
return false;
} else if (IfTrue1 == FirstEntryBlock) {
-// The then-path is empty, so we must use "and"
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From 8aa5348b7ad6491c9363c0fcd41668e2e8ccda1a Mon Sep 17 00:00:00 2001
From: George Hu
Date: Thu, 16 Nov 2023 15:46:33 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
lldb/
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From 0037db8a5753e19726c56a4d8a968685860fe4e8 Mon Sep 17 00:00:00 2001
From: George Hu
Date: Thu, 16 Nov 2023 15:46:33 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
lldb/
@@ -47,6 +47,10 @@ namespace llvm {
using llvm::object::BuildIDRef;
+SmallVector DebuginfodUrls;
clayborg wrote:
Maybe make this `std::optional< SmallVector >` and get rid of
`DebuginfodUrlsSet` below? We might want a std::mutex here to protect
multi-threa
https://github.com/clayborg commented:
Looks good, a few suggestions in `llvm/lib/Debuginfod/Debuginfod.cpp`. I will
let Jonas comment if the settings are done the right way in the plug-in
manager. Plug-in code looks fine.
https://github.com/llvm/llvm-project/pull/70996
___
@@ -46,6 +46,10 @@ bool canUseDebuginfod();
/// environment variable.
SmallVector getDefaultDebuginfodUrls();
+/// Sets the list of debuginfod server URLs to query. This overrides the
+/// environment variable DEBUGINFOD_URLS.
+void setDefaultDebuginfodUrls(SmallVector URLs);
@@ -62,15 +66,23 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
@@ -62,15 +66,23 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
@@ -62,15 +66,23 @@ bool canUseDebuginfod() {
}
SmallVector getDefaultDebuginfodUrls() {
- const char *DebuginfodUrlsEnv = std::getenv("DEBUGINFOD_URLS");
- if (DebuginfodUrlsEnv == nullptr)
-return SmallVector();
-
- SmallVector DebuginfodUrls;
- StringRef(DebuginfodU
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/70996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ldionne wrote:
Gentle ping. There's outstanding feedback to address on this review.
@ZijunZhaoCCK if you don't think you'll have time to pursue this PR anymore,
it's all good but please let us know so we can assign it to someone else!
https://github.com/llvm/llvm-project/pull/66963
___
@@ -799,7 +799,33 @@ DNBProcessAttachWait(RNBContext *ctx, const char
*waitfor_process_name,
break;
}
- ::usleep(waitfor_interval); // Sleep for WAITFOR_INTERVAL, then poll
again
+ // Now we're going to wait a while before polling again. But we also
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
On macOS lldb normally goes through the DebugSymbols framework to find dSYMs --
by spotlight search on the local computer, or specially laid out directories,
or possibly calling a program which can down
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/72579
On macOS lldb normally goes through the DebugSymbols framework to find dSYMs --
by spotlight search on the local computer, or specially laid out directories,
or possibly calling a program which can download
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/66826
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Augusto Noronha
Date: 2023-11-16T14:20:14-08:00
New Revision: 46396108deb24564159c441c6e6ebfac26714d7b
URL:
https://github.com/llvm/llvm-project/commit/46396108deb24564159c441c6e6ebfac26714d7b
DIFF:
https://github.com/llvm/llvm-project/commit/46396108deb24564159c441c6e6ebfac26714d7b.dif
https://github.com/GeorgeHuyubo updated
https://github.com/llvm/llvm-project/pull/71769
>From be239ec76a426b6909b84b796785c7e1a9fe84aa Mon Sep 17 00:00:00 2001
From: George Hu
Date: Wed, 8 Nov 2023 16:25:34 -0800
Subject: [PATCH] Add new API in SBTarget for loading core from SBFile
---
lldb/i
@@ -799,7 +799,33 @@ DNBProcessAttachWait(RNBContext *ctx, const char
*waitfor_process_name,
break;
}
- ::usleep(waitfor_interval); // Sleep for WAITFOR_INTERVAL, then poll
again
+ // Now we're going to wait a while before polling again. But we also
@@ -3843,6 +3843,13 @@ thread_result_t Process::RunPrivateStateThread(bool
is_secondary_thread) {
") woke up with an interrupt while attaching - "
"forwarding interrupt.",
__FUNCTION__, static_cast(this), GetID());
+
https://github.com/jasonmolenda closed
https://github.com/llvm/llvm-project/pull/72559
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jason Molenda
Date: 2023-11-16T13:58:07-08:00
New Revision: 5f64b940761002efcff04c40d6e882167d05197c
URL:
https://github.com/llvm/llvm-project/commit/5f64b940761002efcff04c40d6e882167d05197c
DIFF:
https://github.com/llvm/llvm-project/commit/5f64b940761002efcff04c40d6e882167d05197c.diff
https://github.com/medismailben approved this pull request.
Makes sense. LGTM!
https://github.com/llvm/llvm-project/pull/72559
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/GeorgeHuyubo edited
https://github.com/llvm/llvm-project/pull/71769
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -627,7 +628,7 @@ class Target : public std::enable_shared_from_this,
// used.
const lldb::ProcessSP &CreateProcess(lldb::ListenerSP listener_sp,
llvm::StringRef plugin_name,
- const FileSpec *cr
@@ -799,7 +799,33 @@ DNBProcessAttachWait(RNBContext *ctx, const char
*waitfor_process_name,
break;
}
- ::usleep(waitfor_interval); // Sleep for WAITFOR_INTERVAL, then poll
again
+ // Now we're going to wait a while before polling again. But we also
@@ -3843,6 +3843,13 @@ thread_result_t Process::RunPrivateStateThread(bool
is_secondary_thread) {
") woke up with an interrupt while attaching - "
"forwarding interrupt.",
__FUNCTION__, static_cast(this), GetID());
+
ZequanWu wrote:
> Some further discussion/pre-work needed before proceeding with this PR.
These two discussions are addressed and this is ready to be reviewed.
1. Support for merging with multiple correlation files will be done in a
separate change.
2. Removed the `VARIANT_MASK_BIN_CORRELATE`
https://github.com/jasonmolenda approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/72565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/junior-jl updated
https://github.com/llvm/llvm-project/pull/69422
From 2c23aaf231beef11d3e0db6506fe82323a0be6a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jos=C3=A9=20L=2E=20Junior?=
Date: Tue, 7 Nov 2023 16:57:18 -0300
Subject: [PATCH 1/5] [lldb] colorize symbols in image look
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/72565
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a322d50804c5248f9e2981f3733bcb598fa13d51
f5d66b41bc06840648725daa640c6923b0eab923 --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jimingham)
Changes
Currently when you interrupt a:
(lldb) process attach -w -n some_process
lldb just closes the connection to the stub and kills the process it made for
the attach. The stub at the other end notices the connection
https://github.com/jimingham created
https://github.com/llvm/llvm-project/pull/72565
Currently when you interrupt a:
(lldb) process attach -w -n some_process
lldb just closes the connection to the stub and kills the process it made for
the attach. The stub at the other end notices the connec
Author: Alex Langford
Date: 2023-11-16T12:13:44-08:00
New Revision: a322d50804c5248f9e2981f3733bcb598fa13d51
URL:
https://github.com/llvm/llvm-project/commit/a322d50804c5248f9e2981f3733bcb598fa13d51
DIFF:
https://github.com/llvm/llvm-project/commit/a322d50804c5248f9e2981f3733bcb598fa13d51.diff
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/66826
>From 5323ac957268e469207aae340e15f6809b53bf53 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 16 Nov 2023 11:31:55 -0800
Subject: [PATCH] [lldb] Add interface to check if UserExpression::Parse() is
@@ -231,6 +231,18 @@ class Stream {
/// The string to be output to the stream.
size_t PutCString(llvm::StringRef cstr);
+ /// Output a C string to the stream with color highlighting.
+ ///
+ /// Print a C string \a text to the stream, applying color highlighting to
@@ -231,6 +231,18 @@ class Stream {
/// The string to be output to the stream.
size_t PutCString(llvm::StringRef cstr);
+ /// Output a C string to the stream with color highlighting.
+ ///
+ /// Print a C string \a text to the stream, applying color highlighting to
https://github.com/junior-jl edited
https://github.com/llvm/llvm-project/pull/69422
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dwblaikie wrote:
> > I'm arguing it doesn't fit it particularly well. We use it for bit fields -
> > which are pretty special, for instance, but it seems like this thing isn't
> > quite like that - it does have a whole byte size (if you allocated an array
> > of them, for instance, I'm guessin
@@ -163,7 +166,10 @@ bool SymbolContext::DumpStopContext(Stream *s,
ExecutionContextScope *exe_scope,
dumped_something = true;
if (symbol->GetType() == eSymbolTypeTrampoline)
s->PutCString("symbol stub for: ");
- symbol->GetName().Dump(s);
+ if (p
@@ -70,6 +72,32 @@ size_t Stream::PutCString(llvm::StringRef str) {
return bytes_written;
}
+void Stream::PutCStringColorHighlighted(llvm::StringRef text,
+const char *pattern) {
+ if (!pattern) {
+PutCString(text.data());
---
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
These error messages are written in a way that makes sense to an lldb
developer, but not to an end user who asks lldb to run on a compressed corefile
or whatever. Simplfy the messages.
---
Full diff:
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/72559
These error messages are written in a way that makes sense to an lldb
developer, but not to an end user who asks lldb to run on a compressed corefile
or whatever. Simplfy the messages.
>From cb79d7e6490db
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f8e8530f7377ab84b23c268454015fbcb95231c0
fcc27c3b81a8f2c0566af801e623d23f748fb04a --
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
When setting conditional breakpoints, we currently assume that a call to
UserExpression::Parse() can be cached and resued multiple times. This may not
be true for every user expression. Add a new metho
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/66826
>From fcc27c3b81a8f2c0566af801e623d23f748fb04a Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Tue, 19 Sep 2023 13:27:41 -0700
Subject: [PATCH] [lldb] Add interface to check if UserExpression::Parse() is
augusto2112 wrote:
@DavidSpickett thanks for reminding me. I'll add a comment describing the
situation.
Right now, for conditional breakpoints, we assume that the condition expression
is cacheable, since it's being run over and over again in the exact same
context. This works for C/C++, but
minglotus-6 wrote:
> One heads up, the latest 'git merge main' brings a failure in test
> https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/fuzzer/gc-sections.test
> :( . `ninja check-all` on a clean main gives the same failure. Hopefully it
> would be fixed soon.
This is fixed
silee2 wrote:
@antiagainst @kuhar Any comments?
https://github.com/llvm/llvm-project/pull/71430
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mahtohappy updated
https://github.com/llvm/llvm-project/pull/72522
>From ce4f4fc02e25359c8f38ff9ecf2a2d82aa90df72 Mon Sep 17 00:00:00 2001
From: mahtohappy
Date: Thu, 16 Nov 2023 06:53:24 -0800
Subject: [PATCH 1/2] Fix Logical expression used for merged conditional if
---
l
https://github.com/mahtohappy updated
https://github.com/llvm/llvm-project/pull/72522
>From ce4f4fc02e25359c8f38ff9ecf2a2d82aa90df72 Mon Sep 17 00:00:00 2001
From: mahtohappy
Date: Thu, 16 Nov 2023 06:53:24 -0800
Subject: [PATCH] Fix Logical expression used for merged conditional if
---
llvm/
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/72495
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2023-11-16T16:09:47Z
New Revision: 70900ec79984105c661a923aae2f993394ae7aae
URL:
https://github.com/llvm/llvm-project/commit/70900ec79984105c661a923aae2f993394ae7aae
DIFF:
https://github.com/llvm/llvm-project/commit/70900ec79984105c661a923aae2f993394ae7aae.diff
LOG:
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/72495
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/PAX-12-WU updated
https://github.com/llvm/llvm-project/pull/71222
>From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001
From: Yi Wu
Date: Mon, 6 Nov 2023 19:55:06 +
Subject: [PATCH 1/6] FDATE extension implementation: get date and time in
ctime format
https://github.com/PAX-12-WU updated
https://github.com/llvm/llvm-project/pull/71222
>From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001
From: Yi Wu
Date: Mon, 6 Nov 2023 19:55:06 +
Subject: [PATCH 1/6] FDATE extension implementation: get date and time in
ctime format
https://github.com/PAX-12-WU updated
https://github.com/llvm/llvm-project/pull/71222
>From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001
From: Yi Wu
Date: Mon, 6 Nov 2023 19:55:06 +
Subject: [PATCH 1/6] FDATE extension implementation: get date and time in
ctime format
https://github.com/PAX-12-WU updated
https://github.com/llvm/llvm-project/pull/71222
>From e0d99fb5baa4231ab351f7fd5abf0a1ffe589547 Mon Sep 17 00:00:00 2001
From: Yi Wu
Date: Mon, 6 Nov 2023 19:55:06 +
Subject: [PATCH 1/6] FDATE extension implementation: get date and time in
ctime format
DavidSpickett wrote:
> So I'd prefer something global and possibly under user control, rather than
> doing it from formatter side. How does this sound to you?
Sure, I can always set it to on when printing registers so that would work for
me.
https://github.com/llvm/llvm-project/pull/69815
__
Endilll wrote:
@DavidSpickett There is `SBValue:SetFormat()`, which takes `lldb::Format`. We
can invent a new format, e.g. `eFormatEnumWithValue`. Not every enum flows
through my formatter, as I'm actively improving emitted debug info so that LLDB
does the right thing by default (`[[clang::pre
DavidSpickett wrote:
This got forgotten it seems.
Could you add a comment in the header to address Jim's question?
So folks upstream know whether to care about overriding this for whatever new
thing they might be building (there are lots of mysterious methods over in llvm
and I end up ignorin
DavidSpickett wrote:
The existing code is
https://github.com/llvm/llvm-project/blob/865f54e501739f382d33866baebfd0f9aaad01bb/lldb/source/Core/DumpRegisterValue.cpp#L47.
Register contents is described as a packed struct with bitfields as members.
Now I am looking at making some of those enums s
DavidSpickett wrote:
Yeah sorry I dropped the context there, I copied over your change to
`lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp` into my changes to
get that output.
So what I meant to put across was that we are aiming for the same result.
https://github.com/llvm/llvm-proje
Endilll wrote:
> For this use case I'm setting options in lldb_private::DumpValueObjectOptions
> down in C++ but I'm not sure if those directly map to what a formatter would
> have access to.
@DavidSpickett What exactly do you set or unset there to get the output you're
showing? This approach
https://github.com/OutOfCache updated
https://github.com/llvm/llvm-project/pull/72381
>From 00d0f99207242befc8022031ccd8faf573cbf014 Mon Sep 17 00:00:00 2001
From: Jessica Del
Date: Tue, 14 Nov 2023 22:17:26 +0100
Subject: [PATCH 1/3] [AMDGPU] - Add constant folding for s_quadmask
If the input
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 979eb558dd7c203be10fa24ab2b0d7cb93c3443b
3302aaf961982c5c32d692fb813fa25ad7ea33d4 --
DavidSpickett wrote:
I would be interested in at least having a way to opt into this style, it would
be useful for registers for example here where I am experimenting with defining
`TCF` as an enum:
```
(lldb) register read mte_ctrl
mte_ctrl = 0x0007fffb
= (TAGS = 65535, TCF =
https://github.com/OutOfCache updated
https://github.com/llvm/llvm-project/pull/72381
>From 00d0f99207242befc8022031ccd8faf573cbf014 Mon Sep 17 00:00:00 2001
From: Jessica Del
Date: Tue, 14 Nov 2023 22:17:26 +0100
Subject: [PATCH 1/2] [AMDGPU] - Add constant folding for s_quadmask
If the input
@@ -2965,6 +2965,7 @@ void DWARFASTParserClang::ParseSingleMember(
// data members is DW_AT_declaration, so we check it instead.
// FIXME: Since DWARFv5, static data members are marked DW_AT_variable so we
// can consistently detect them on both GCC and Clang without belo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/72495.diff
1 Files Affected:
- (modified) lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
(+2-2)
``diff
diff --git a/lld
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/72495
None
>From cf66beffe36e53fed5740775fa50b767a62f2c50 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Thu, 16 Nov 2023 08:46:37 +
Subject: [PATCH] [lldb][DWARFASTParserClang][NFC] Clarify comment around
82 matches
Mail list logo
