clayborg wrote:
Sounds good, I am ok since everyone else is ok with this. Thanks for the
comments.
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
jimingham wrote:
I don't understand how this helps. You can't write DWARF (or other lldb
plugins) w/o both exporting the API that those plugins are supposed to
implement (which should properly go in the `plugins` namespace whatever we call
it), but also all of other API's in lldb_private that
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/68866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
And if we ever make external plug-ins, they wouldn't be expected to use either
the "lldb_private::plugins" or "lldb_plugins" namespaces as those are solely
for built in stuff.
https://github.com/llvm/llvm-project/pull/68150
___
lldb-
clayborg wrote:
But if everyone else prefers the current state of this patch, I am fine with it.
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
clayborg wrote:
I still think we should have a "lldb_private" namespace for generic code that
uses the internal virtual plug-in APIs. It would be nice to have the
"lldb_plugins" namespace for plugins and the DWARF plug-in would go into
"lldb_plugins::dwarf". Right now if we export "lldb_privat
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff b225934a4b0d2944958a53269665b00e7eae4875
92130a4fe2499a962e54d2628947ed1798ff8dc2 --
JDevlieghere wrote:
Okay, to answer my own question: the difference is the typescript vs native
plugin. I had missed that nuance. For the uninitiated, what most of us are
currently using is the native version because it's just a `package.json` +
`lldb-dap` binary, right? I guess I personally c
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Rename lldb-vscode to lldb-dap. This change is largely mechanical. The
following substitutions cover the majority of the changes in this commit:
s/VSCODE/DAP/
s/VSCode/DAP/
s/vscode/dap/
s/g
walter-erquinigo wrote:
Sure, Greg, I'll update my patch with the empty prefix.
I'll probably write the very basic Typescript wrapper in two weeks. I would
like to see it a point of contribution between different companies
https://github.com/llvm/llvm-project/pull/69238
___
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/69253
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -914,6 +914,11 @@ def get_variant_npos_value(index_byte_size):
if index == npos_value:
return " No Value"
+# Invalid index can happen when the variant is not initialized yet.
+template_arg_count = data_obj.GetType().GetNumberOfTemplateArguments()
+if
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/69253
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> @clayborg , I've updated this patch using launch and attach settings, which
> might be fine following what've been doing so far. Even though I agree that
> it'd be nice to read the GUI global configs, I think that all settings should
> be also configurable via launch and atta
JDevlieghere wrote:
> @JDevlieghere , @clayborg, what do you think of the idea of some of us in the
> LLDB community building a minimal typescript extension for lldb-vscode and
> upload it to the marketplace? Then companies building their custom debugging
> on top of lldb-vscode could just ext
clayborg wrote:
> > Can you check real quick if any native plug-ins can have and or access
> > global settings from the VS Code GUI? That would be the best way for all of
> > these. Maybe there is a combination mode where we have some typescript in
> > our extension, but still have a native DA
walter-erquinigo wrote:
@clayborg , I've updated this patch using launch and attach settings, which
might be fine following what've been doing so far. Even though I agree that
it'd be nice to read the GUI global configs, I think that all settings should
be also configurable via launch and atta
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 4595d0940738b42f19d4127f3743afbaa53f0691 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
walter-erquinigo wrote:
> Can you check real quick if any native plug-ins can have and or access global
> settings from the VS Code GUI? That would be the best way for all of these.
> Maybe there is a combination mode where we have some typescript in our
> extension, but still have a native DA
clayborg wrote:
Mainly asking since you just started adding things that fall into the "we need
global plug-in settings for lldb-vscode" recently and it will be good to make
sure we are doing things right from a VS code perspective. It would be nice to
not have all of our settings in our launch
clayborg wrote:
> @clayborg , good point, I'll move it to launch and attach settings.
Can you check real quick if any native plug-ins can have and or access global
settings from the VS Code GUI? That would be the best way for all of these.
Maybe there is a combination mode where we have some t
walter-erquinigo wrote:
@clayborg , good point, I'll move it to launch and attach settings.
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
bulbazord wrote:
> With "lldb-vscode" (which might be "lldb-dap" soon) being a native DAP
> plug-in, I believe this means we can't set settings in the IDE itself if we
> are not a typescript DAP plug-in.
>
> How would anyone specify this extra option when running lldb-vscode? Is there
> a way
https://github.com/clayborg requested changes to this pull request.
With "lldb-vscode" (which might be "lldb-dap" soon) being a native DAP plug-in,
I believe this means we can't set settings in the IDE itself if we are not a
typescript DAP plug-in.
How would anyone specify this extra option w
walter-erquinigo wrote:
> (Not related to this PR but I put up an
> [RFC](https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/)
> on Friday to rename it to `lldb-dap`. Putting it up here for extra
> visibility.)
Nice! I'll approve your PR if you make that change!
https://gi
jeffreytan81 wrote:
> We should add a test. Should be easy to access the "_M_index" child and set
> its value to something invalid and then make sure the summary is "".
Sure, I can do that.
https://github.com/llvm/llvm-project/pull/69253
___
lldb-co
https://github.com/clayborg commented:
We should add a test. Should be easy to access the "_M_index" child and set its
value to something invalid and then make sure the summary is "".
https://github.com/llvm/llvm-project/pull/69253
___
lldb-commits ma
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (jeffreytan81)
Changes
https://github.com/llvm/llvm-project/pull/68012/files added new data formatters
for LibStdC++ std::variant.
However, this formatter can crash if std::variant's index field has invalid
value (exceeds the number
JDevlieghere wrote:
(Not related to this PR but I put up an
[RFC](https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/)
on Friday to rename it to `lldb-dap`. Putting it up here for extra visibility.)
https://github.com/llvm/llvm-project/pull/69238
___
https://github.com/jeffreytan81 ready_for_review
https://github.com/llvm/llvm-project/pull/69253
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jeffreytan81 created
https://github.com/llvm/llvm-project/pull/69253
https://github.com/llvm/llvm-project/pull/68012/files added new data formatters
for LibStdC++ std::variant.
However, this formatter can crash if std::variant's index field has invalid
value (exceeds the n
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 3d14b2938e0fd6073cdafcea4a54071f23158b42 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
JDevlieghere wrote:
FWIW I like `:` because that's what the REPL uses and because ` already has a
different meaning in LLDB.
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
f6f944e77f741861e641e1dd46c30dcbaf8c83b7..5b2da88825a14d3a0825b4372e6ca7ffe4255c5e
lldb/p
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Walter Erquinigo (walter-erquinigo)
Changes
We've been using the backtick as our escape character, however that leads to a
weird experience on VS Code, because on most hosts, as soon as you type the
backtick on VS Code, the IDE will introd
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/69238
We've been using the backtick as our escape character, however that leads to a
weird experience on VS Code, because on most hosts, as soon as you type the
backtick on VS Code, the IDE will introduce ano
@@ -86,6 +86,39 @@ def LinalgContractionOpInterface :
OpInterface<"ContractionOpInterface"> {
/*methodBody=*/[{
return mlir::isRowMajorBatchMatmul($_op.getIndexingMaps());
}]>,
+InterfaceMethod<
+/*desc=*/[{
+ Returns whether the given op has index
@@ -96,6 +96,79 @@ bool mlir::isRowMajorBatchMatmul(ArrayAttr indexingMaps) {
return indexingMaps == maps;
}
+bool mlir::isVecmat(ArrayAttr indexingMaps) {
+ if (indexingMaps.size() != 3)
+return false;
+ auto map0 = cast(indexingMaps[0]).getValue();
d
https://github.com/dcaballe commented:
Awesome! Just a couple of minor comments from my side!
https://github.com/llvm/llvm-project/pull/68945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -86,6 +86,39 @@ def LinalgContractionOpInterface :
OpInterface<"ContractionOpInterface"> {
/*methodBody=*/[{
return mlir::isRowMajorBatchMatmul($_op.getIndexingMaps());
}]>,
+InterfaceMethod<
+/*desc=*/[{
+ Returns whether the given op has index
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Alex Langford (bulbazord)
Changes
This function always expects the pointer to be valid, a reference seems more
appropriate.
---
Full diff: https://github.com/llvm/llvm-project/pull/69231.diff
5 Files Affected:
- (modified) lldb/include/
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/69231
This function always expects the pointer to be valid, a reference seems more
appropriate.
>From fd70abe32d822be5a791f8650c86ca61a86fa755 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Mon, 16 Oct 2023 10:
@@ -240,4 +240,134 @@ TEST(isRowMajorBatchMatmul, FirstInputSwapped) {
EXPECT_THAT(maps, Not(Truly(isRowMajorBatchMatmul)));
}
+TEST(isVecmat, Simple) {
+ MLIRContext context;
+
+ AffineExpr k, n;
+ bindDims(&context, k, n);
+ auto mapA = AffineMapAttr::get(AffineMap::ge
@@ -240,4 +240,134 @@ TEST(isRowMajorBatchMatmul, FirstInputSwapped) {
EXPECT_THAT(maps, Not(Truly(isRowMajorBatchMatmul)));
}
+TEST(isVecmat, Simple) {
+ MLIRContext context;
+
+ AffineExpr k, n;
+ bindDims(&context, k, n);
+ auto mapA = AffineMapAttr::get(AffineMap::ge
@@ -240,4 +240,134 @@ TEST(isRowMajorBatchMatmul, FirstInputSwapped) {
EXPECT_THAT(maps, Not(Truly(isRowMajorBatchMatmul)));
}
+TEST(isVecmat, Simple) {
+ MLIRContext context;
+
+ AffineExpr k, n;
+ bindDims(&context, k, n);
+ auto mapA = AffineMapAttr::get(AffineMap::ge
erichkeane wrote:
> > Also, needs a release note.
>
> How do I do this? I cannot seem to find documentation on the process...
See docs/ReleaseNotes.rst.
https://github.com/llvm/llvm-project/pull/69010
___
lldb-commits mailing list
lldb-commits@lists.
@@ -13595,6 +13595,15 @@ bool IntExprEvaluator::VisitUnaryExprOrTypeTraitExpr(
Info.Ctx.getOpenMPDefaultSimdAlign(E->getArgumentType()))
.getQuantity(),
E);
+ case UETT_VectorElements: {
+QualType Ty = E->getTypeOfArgument();
+//
@@ -3083,6 +3083,19 @@ ScalarExprEmitter::VisitUnaryExprOrTypeTraitExpr(
E->getTypeOfArgument()->getPointeeType()))
.getQuantity();
return llvm::ConstantInt::get(CGF.SizeTy, Alignment);
+ } else if (E->getKind() == UETT_VectorElements) {
+//
@@ -0,0 +1,121 @@
+// RUN: %clang_cc1 -O1 -triple aarch64 -target-feature +neon %s -emit-llvm -o
- | FileCheck --check-prefixes=CHECK,NEON %s
lawben wrote:
Done.
https://github.com/llvm/llvm-project/pull/69010
___
lld
@@ -10136,6 +10136,9 @@ def err_vec_builtin_incompatible_vector : Error<
def err_vsx_builtin_nonconstant_argument : Error<
"argument %0 to %1 must be a 2-bit unsigned literal (i.e. 0, 1, 2 or 3)">;
+def err_vectorelements_non_vector : Error<
+ "'__builtin_vectorelements' arg
@@ -4351,6 +4352,17 @@ static bool CheckVecStepTraitOperandType(Sema &S,
QualType T,
return false;
}
+static bool CheckVectorElementsTraitOperandType(Sema &S, QualType T,
+SourceLocation Loc,
+
https://github.com/lawben updated
https://github.com/llvm/llvm-project/pull/69010
>From df8d0a53a31e1351bb6cd3b340e9012b489e9885 Mon Sep 17 00:00:00 2001
From: Lawrence Benson
Date: Wed, 11 Oct 2023 17:26:11 +0200
Subject: [PATCH 1/6] Add __builtin_vectorelements to get the number of
elements
https://github.com/doru1004 updated
https://github.com/llvm/llvm-project/pull/69005
>From cb4121c466a0fc357d6ca129bfdd4e7c5e2d11ee Mon Sep 17 00:00:00 2001
From: Doru Bercea
Date: Wed, 16 Nov 2022 17:23:48 -0600
Subject: [PATCH 1/2] Fix declare target implementation to support enter.
---
clan
Author: David Spickett
Date: 2023-10-16T10:23:45Z
New Revision: 3b23704f161c3dd89d4a0b637c9008f573cb87c8
URL:
https://github.com/llvm/llvm-project/commit/3b23704f161c3dd89d4a0b637c9008f573cb87c8
DIFF:
https://github.com/llvm/llvm-project/commit/3b23704f161c3dd89d4a0b637c9008f573cb87c8.diff
LOG
Author: David Spickett
Date: 2023-10-16T10:15:46Z
New Revision: 17fce286834344a5379288b68068224af74d51f0
URL:
https://github.com/llvm/llvm-project/commit/17fce286834344a5379288b68068224af74d51f0
DIFF:
https://github.com/llvm/llvm-project/commit/17fce286834344a5379288b68068224af74d51f0.diff
LOG
57 matches
Mail list logo
