[Lldb-commits] [lldb] [NFC] fix failed ompt tests on M1 device (PR #65696)

2023-09-07 Thread Lixi Zhou via lldb-commits
https://github.com/lixi-zhou updated https://github.com/llvm/llvm-project/pull/65696: >From eacec22651766c6c6961d14964ddb6a180fbfec0 Mon Sep 17 00:00:00 2001 From: Lixi Zhou Date: Thu, 7 Sep 2023 16:15:25 -0700 Subject: [PATCH] fix failed ompt test on M1 device --- openmp/runtime/test/ompt/ca

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-07 Thread Ronan Keryell via lldb-commits
@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( + loc

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-07 Thread Fabian Mora via lldb-commits
@@ -0,0 +1,70 @@ +//===- SerializeToSPIRV.cpp - Convert GPU kernel to SPIRV blob -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

2023-09-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Looks like this broke the X86 bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/59815/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 _

[Lldb-commits] [lldb] 3aa678a - [lldb/docs] Add section links to the top of the GDB to LLDB command map

2023-09-07 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-09-07T16:26:53-07:00 New Revision: 3aa678a777354824d18faa427983d10ecbdd8943 URL: https://github.com/llvm/llvm-project/commit/3aa678a777354824d18faa427983d10ecbdd8943 DIFF: https://github.com/llvm/llvm-project/commit/3aa678a777354824d18faa427983d10ecbdd8943.d

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread Jonas Devlieghere via lldb-commits
@@ -40,7 +40,8 @@ VSCode::VSCode() {"swift_catch", "Swift Catch", lldb::eLanguageTypeSwift}, {"swift_throw", "Swift Throw", lldb::eLanguageTypeSwift}}), focus_tid(LLDB_INVALID_THREAD_ID), sent_terminated_event(false), - stop_at_entry(false), is_

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/65687: >From fc0700e761db9761675c42826e8f5bfa5b510840 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 7 Sep 2023 18:35:10 -0400 Subject: [PATCH] [lldb-vscode] Make descriptive summaries and raw chil

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread Walter Erquinigo via lldb-commits
@@ -240,6 +240,16 @@ "timeout": { "type": "string", "description": "The time in seconds to wait

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread Jonas Devlieghere via lldb-commits
@@ -240,6 +240,16 @@ "timeout": { "type": "string", "description": "The time in seconds to wait

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo review_requested https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo review_requested https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo review_requested https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

2023-09-07 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/65687: "descriptive summaries" should only be used for small to medium binaries because of the performance penalty the cause when completing types. I'm defaulting it to false. Besides that, the "raw child" fo

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-07 Thread Jianhui Li via lldb-commits
Jianhui-Li wrote: > > At some point it would be nice to have some design document or > > documentation somewhere explaining how all these MLIR runners works, > > including this one. > > The idea is to eventually consolidate all runners into one. This PR is just > another piece of the puzzle.

[Lldb-commits] [lldb] [lldb][NFCI] Remove typedef for TypeCategoryMap::ValueSP (PR #65555)

2023-09-07 Thread via lldb-commits
https://github.com/jimingham commented: A good change, Value is a pretty loaded word in lldb, and doesn't seem directly relevant here. https://github.com/llvm/llvm-project/pull/6 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://li

[Lldb-commits] [lldb] [lldb-vscode] Display a more descriptive summary for containers and pointers (PR #65514)

2023-09-07 Thread Greg Clayton via lldb-commits
@@ -132,6 +132,84 @@ std::vector GetStrings(const llvm::json::Object *obj, return strs; } +/// Create a short summary for a container that contains the summary of its +/// first children, so that the user can get a glimpse of its contents at a +/// glance. +static std::opti

[Lldb-commits] [lldb] [lldb-vscode] Display a more descriptive summary for containers and pointers (PR #65514)

2023-09-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/65514 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Display a more descriptive summary for containers and pointers (PR #65514)

2023-09-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: This will cause large performance regressions when debugging large complex codebases due to the extra type completions that will now happen every time you stop somewhere and view variables. https://github.com/llvm/llvm-project/pull/65514 _

[Lldb-commits] [lldb] [lldb][NFCI] Remove typedef for TypeCategoryMap::ValueSP (PR #65555)

2023-09-07 Thread via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/6 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 140f616 - [lldb][NFCI] Remove typedef for TypeCategoryMap::ValueSP (#65555)

2023-09-07 Thread via lldb-commits
Author: Alex Date: 2023-09-07T10:16:55-07:00 New Revision: 140f6167b885b4e0d6672a7f41c2b2b551c0204d URL: https://github.com/llvm/llvm-project/commit/140f6167b885b4e0d6672a7f41c2b2b551c0204d DIFF: https://github.com/llvm/llvm-project/commit/140f6167b885b4e0d6672a7f41c2b2b551c0204d.diff LOG: [ll

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread via lldb-commits
https://github.com/bulbazord approved this pull request. All are excellent tips. Thanks for working on this, this is amazing! 😄 https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread via lldb-commits
@@ -258,3 +263,302 @@ then ``lldb B`` to trigger ``lldb-server B`` to go into that code and hit the breakpoint. ``lldb-server A`` is only here to let us debug ``lldb-server B`` remotely. +Debugging The Remote Protocol +- + +LLDB mostly follows the

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show a fake child with the raw value of synthetic types (PR #65552)

2023-09-07 Thread Greg Clayton via lldb-commits
clayborg wrote: Not sure I like this showing up all of the time. It is fine for people that want to debug synthetic child providers, but seeing this all of the time adds noise to the variable window for no real benefit. I believe that plug-ins can have settings within VS code and it would be n

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/65635: >From 7c511c4beb3258894a5b9ceb884b5469b00368c0 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 7 Sep 2023 11:05:36 +0100 Subject: [PATCH 1/2] [lldb][Docs] Additions to debuging LLDB page Adds the

[Lldb-commits] [lldb] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-07 Thread Nuri Amari via lldb-commits
NuriAmari wrote: > What about an option that just redirects the PrintIRInstrumentation output to > files instead of stderr? The files can be something like `$N-$modulename.ll` > where `$N` is an int that increments. Yeah that's more or less what I'm working on now. My plan is: - Add a flag th

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-07 Thread Arthur Eubanks via lldb-commits
aeubanks wrote: What about an option that just redirects the PrintIRInstrumentation output to files instead of stderr? The files can be something like `$N-$modulename.ll` where `$N` is an int that increments. https://github.com/llvm/llvm-project/pull/65179 _

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett review_requested https://github.com/llvm/llvm-project/pull/65635 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Docs] Additions to debuging LLDB page (PR #65635)

2023-09-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/65635: Adds the following: * A note that you can use attaching to debug the right lldb-server process, though there are drawbacks. * A section on debugging the remote protocol. * Reducing bugs, including reducing

[Lldb-commits] [lldb] Add flags to dump IR to a file before and after LLVM passes (PR #65179)

2023-09-07 Thread Nuri Amari via lldb-commits
https://github.com/NuriAmari closed https://github.com/llvm/llvm-project/pull/65179 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [RISCV] Added definition of Ventana veyron-v1 processor. (PR #65535)

2023-09-07 Thread via lldb-commits
@@ -93,4 +93,4 @@ // RUN: not %clang_cc1 -triple riscv64 -tune-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix TUNE-RISCV64 // TUNE-RISCV64: error: unknown target CPU 'not-a-cpu' -// TUNE-RISCV64-NEXT: note: valid target CPU values are: generic-rv64, rocket

[Lldb-commits] [lldb] [lldb][NFCI] Remove typedef for TypeCategoryMap::ValueSP (PR #65555)

2023-09-07 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. https://github.com/llvm/llvm-project/pull/6 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread Christian Sigg via lldb-commits
chsigg wrote: Landed: https://github.com/llvm/llvm-project/commit/42db67c3ab3f657333f1a6bc90fed828f754945e https://github.com/llvm/llvm-project/pull/65583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread Christian Sigg via lldb-commits
https://github.com/chsigg closed https://github.com/llvm/llvm-project/pull/65583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-07 Thread Renato Golin via lldb-commits
rengolin wrote: CI failure looks like Buildkite issue? ``` $ /etc/buildkite-agent/hooks/pre-checkout --   | BUILDKITE_REPO: https://github.com/llvm/llvm-project.git   | fatal: not a git repository (or any parent up to mount point /var/lib)   | Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread Oleksandr Alex Zinenko via lldb-commits
https://github.com/ftynse approved this pull request. https://github.com/llvm/llvm-project/pull/65583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-07 Thread Renato Golin via lldb-commits
rengolin wrote: > At some point it would be nice to have some design document or documentation > somewhere explaining how all these MLIR runners works, including this one. The idea is to eventually consolidate all runners into one. This PR is just another piece of the puzzle. Once we're all h

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread via lldb-commits
https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread via lldb-commits
https://github.com/wenzhi-cui review_requested https://github.com/llvm/llvm-project/pull/65583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Added erase() to fix memory leak of mlir/unittests/IR/InterfaceTest.cpp (PR #65583)

2023-09-07 Thread via lldb-commits
https://github.com/wenzhi-cui created https://github.com/llvm/llvm-project/pull/65583: None >From 76107e6a14ca1f496d29bc2f7cb752f39f2665bf Mon Sep 17 00:00:00 2001 From: wenzhi-cui Date: Thu, 7 Sep 2023 11:13:45 +0800 Subject: [PATCH 1/2] Fix AtomicInterfacesTdFiles missing deps/typos in Bazel

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

2023-09-07 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa723694321b9: [lldb] Add more ways to find split DWARF files (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://

[Lldb-commits] [lldb] a723694 - [lldb] Add more ways to find split DWARF files

2023-09-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-09-07T08:19:11Z New Revision: a723694321b993f6f53fedf50e70e9cf5a206357 URL: https://github.com/llvm/llvm-project/commit/a723694321b993f6f53fedf50e70e9cf5a206357 DIFF: https://github.com/llvm/llvm-project/commit/a723694321b993f6f53fedf50e70e9cf5a206357.diff LOG

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

2023-09-07 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. No problem. I doubt this is all of them but at least users can now workaround the gaps using the setting, and hack up one of these test cases to make reproducers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-07 Thread Guray Ozen via lldb-commits
https://github.com/grypp edited https://github.com/llvm/llvm-project/pull/65539 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-07 Thread Guray Ozen via lldb-commits
@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( + loc