Mordante added a comment.
Herald added subscribers: bviyer, jplehr.
For libc++ we like to clean up the review queue for the GitHub PR transition.
Is there still interest on working on this patch? If so would it be possible to
finish it before the Phabricator is changed to read only mode?
CHANG
Mordante updated this revision to Diff 555763.
Mordante marked an inline comment as done.
Mordante added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159127/new/
https://reviews.llvm.org/D159127
Files:
lldb/s
Mordante marked 4 inline comments as done.
Mordante added inline comments.
Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:986-993
+ "^std::__[[:alnum:]]+::chrono::"
+ "(((nano)|(micro)|(milli)|())seconds)|"
+ "(minutes)|"
+ "(hours)|"
DavidSpickett updated this revision to Diff 555762.
DavidSpickett added a comment.
Kind -> Type
Pull out the caching and size calculation into its own function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156687/new/
https://reviews.llvm.org/D15
https://github.com/shraiysh updated
https://github.com/llvm/llvm-project/pull/65243:
>From ff635ce0ce910f0cde248a4babb3c27333ddc108 Mon Sep 17 00:00:00 2001
From: Shraiysh Vaishay
Date: Sun, 3 Sep 2023 22:40:10 -0500
Subject: [PATCH 1/2] [mlir][OpenMP] Added omp.region operation
This patch add
kiranchandramohan wrote:
Please add a quick RFC in the mlir discourse channel.
Would it make sense to call it an internal region? Or specialize it further and
call it canonical_loop_region?
https://github.com/llvm/llvm-project/pull/65243
___
lldb-com
