[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

clayborg updated this revision to Diff 552966. clayborg added a comment. Address review comments: - Added documentation in DYLDRendezvous.h to explain how things are supposed to work - Updated the documentation in DYLDRendezvous::GetAction() to explain why we need to work around seeing two cons

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. This patch changes the theme and removes the inline table-of-contents that are always shown on the right. If there are any other changes needed to better support t

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

mib updated this revision to Diff 552871. mib added a comment. Revert deletions to `formatting.rst` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158323/new/ https://reviews.llvm.org/D158323 Files: lldb/docs/_static/lldb.css lldb/docs/conf.py lldb/docs/resources/build.rst lldb/

[Lldb-commits] [PATCH] D158663: [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `std::basic_string` is not a regex, and treating it as such could unintentio

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

clayborg added a comment. In D158583#4609320 , @DavidSpickett wrote: > I'm not familiar with this mechanism but just out of curiosity: `ld.so loads > the main executable and any dependent shared libraries and wants to update > the "_r_debug" structure,

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

aprantl added inline comments. Comment at: lldb/test/API/functionalities/dyld-multiple-rdebug/TestDyldWithMultupleRDebug.py:54 +self.assertIn("main", + thread.GetFrameAtIndex(0).GetDisplayFunctionName()) +process.Continue() Y

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

JDevlieghere added inline comments. Comment at: lldb/docs/conf.py:52-57 try: import sphinx_automodapi.automodapi except ModuleNotFoundError: print( f"install sphinx_automodapi with {sys.executable} -m pip install sphinx_automodapi"

[Lldb-commits] [lldb] a6c97a1 - [lldb/test] Fix `Crashlog/no-args.test` on ASAN builds (NFC)

Author: Med Ismail Bennani Date: 2023-08-23T07:32:35-07:00 New Revision: a6c97a1a308e413bda63cbeaa3bebe7b2e739902 URL: https://github.com/llvm/llvm-project/commit/a6c97a1a308e413bda63cbeaa3bebe7b2e739902 DIFF: https://github.com/llvm/llvm-project/commit/a6c97a1a308e413bda63cbeaa3bebe7b2e739902.

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:260-266 +// the dynamic loader. The problem happens as soon as the executable or +// shared library that exports another "_r_debug" is loaded by the dynamic +

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

DavidSpickett added a comment. I'm not familiar with this mechanism but just out of curiosity: `ld.so loads the main executable and any dependent shared libraries and wants to update the "_r_debug" structure, but it now finds "_r_debug" in the a.out program and updates the state in this other c

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett added a comment. > LGTM, fwiw. Thanks! I wanted to have someone who wasn't knee deep in this to look it over. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158506/new/ https://reviews.llvm.org/D158506 ___

[Lldb-commits] [PATCH] D158506: [lldb][AArch64] Add release notes and documentation for SME

DavidSpickett updated this revision to Diff 552623. DavidSpickett added a comment. - Correct speeling. - Drop repeated word. - Clarify vg/vq/vl explanation and end with a listing of each value for the example shown. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi