[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

mib added a comment. Shouldn't this be next to the other `Stream` class in `lldbUtility` ? Comment at: lldb/include/lldb/Host/StreamFile.h:12 #include "lldb/Host/File.h" #include "lldb/Utility/Stream.h" Do we really need this header ? We could forward decla

[Lldb-commits] [PATCH] D157463: [lldb] Sink StreamBuffer into lldbUtility

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldbUtility seems like a more suitable place for St

[Lldb-commits] [PATCH] D157165: [lldb] [darwin kernel debug] When looking for a Darwin kernel symbol file, call GetSharedModules before DownloadObjectAndSymbolFile

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d8d31bbf55c: When loading kernel binary, use DownloadObjectAndSymbolFile last (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [lldb] 0d8d31b - When loading kernel binary, use DownloadObjectAndSymbolFile last

Author: Jason Molenda Date: 2023-08-08T17:30:57-07:00 New Revision: 0d8d31bbf55cedc1dad5c165187a084c1430f407 URL: https://github.com/llvm/llvm-project/commit/0d8d31bbf55cedc1dad5c165187a084c1430f407 DIFF: https://github.com/llvm/llvm-project/commit/0d8d31bbf55cedc1dad5c165187a084c1430f407.diff

[Lldb-commits] [PATCH] D157165: [lldb] [darwin kernel debug] When looking for a Darwin kernel symbol file, call GetSharedModules before DownloadObjectAndSymbolFile

jasonmolenda updated this revision to Diff 548414. jasonmolenda added a comment. Rebase patch on current top of tree sources. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157165/new/ https://reviews.llvm.org/D157165 Files: lldb/source/Plugins/D

[Lldb-commits] [PATCH] D157460: [lldb] Sink StreamFile into lldbHost

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. StreamFile subclasses Stream (from lldbUtility) and

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

This revision was automatically updated to reflect the committed changes. Closed by commit rG1290869ef2f7: Show error messages from DebugSymbols DBGShellCommand agent (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D157160?vs=548015&id=548409#toc Repository: rG

[Lldb-commits] [lldb] 1290869 - Show error messages from DebugSymbols DBGShellCommand agent

Author: Jason Molenda Date: 2023-08-08T17:10:20-07:00 New Revision: 1290869ef2f72b7d59a92fa3cd48e6da29686c71 URL: https://github.com/llvm/llvm-project/commit/1290869ef2f72b7d59a92fa3cd48e6da29686c71 DIFF: https://github.com/llvm/llvm-project/commit/1290869ef2f72b7d59a92fa3cd48e6da29686c71.diff

[Lldb-commits] [PATCH] D157455: [lldb][NFCI] Remove MappedHash.h

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jasonmolenda, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is no longer used as of 8e71d14972b48df8c5b701

[Lldb-commits] [PATCH] D157450: [lldb][NFCI] Remove unused IOStreamMacros

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157450/new/ https://reviews.llvm.org/D157450 ___

[Lldb-commits] [PATCH] D157450: [lldb][NFCI] Remove unused IOStreamMacros

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jasonmolenda, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These are unused AFAICT. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5f81100e447: When ProcessMachCore has metadata for a binary, don't scan (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157168/new

[Lldb-commits] [lldb] c5f8110 - When ProcessMachCore has metadata for a binary, don't scan

Author: Jason Molenda Date: 2023-08-08T15:49:53-07:00 New Revision: c5f81100e4471dfc2a802afb9333ca2684e02f8e URL: https://github.com/llvm/llvm-project/commit/c5f81100e4471dfc2a802afb9333ca2684e02f8e DIFF: https://github.com/llvm/llvm-project/commit/c5f81100e4471dfc2a802afb9333ca2684e02f8e.diff

[Lldb-commits] [PATCH] D157361: [lldb] FIx data race in ThreadedCommunication

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Looks straightforward and makes sense. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157361/new/ https://reviews.llvm.org/D157361 __

[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

jasonmolenda updated this revision to Diff 548364. jasonmolenda added a comment. Rebase on current TOT sources, and add a comment to the ProcessMachCore::LoadBinariesViaMetadata prototype in the header documenting the meaning of the return value, I agree with Alex I should make this a little cl

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Core/DynamicLoader.cpp:241-242 + error.AsCString("")[0] != '\0') { +Stream &s = target.GetDebugger().GetError

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

bulbazord added inline comments. Comment at: lldb/include/lldb/Host/File.h:425-433 + ValueGuard DescriptorIsValid() const { +m_descriptor_mutex.lock(); +return ValueGuard(m_descriptor_mutex, + File::DescriptorIsValid(m_descriptor)); + } + + ValueGu

[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157168/new/ https://reviews.llvm.org/D157168 _

[Lldb-commits] [lldb] d5cad05 - [lldb] Remve old CODE_OWNERS.txt

Author: Jonas Devlieghere Date: 2023-08-08T08:55:00-07:00 New Revision: d5cad055062672689efac8395d3f1543c22ba569 URL: https://github.com/llvm/llvm-project/commit/d5cad055062672689efac8395d3f1543c22ba569 DIFF: https://github.com/llvm/llvm-project/commit/d5cad055062672689efac8395d3f1543c22ba569.d

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

This revision was automatically updated to reflect the committed changes. Closed by commit rG013a8fc26ef8: [lldb] Update LLDB Code Ownership (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15694

[Lldb-commits] [lldb] 013a8fc - [lldb] Update LLDB Code Ownership

Author: Jonas Devlieghere Date: 2023-08-08T08:54:03-07:00 New Revision: 013a8fc26ef8f953dbc715be433e70b2b5c906fa URL: https://github.com/llvm/llvm-project/commit/013a8fc26ef8f953dbc715be433e70b2b5c906fa DIFF: https://github.com/llvm/llvm-project/commit/013a8fc26ef8f953dbc715be433e70b2b5c906fa.d

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere added a comment. Alright, seems like we have consensus. The only person that hasn't chimed in yet is Greg, but based on a comment in another thread he might be OOO. We can alway address concerns post-commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https: