[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

This revision was automatically updated to reflect the committed changes. Closed by commit rG57bd882343f8: [lldb] Convert script native types to StructuredData counterpart (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155161/new/

[Lldb-commits] [lldb] 57bd882 - [lldb] Convert script native types to StructuredData counterpart

Author: Med Ismail Bennani Date: 2023-07-21T18:47:46-07:00 New Revision: 57bd882343f8e4cca598b6ad47da93476cffb987 URL: https://github.com/llvm/llvm-project/commit/57bd882343f8e4cca598b6ad47da93476cffb987 DIFF: https://github.com/llvm/llvm-project/commit/57bd882343f8e4cca598b6ad47da93476cffb987.

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks for bearing with me. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155161/new/ https://reviews.llvm.org/D155161 _

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib updated this revision to Diff 543122. mib marked 3 inline comments as done. mib added a comment. Address @JDevlieghere last comments. - Use `unique_ptr` instead of `shared_ptr` for PIMPL - Add missing new line after instrumentation macros - Move `ScriptObject` from `Utility` to `Interpreter`

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

This revision was automatically updated to reflect the committed changes. Closed by commit rGf09f0a6b1076: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr (authored by fdeazeve, committed by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] f09f0a6 - [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

Author: Felipe de Azevedo Piovezan Date: 2023-07-21T16:42:16-07:00 New Revision: f09f0a6b10765f0993255e52a62268472f586830 URL: https://github.com/llvm/llvm-project/commit/f09f0a6b10765f0993255e52a62268472f586830 DIFF: https://github.com/llvm/llvm-project/commit/f09f0a6b10765f0993255e52a62268472

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBScriptObject.h:47 +private: + std::shared_ptr m_opaque_sp; +}; Does this need to be a shared pointer as opposed to a unique pointer? If so please add a comment why. Comm

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

mib updated this revision to Diff 543101. mib edited the summary of this revision. mib added a comment. Address @JDevlieghere & @bulbazord comments: - Add `SBScriptObject` with PIMPL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155161/new/ https://reviews.llvm.org/D155161 Files: ll

[Lldb-commits] [PATCH] D155198: [lldb] Consider OP_addrx in DWARFExpression::Update_DW_OP_addr

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. LGTM. I agree with Adrian: we can go ahead and land this to unblock the bots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155198/new/ https://reviews.llvm.org/D15

Re: [Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

> On Jul 21, 2023, at 9:52 AM, J. Ryan Stinnett via Phabricator via > lldb-commits wrote: > > jryans added a comment. > > In D149213#4491889 , > @VladimirMakaev wrote: > >> I think there was an attempt in the past to build TypeSystemRust. Rust >> P

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

jryans added a comment. In D149213#4491889 , @VladimirMakaev wrote: > I think there was an attempt in the past to build TypeSystemRust. Rust > Project had a fork of LLDB with this implemented by Tom Tromey and CodeLLDB > maintainer(vadimcn) has one. Bo

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

VladimirMakaev marked an inline comment as done. VladimirMakaev added a comment. In D149213#4520309 , @tom.tromey wrote: >> Apart from just implementing type system itself (which is much bigger scope >> than this change) there are other non-trivial issu

[Lldb-commits] [PATCH] D155161: [lldb] Convert script native types to StructuredData counterpart

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. I'm okay with the ABI break given that this (1) hasn't made it into a release yet, (2) it is under active development by Ismail himself and (3) has existing adopters beyo

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

DavidSpickett updated this revision to Diff 542932. DavidSpickett added a comment. Rebase and put this after the SSVE registers patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154930/new/ https://reviews.llvm.org/D154930 Files: lldb/source/

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

DavidSpickett updated this revision to Diff 542930. DavidSpickett marked an inline comment as done. DavidSpickett added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154926/new/ https://reviews.llvm.org/D154926 Files: lldb/sou

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:81 opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskSVE); + // We may also have the Scalable M

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

jasonmolenda added a comment. Thanks for the feedback David. > You are missing a way to fix a high mem address, is that intentional? Or > would you get the high mem mask, change the setting, fix the address, as > needed by context. The FixAddress method will choose whether to use the high mem

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

DavidSpickett updated this revision to Diff 542911. DavidSpickett added a comment. Correct missing "tls" in test name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154930/new/ https://reviews.llvm.org/D154930 Files: lldb/source/Plugins/Process/

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

DavidSpickett updated this revision to Diff 542910. DavidSpickett added a comment. Refactor the test so there are tests for: - reading tpidr on non-SME systems - reading tpidr and tpidr2 on SME systems - tpidr2 not being present on non-SME systems You could try to fold the last one into the firs

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

DavidSpickett planned changes to this revision. DavidSpickett added a comment. In some sense it already is, it'll go in after the streaming mode SVE registers. Should we wait until we can show the full content including the ZA bit? Yeah, why not, we're in no rush. I have a patch locally for ZA

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

omjavaid added a comment. I guess there is not much gain from telling the user between sve/ssve mode for the moment. Can we defer this patch till SME registers are implemented? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://revi

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks very good much simpler from the first version. just a minor nit. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:81

[Lldb-commits] [PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151683/new/ https://reviews.llvm.org/D151683 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D155905: lldb RFC: Exposing set/get address masks, Fix*Address methods in SBProcess

DavidSpickett added a comment. The only part of this that's maybe tricky is the HighMem parts of it. Given the niche use case it should be ok if they turn out a bit awkward for general use. You are missing a way to fix a high mem address, is that intentional? Or would you get the high mem mask,

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

DavidSpickett marked 2 inline comments as done. DavidSpickett added a comment. Thanks for the review, I'll try making the test a bit more flexible so we can read both registers at once for a bit more coverage. Comment at: lldb/test/API/linux/aarch64/tls_registers/TestAArch64L

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good just a minor suggestion inline. Comment at: lldb/test/API/linux/aarch64/tls_registers/TestAArch64LinuxTLSRegisters.py:84 + +self.check_tls_reg("t