[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

jasonmolenda added a comment. FWIW when I was testing this locally, I was seeing paths like (lldb) p uuid_view (lldb_private::FileSpec) $0 = file: "AndroidModule.so" dir: "/var/folders/1b/976z5_5513l64wvrj15vkt80gn/T/lldb/49966/LocateModuleCallbackTest-GetOrCreateModuleWithCachedModuleAn

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

jasonmolenda added a comment. Like reading third-party/unittest/googletest/include/gtest/gtest-printers.h, I thought I could add a static PrintTo method? but index 6eb5b805d9d..93d98baa5be 100644 --- a/lldb/include/lldb/Utility/FileSpec.h +++ b/lldb/include/lldb/Utility/FileSpec.h @@ -1

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

jasonmolenda added a comment. My first thought was, but what about all the other unit tests doing this, and git grepping around, I think there's one in Interpreter/TestOptionValue.cpp and one in Interpreter/TestOptionValueFileColonLine.cpp. I'd like to see what @JDevlieghere thinks, this patc

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

splhack updated this revision to Diff 540594. splhack added a comment. Use GetPath() instead of Compare(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155333/new/ https://reviews.llvm.org/D155333 Files: lldb/unittests/Target/LocateModuleCallba

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

splhack added a comment. thanks @JDevlieghere @jasonmolenda, yeah `GetPath()` makes sense it could show the mismatch in human readable form. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155333/new/ https://reviews.llvm.org/D155333 __

[Lldb-commits] [PATCH] D155332: [lldb][NFC] Factor out CommandObject code filtering results based on scope

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155332/new/ https://reviews.llvm.org/D155332 __

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

jasonmolenda added a comment. I ran the TargetTests under lldb to see (this test doesn't fail on my arm64 mac desktop ftr). ASSERT_EQ calls `template AssertionResult CmpHelperEQ()` and that calls `FileSpec::operator==` on my desktop. Jonas suggested that we get the binary data dump of the F

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. `ASSERT_EQ` should call `operator==` under the hood. Why would that be flakey on arm64? Can we achieve this by changing the implementation to reimplement this with `FileS

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

jasonmolenda added a comment. Just curious -- would it be better to have a single `vg` register shown to the user which is the vector length in non-streaming mode when the processor is in non-streaming mode, and the vector length in streaming mode when the processor is in streaming mode? I have

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added a comment. D155333 should fix the flaky arm64 tests by replacing `ASSERT_EQ(FileSpec, FileSpec)` with `ASSERT_EQ(FileSpec::Compare(FileSpec, FileSpec, true), 0)`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D155334: [lldb] Make frame var --regex always search globals

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently frame var --regex sometimes searches globals, sometimes it doesn't. This happens because `StackFrame::GetVariabl

[Lldb-commits] [PATCH] D155333: [lldb][LocateModuleCallback] Fix FileSpec compare

splhack created this revision. splhack added reviewers: clayborg, jingham, bulbazord, jasonmolenda, JDevlieghere, rastogishubham. Herald added a subscriber: kristof.beyls. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscribe

[Lldb-commits] [PATCH] D155332: [lldb][NFC] Factor out CommandObject code filtering results based on scope

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We will need this code in a subsequent commit. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155332

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

clayborg accepted this revision. clayborg added a comment. LGTM Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3968 + layout_info.field_offsets.insert({inner_field, 0}); +} Add a newline CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added a comment. ok, sounds like ASSERT_EQ FileSpec does not work on Linux aarch64. will use FileSpec::Compare and double check on Linux aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ https://reviews.llvm.org/D153734 __

[Lldb-commits] [PATCH] D155035: [lldb][NFCI] Remove unneeded temporary std::string allocations in SBAPI

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ee633a24b8c: [lldb][NFCI] Remove unneeded temporary std::string allocations in SBAPI (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] 7ee633a - [lldb][NFCI] Remove unneeded temporary std::string allocations in SBAPI

Author: Alex Langford Date: 2023-07-14T10:46:42-07:00 New Revision: 7ee633a24b8ce87b3a9b2f0f4bd1aace634cd2a1 URL: https://github.com/llvm/llvm-project/commit/7ee633a24b8ce87b3a9b2f0f4bd1aace634cd2a1 DIFF: https://github.com/llvm/llvm-project/commit/7ee633a24b8ce87b3a9b2f0f4bd1aace634cd2a1.diff

[Lldb-commits] [lldb] ce22598 - Disable GetOrCreateModuleWithCachedModule and GetOrCreateModuleWithCachedModuleAndSymbol tests on arm64, because of test failures

Author: Shubham Sandeep Rastogi Date: 2023-07-14T13:41:27-04:00 New Revision: ce225982af734bdb68dc054017fc4411c179591c URL: https://github.com/llvm/llvm-project/commit/ce225982af734bdb68dc054017fc4411c179591c DIFF: https://github.com/llvm/llvm-project/commit/ce225982af734bdb68dc054017fc4411c179

[Lldb-commits] [PATCH] D155124: [lldb][Windows] Fix TestLocateModuleCallback

This revision was automatically updated to reflect the committed changes. Closed by commit rG43b9d62018fe: [lldb][Windows] Fix TestLocateModuleCallback (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155124/new/ https://reviews.

[Lldb-commits] [lldb] 43b9d62 - [lldb][Windows] Fix TestLocateModuleCallback

Author: Kazuki Sakamoto Date: 2023-07-14T10:36:57-07:00 New Revision: 43b9d62018fe53278dfcd2c46f4937a1664745bd URL: https://github.com/llvm/llvm-project/commit/43b9d62018fe53278dfcd2c46f4937a1664745bd DIFF: https://github.com/llvm/llvm-project/commit/43b9d62018fe53278dfcd2c46f4937a1664745bd.dif

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

splhack added a comment. @rastogishubham let me check. btw I'll commit D155124 to fix Windows tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ https://reviews.llvm.org/D153734 ___

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

rastogishubham added a comment. In D153734#4501034 , @rastogishubham wrote: > I am reverting both fb087c17c8230 > and > 7f1028e9df52b >

[Lldb-commits] [lldb] 55147ce - Revert "Revert "[lldb][LocateModuleCallback] Call locate module callback""

Author: Shubham Sandeep Rastogi Date: 2023-07-14T11:19:16-04:00 New Revision: 55147ceb62020633cd7e7d403120d3915f4be3b6 URL: https://github.com/llvm/llvm-project/commit/55147ceb62020633cd7e7d403120d3915f4be3b6 DIFF: https://github.com/llvm/llvm-project/commit/55147ceb62020633cd7e7d403120d3915f4b

[Lldb-commits] [lldb] a76b3be - Revert "Revert "[lldb][LocateModuleCallback] Fix LocateModuleCallbackTest""

Author: Shubham Sandeep Rastogi Date: 2023-07-14T11:19:16-04:00 New Revision: a76b3bec6c29f473fa0727c8aef01c7b31d400fd URL: https://github.com/llvm/llvm-project/commit/a76b3bec6c29f473fa0727c8aef01c7b31d400fd DIFF: https://github.com/llvm/llvm-project/commit/a76b3bec6c29f473fa0727c8aef01c7b31d4

[Lldb-commits] [lldb] 668a3ef - Revert "[lldb][LocateModuleCallback] Fix LocateModuleCallbackTest"

Author: Shubham Sandeep Rastogi Date: 2023-07-14T11:05:01-04:00 New Revision: 668a3efd42e7fea19a0d331f73345f2ac13cdf4f URL: https://github.com/llvm/llvm-project/commit/668a3efd42e7fea19a0d331f73345f2ac13cdf4f DIFF: https://github.com/llvm/llvm-project/commit/668a3efd42e7fea19a0d331f73345f2ac13c

[Lldb-commits] [lldb] df05449 - Revert "[lldb][LocateModuleCallback] Call locate module callback"

Author: Shubham Sandeep Rastogi Date: 2023-07-14T11:05:01-04:00 New Revision: df054499c35cdda02b196b2ca5c0a326abdc0a29 URL: https://github.com/llvm/llvm-project/commit/df054499c35cdda02b196b2ca5c0a326abdc0a29 DIFF: https://github.com/llvm/llvm-project/commit/df054499c35cdda02b196b2ca5c0a326abdc

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

rastogishubham added a comment. I am reverting both fb087c17c8230 and 7f1028e9df52b to see if the bot becomes green again Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

rastogishubham added a comment. The unit test LocateModuleCallbackTest.cpp is very flaky and is failing on the lldb arm64 incremental bot Notice build https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/2259/ passes and https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/2260/

[Lldb-commits] [PATCH] D149213: [lldb] Add basic support to Rust enums in TypeSystemClang

VladimirMakaev added a comment. I've reached out to Rust wg-debugging for additional feedback (https://rust-lang.zulipchat.com/#narrow/stream/317568-t-compiler.2Fwg-debugging/topic/Feedback.20on.20DW_TAG_variant_part.20support.20in.20LLDB) There a couple of edge cases (when using u128 enums) tha

[Lldb-commits] [PATCH] D155124: [lldb][Windows] Fix TestLocateModuleCallback

luporl accepted this revision. luporl added a comment. This revision is now accepted and ready to land. LGTM. It should fix the buildbot failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155124/new/ https://reviews.llvm.org/D155124 __

[Lldb-commits] [PATCH] D154705: [lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Sounds ok to me. We can always fix it if starts to cause trouble. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154705/new/ https://reviews.

[Lldb-commits] [PATCH] D155269: [lldb][AArch64] Add SME streaming vector length pseudo register

DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reading the SVE registers of streaming mode from non-streamin