[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. In D153735#4494999 , @splhack wrote: > https://lab.llvm.org/buildbot/#/builders/219/builds/4084 > > now fixing Windows tests. D155124 should fix the Windows test failures. Repository: rG LLV

[Lldb-commits] [PATCH] D155129: [lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace

mib accepted this revision. mib added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155129/new/ https://reviews.llvm.org/D155129 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D155129: [lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155129/new/ https://reviews.llvm.org/D155129 ___

[Lldb-commits] [lldb] fb087c1 - [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

Author: Kazuki Sakamoto Date: 2023-07-12T16:49:45-07:00 New Revision: fb087c17c82309404fe0ebf3505c186642a719f7 URL: https://github.com/llvm/llvm-project/commit/fb087c17c82309404fe0ebf3505c186642a719f7 DIFF: https://github.com/llvm/llvm-project/commit/fb087c17c82309404fe0ebf3505c186642a719f7.dif

[Lldb-commits] [PATCH] D155135: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb087c17c823: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155135/new/ htt

[Lldb-commits] [PATCH] D155137: [lldb] Forward declare SBPlatform and SBTypeMember in SBDefines

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.

[Lldb-commits] [PATCH] D155135: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

splhack added a comment. @jasonmolenda thanks for verifying this! and yes, I didn't realize `-DLLVM_ENABLE_ASSERTIONS=1` is missing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155135/new/ https://reviews.llvm.org/D155135 __

[Lldb-commits] [PATCH] D155135: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. unit tests pass clean with this patch, thanks! Maybe your mac build wasn't cmake'd with `-DLLVM_ENABLE_ASSERTIONS=1` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. @jasonmolenda D155135 should fix the `Debugger::CreateInstance` assert. (The assert does not repro locally though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://review

[Lldb-commits] [lldb] 71548de - Improve error msg in DNBProcessAttach if we can't stop inferior

Author: Jason Molenda Date: 2023-07-12T16:03:57-07:00 New Revision: 71548de4d885b74e7291db55e8705417ffd49c95 URL: https://github.com/llvm/llvm-project/commit/71548de4d885b74e7291db55e8705417ffd49c95 DIFF: https://github.com/llvm/llvm-project/commit/71548de4d885b74e7291db55e8705417ffd49c95.diff

[Lldb-commits] [PATCH] D155135: [lldb][LocateModuleCallback] Fix LocateModuleCallbackTest

splhack created this revision. splhack added reviewers: clayborg, jingham, bulbazord, jasonmolenda, JDevlieghere, mib. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D153734

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. I'm checking other `Debugger::CreateInstance` calls in unittests. Looks like it needs to call `Platform::SetHostPlatform` which is missing in LocateModuleCallbackTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15373

[Lldb-commits] [PATCH] D155129: [lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This has an `lldb_private` type in its parameter, it sh

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

jasonmolenda added a comment. Hm, let me try a clean build. `ninja check-lldb-unit` repo'ed the issue on my desktop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 _

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. @jasonmolenda thanks for the report. let me check. At least `ninja check-lldb-unit check-lldb-api-python_api-sbplatform` is ok on macOS arm64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

jasonmolenda added a comment. @splhack the shell tests are all asserting on Darwin systems (on my desktop and on the bots https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ https://green.lab.llvm.org/green/view/LLDB/job/as-lldb-cmake/ ): [ RUN ] LocateModuleCallbackTest.GetOrCre

[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb136f5b393c: Improve error messaging when debugserver fails to complete attaching (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [lldb] bb136f5 - Improve error messaging when debugserver fails to complete attaching

Author: Jason Molenda Date: 2023-07-12T15:01:39-07:00 New Revision: bb136f5b393c7c7fe821242d2734bbc5c7287560 URL: https://github.com/llvm/llvm-project/commit/bb136f5b393c7c7fe821242d2734bbc5c7287560 DIFF: https://github.com/llvm/llvm-project/commit/bb136f5b393c7c7fe821242d2734bbc5c7287560.diff

[Lldb-commits] [PATCH] D155124: [lldb][Windows] Fix TestLocateModuleCallback

splhack created this revision. splhack added reviewers: clayborg, jingham, bulbazord, jasonmolenda, JDevlieghere, mib. Herald added a project: All. splhack requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. D153735

[Lldb-commits] [PATCH] D155100: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

jasonmolenda added a comment. LGTM. Good description of the problem being addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155100/new/ https://reviews.llvm.org/D155100 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D155117: Platform qemu-user: Build path to qemu automatically if not specified

ted created this revision. Herald added a project: All. ted requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Get the path to qemu in the following order: 1. From the property platform.plugin.qemu-user.emulator-path 2. If that property is no

[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

jasonmolenda updated this revision to Diff 539721. jasonmolenda added a comment. Update the patch; that last one included a separate set of changes I was working on with Alex yesterday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155037/new/ htt

[Lldb-commits] [PATCH] D155037: Improve error messaging when debugserver fails to complete attaching to another process on Darwin systems

jasonmolenda updated this revision to Diff 539719. jasonmolenda added a comment. Update to incorporate Jonas' suggestion - adding MachProcess::GetParentProcessID and MachProcess::ProcessIsBeingDebugged, as well as the DNB passthrough functions. I didn't pass back optionals for the cases were w

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

splhack added a comment. https://lab.llvm.org/buildbot/#/builders/219/builds/4084 now fixing Windows tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/ https://reviews.llvm.org/D153735 ___

[Lldb-commits] [PATCH] D155107: Add support for llvm::MCInstPrinter::setPrintBranchImmAsAddress

ted created this revision. ted added reviewers: clayborg, jingham. Herald added a project: All. ted requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. llvm::MCInstPrinter has an option, controlled by setPrintBranchImmAsAddress, to print branch

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

This revision was automatically updated to reflect the committed changes. Closed by commit rGf03dbdb70aed: [lldb][LocateModuleCallback] Implement API, Python interface (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153735/new/

[Lldb-commits] [lldb] f03dbdb - [lldb][LocateModuleCallback] Implement API, Python interface

Author: Kazuki Sakamoto Date: 2023-07-12T11:33:51-07:00 New Revision: f03dbdb70aed74ed64c1a42a85e47e3f86315ae7 URL: https://github.com/llvm/llvm-project/commit/f03dbdb70aed74ed64c1a42a85e47e3f86315ae7 DIFF: https://github.com/llvm/llvm-project/commit/f03dbdb70aed74ed64c1a42a85e47e3f86315ae7.dif

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f1028e9df52: [lldb][LocateModuleCallback] Call locate module callback (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ http

[Lldb-commits] [lldb] 7f1028e - [lldb][LocateModuleCallback] Call locate module callback

Author: Kazuki Sakamoto Date: 2023-07-12T11:19:51-07:00 New Revision: 7f1028e9df52b4e7246f189a24684b1ca8c9bfbe URL: https://github.com/llvm/llvm-project/commit/7f1028e9df52b4e7246f189a24684b1ca8c9bfbe DIFF: https://github.com/llvm/llvm-project/commit/7f1028e9df52b4e7246f189a24684b1ca8c9bfbe.dif

[Lldb-commits] [PATCH] D153733: [lldb][LocateModuleCallback] Update SBFileSpec/SBModuleSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4fa6fafc43a: [lldb][LocateModuleCallback] Update SBFileSpec/SBModuleSpec (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153733/new/ h

[Lldb-commits] [lldb] c4fa6fa - [lldb][LocateModuleCallback] Update SBFileSpec/SBModuleSpec

Author: Kazuki Sakamoto Date: 2023-07-12T11:11:18-07:00 New Revision: c4fa6fafc43ad5374a29d542737c0238b85516e4 URL: https://github.com/llvm/llvm-project/commit/c4fa6fafc43ad5374a29d542737c0238b85516e4 DIFF: https://github.com/llvm/llvm-project/commit/c4fa6fafc43ad5374a29d542737c0238b85516e4.dif

[Lldb-commits] [PATCH] D153734: [lldb][LocateModuleCallback] Call locate module callback

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the detailed explanations, it all makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153734/new/ https://reviews.ll

[Lldb-commits] [PATCH] D153735: [lldb][LocateModuleCallback] Implement API, Python interface

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for the detailed explanation. We don't want internal users to add a callback with a baton to Platform.h as this would interfere with the APIs, so it is fine to not have a baton in P

[Lldb-commits] [PATCH] D155100: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155100/new/ https://reviews.llvm.org/D155100 _

[Lldb-commits] [PATCH] D155100: [lldb][NFC] Factor out code linking OSO addr of uninitialized GVs

fdeazeve created this revision. Herald added a project: All. fdeazeve requested review of this revision. Herald added subscribers: lldb-commits, wangpc. Herald added a project: LLDB. This code was introduced in 2fc93eabf7e132abd51d0ea0ad599beb3fa44334. In order to improve readability of ParseVaria

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

This revision was automatically updated to reflect the committed changes. Closed by commit rGded1bad64af0: Fix mixed disassembly showing source lines for "line 0" (authored by ted). Herald added a project: All. Changed prior to commit: https://reviews.llvm.org/D112931?vs=383810&id=539606#toc R

[Lldb-commits] [lldb] ded1bad - Fix mixed disassembly showing source lines for "line 0"

Author: Ted Woodward Date: 2023-07-12T11:39:11-05:00 New Revision: ded1bad64af0acf312d2464fcc4e826f89a720d0 URL: https://github.com/llvm/llvm-project/commit/ded1bad64af0acf312d2464fcc4e826f89a720d0 DIFF: https://github.com/llvm/llvm-project/commit/ded1bad64af0acf312d2464fcc4e826f89a720d0.diff

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

jasonmolenda added a comment. Ah, I understand, thanks for the explanation. What an unusual feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154926/new/ https://reviews.llvm.org/D154926 ___ lldb-c