[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h:386 +// to add 1 to its return value. +return m_lock

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

mib updated this revision to Diff 536542. mib added a subscriber: jasonmolenda. mib added a comment. Fix major typo, thanks @jasonmolenda ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154271/new/ https://reviews.llvm.org/D154271 Files: lldb/source/Plugins/ScriptInterpreter/Python/

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

mib updated this revision to Diff 536541. mib added a comment. Fix typo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154271/new/ https://reviews.llvm.org/D154271 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h lldb/source/Target/Process.cpp Inde

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

mib updated this revision to Diff 536540. mib edited the summary of this revision. mib added a comment. Use `std::atomic::fetch_{add, sub}` to address @JDevlieghere feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154271/new/ https://reviews.llvm.org/D154271 Files: lldb/source

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

mib added a comment. In D154271#4466339 , @JDevlieghere wrote: > In D154271#4466170 , @bulbazord > wrote: > >> Making `m_lock_count`'s type into `std::atomic` makes sense to me, >> but I'm a little confused abo

[Lldb-commits] [PATCH] D154271: [lldb] Fix data race when interacting with python scripts

JDevlieghere added a comment. In D154271#4466170 , @bulbazord wrote: > Making `m_lock_count`'s type into `std::atomic` makes sense to me, > but I'm a little confused about why `Process::LoadOperatingSystemPlugin` is > guarded by acquiring `m_thread_mute