[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. Fixed Windows test failures in D153390 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org/D152759 ___ lldb-comm

[Lldb-commits] [PATCH] D153390: [lldb][Windows] Fix ZipFileResolver tests

splhack created this revision. Herald added a project: All. splhack requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. D152759 introduced the Android .zip so file support, but it only considered POSIX path.

[Lldb-commits] [PATCH] D151765: [lldb] Introduce the FileSpecBuilder abstraction

clayborg added a comment. The idea behind FileSpec containing two ConstStrings, one for the directory and one for he filename is for lookup performance when searching thousands of line tables for a given file and line when setting breakpoints. Currently we pass in a FileSpec + line number and w

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

splhack added a comment. ResolveSharedLibraryPathWithZipExisting and ResolveSharedLibraryPathWithZipMissing are failing on Windows. Looking into. https://lab.llvm.org/buildbot/#/builders/219/builds/3674 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D152933: [lldb][Android] Add platform.plugin.remote-android.package-name

This revision was automatically updated to reflect the committed changes. Closed by commit rGfabd16c7460e: [lldb][Android] Add platform.plugin.remote-android.package-name (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152933/new

[Lldb-commits] [lldb] fabd16c - [lldb][Android] Add platform.plugin.remote-android.package-name

Author: Kazuki Sakamoto Date: 2023-06-20T16:17:21-07:00 New Revision: fabd16c7460e6cfae3106155ec79142bfa54db2e URL: https://github.com/llvm/llvm-project/commit/fabd16c7460e6cfae3106155ec79142bfa54db2e DIFF: https://github.com/llvm/llvm-project/commit/fabd16c7460e6cfae3106155ec79142bfa54db2e.dif

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

This revision was automatically updated to reflect the committed changes. Closed by commit rG49f55b025d81: [lldb][Android] Add PlatformAndroidTest (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.

[Lldb-commits] [lldb] 49f55b0 - [lldb][Android] Add PlatformAndroidTest

Author: Kazuki Sakamoto Date: 2023-06-20T16:15:02-07:00 New Revision: 49f55b025d81823fa7e2b287c8930a8304483e5a URL: https://github.com/llvm/llvm-project/commit/49f55b025d81823fa7e2b287c8930a8304483e5a DIFF: https://github.com/llvm/llvm-project/commit/49f55b025d81823fa7e2b287c8930a8304483e5a.dif

[Lldb-commits] [PATCH] D152759: [lldb][Android] Support zip .so file

This revision was automatically updated to reflect the committed changes. Closed by commit rG12dee9d3cd76: [lldb][Android] Support zip .so file (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152759/new/ https://reviews.llvm.org

[Lldb-commits] [lldb] 12dee9d - [lldb][Android] Support zip .so file

Author: Kazuki Sakamoto Date: 2023-06-20T15:21:46-07:00 New Revision: 12dee9d3cd762d9754e2adadffa13c1cce85cf07 URL: https://github.com/llvm/llvm-project/commit/12dee9d3cd762d9754e2adadffa13c1cce85cf07 DIFF: https://github.com/llvm/llvm-project/commit/12dee9d3cd762d9754e2adadffa13c1cce85cf07.dif

[Lldb-commits] [PATCH] D152757: [lldb][ObjectFileELF] Set ModuleSpec file offset and size

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0b9605a544d: [lldb][ObjectFileELF] Set ModuleSpec file offset and size (authored by splhack). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152757/new/ htt

[Lldb-commits] [lldb] b0b9605 - [lldb][ObjectFileELF] Set ModuleSpec file offset and size

Author: Kazuki Sakamoto Date: 2023-06-20T15:00:09-07:00 New Revision: b0b9605a544dbf26940a48777af401a419f4e4f1 URL: https://github.com/llvm/llvm-project/commit/b0b9605a544dbf26940a48777af401a419f4e4f1 DIFF: https://github.com/llvm/llvm-project/commit/b0b9605a544dbf26940a48777af401a419f4e4f1.dif

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

splhack added a comment. I will submit a diff to deal with how to use the AdbClient in PlatformAndroid later. Most likely we could use only one instance of AdbClient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152855/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Lets get this patch in so we have testing. We can work on caching the AdbClient internally in an ivar of PlatformAndroid in follow up patches. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D152855: [lldb][Android] Add PlatformAndroidTest

clayborg added inline comments. Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroid.cpp:204 // constraints - try "cat ..." as a fallback. - AdbClient adb(m_device_id); + AdbClientUP adb(GetAdbClient(error)); + if (error.Fail()) Do we want the P