[Lldb-commits] [PATCH] D151603: [lldb][NFCI] Refactor Language::GetFormatterPrefixSuffix

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, aprantl, Michael137, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Remove unused parameter `val

[Lldb-commits] [PATCH] D151599: [lldb][NFCI] Remove use of ConstString from StructuredDataDarwinLog static functions

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The strings "DarwinLog" and "log" probably do not n

[Lldb-commits] [PATCH] D151570: Fix Build error on Mac M1 : error: use of undeclared identifier 'getopt_long_only'; did you mean 'getopt_long'?

smurfd added a comment. Hey, yeah that compiles. Im using the standard macos clang ,for Ventura 13.4, xcode 14.3 $ gcc -v Apple clang version 14.0.3 (clang-1403.0.22.14.1) Target: arm64-apple-darwin22.5.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Tool

[Lldb-commits] [PATCH] D151597: [lldb][NFCI] Remove use of ConstString from IOHandler

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. None of these need to be in the ConstString StringP

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

jasonmolenda added a comment. In D151366#4375959 , @antmo wrote: > Hi @mib, > I think this broke lldb-arm-ubuntu bot (LocalVariableWatchpointDisabler.test > failure): https://lab.llvm.org/buildbot/#/builders/17/builds/38136 > Also visible on lldb-aarch64

[Lldb-commits] [lldb] f32d24d - Revert "[lldb] Disable variable watchpoints when going out of scope"

Author: Jason Molenda Date: 2023-05-26T15:32:10-07:00 New Revision: f32d24d57742054cd1131dfa5c21f363139bf59b URL: https://github.com/llvm/llvm-project/commit/f32d24d57742054cd1131dfa5c21f363139bf59b DIFF: https://github.com/llvm/llvm-project/commit/f32d24d57742054cd1131dfa5c21f363139bf59b.diff

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

bulbazord accepted this revision. bulbazord added a comment. Sounds good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D151591: HostInfoMacOS: Add a utility function for finding an SDK-specific tool

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/unittests/Host/HostInfoTest.cpp:90 + EXPECT_FALSE(find_tool("MacOSX.sdk", "clang").empty()); + EXPECT_TRUE(find_tool("MacOSX.sdk", "CeciNe

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

aprantl added a comment. In D151588#4377128 , @bulbazord wrote: > What is the motivation behind this change? > > Also, why did you factor out `--show-sdk-path` into an argument? I assume you > want to use `xcrun` for other purposes? This is in preparati

[Lldb-commits] [PATCH] D151591: HostInfoMacOS: Add a utility function for finding an SDK-specific tool

aprantl created this revision. aprantl added reviewers: bulbazord, JDevlieghere. Herald added a project: All. aprantl requested review of this revision. This is an API needed by swift-lldb. https://reviews.llvm.org/D151591 Files: lldb/include/lldb/Host/HostInfoBase.h lldb/include/lldb/Host/

[Lldb-commits] [PATCH] D151570: Fix Build error on Mac M1 : error: use of undeclared identifier 'getopt_long_only'; did you mean 'getopt_long'?

JDevlieghere added a comment. What host compiler are you using when you see this error? `getopt_long_only` is available on macOS. Does this compile for you? #include int main(int argc, char** argv) { struct option longopts[] = { { "foo", required_argument, 0, 'f' }, };

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

aprantl updated this revision to Diff 526194. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

bulbazord added a comment. What is the motivation behind this change? Also, why did you factor out `--show-sdk-path` into an argument? I assume you want to use `xcrun` for other purposes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151588/new/ https://reviews.llvm.org/D151588 _

[Lldb-commits] [PATCH] D151588: Factor out xcrun (NFC)

aprantl created this revision. aprantl added reviewers: JDevlieghere, bulbazord. Herald added a project: All. aprantl requested review of this revision. https://reviews.llvm.org/D151588 Files: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm Index: lldb/source/Host/macosx/objcxx/HostInfoMacOSX

[Lldb-commits] [lldb] d9c898a - Revert "Factor out xcrun into a function (NFC)"

Author: Adrian Prantl Date: 2023-05-26T13:51:46-07:00 New Revision: d9c898ab60b0b9291b23d66530961fe436a03a8a URL: https://github.com/llvm/llvm-project/commit/d9c898ab60b0b9291b23d66530961fe436a03a8a DIFF: https://github.com/llvm/llvm-project/commit/d9c898ab60b0b9291b23d66530961fe436a03a8a.diff

[Lldb-commits] [lldb] c45a649 - Revert "Make function static (NFC)"

Author: Adrian Prantl Date: 2023-05-26T13:51:46-07:00 New Revision: c45a649a9697ed25834feae946db3b962395a62a URL: https://github.com/llvm/llvm-project/commit/c45a649a9697ed25834feae946db3b962395a62a DIFF: https://github.com/llvm/llvm-project/commit/c45a649a9697ed25834feae946db3b962395a62a.diff

[Lldb-commits] [lldb] cefd280 - Make function static (NFC)

Author: Adrian Prantl Date: 2023-05-26T13:12:12-07:00 New Revision: cefd2802aa49274942da87edf5019b5a23315f01 URL: https://github.com/llvm/llvm-project/commit/cefd2802aa49274942da87edf5019b5a23315f01 DIFF: https://github.com/llvm/llvm-project/commit/cefd2802aa49274942da87edf5019b5a23315f01.diff

[Lldb-commits] [lldb] b22965d - [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests

Author: Daniel Thornburgh Date: 2023-05-26T11:30:33-07:00 New Revision: b22965df1304a752af2724f7c2c3c58347532e71 URL: https://github.com/llvm/llvm-project/commit/b22965df1304a752af2724f7c2c3c58347532e71 DIFF: https://github.com/llvm/llvm-project/commit/b22965df1304a752af2724f7c2c3c58347532e71.d

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb22965df1304: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests (authored by mysterymath). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests

mysterymath updated this revision to Diff 526140. mysterymath added a comment. Apply black formatting to resolve merge conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151269/new/ https://reviews.llvm.org/D151269 Files: lldb/test/Shell/he

[Lldb-commits] [PATCH] D151381: [lldb][NFCI] Include in SBDefines for FILE * definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG877ddac051c4: [lldb][NFCI] Include in SBDefines for FILE * definition (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151381/

[Lldb-commits] [lldb] 877ddac - [lldb][NFCI] Include in SBDefines for FILE * definition

Author: Alex Langford Date: 2023-05-26T10:56:17-07:00 New Revision: 877ddac051c4fc6b32e3e45b02dc628b018b381b URL: https://github.com/llvm/llvm-project/commit/877ddac051c4fc6b32e3e45b02dc628b018b381b DIFF: https://github.com/llvm/llvm-project/commit/877ddac051c4fc6b32e3e45b02dc628b018b381b.diff

[Lldb-commits] [PATCH] D151570: Fix Build error on Mac M1 : error: use of undeclared identifier 'getopt_long_only'; did you mean 'getopt_long'?

smurfd created this revision. smurfd added a reviewer: LLDB. Herald added a subscriber: krytarowski. Herald added a project: All. smurfd requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I got build error on ma m1 `lldb/source/Host/common/Opt

[Lldb-commits] [lldb] a731c5f - [lldb] Remove reproducer test suite (NFC)

Author: Jonas Devlieghere Date: 2023-05-26T09:33:40-07:00 New Revision: a731c5f01d5a7cd6bc150c11498fe46fbd5bab94 URL: https://github.com/llvm/llvm-project/commit/a731c5f01d5a7cd6bc150c11498fe46fbd5bab94 DIFF: https://github.com/llvm/llvm-project/commit/a731c5f01d5a7cd6bc150c11498fe46fbd5bab94.d

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

saugustine abandoned this revision. saugustine added a comment. I'll let someone with a better understanding of the proper implementation take it from here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150805/new/ https://reviews.llvm.org/D150805

[Lldb-commits] [PATCH] D150772: Add code snippet line numbers to TestExprDiagnostics output

JDevlieghere added a comment. I think this test could benefit from switching to string literals (`'''`) and doing a single `self.assertIn` rather than scanning the whole output for every line. Also please use `black` (version 23) to format the test. CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D151269: [lldb] Pass CMAKE_SYSROOT through to LLDB shell tests

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. I suspect you'll run into the same problem when you get the API tests working, but we can deal with that when the time comes. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D150805: Rate limit progress reporting

JDevlieghere added a comment. My suggestion was to add rate limiting support to the listener so that all events could benefit from this. The current patch seems unnecessary ad-hoc: it's limited to (1) progress events and (2) the default event handler. I expects that lldb-vscode plugin users suf

[Lldb-commits] [PATCH] D151516: [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151516/new/ https://reviews.llvm.org/D151516 ___

[Lldb-commits] [PATCH] D151497: [lldb] Improve function caller error message

This revision was automatically updated to reflect the committed changes. Closed by commit rGe31f99464216: [lldb] Improve error message when evaluating expression when not stopped (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D151497

[Lldb-commits] [lldb] e31f994 - [lldb] Improve error message when evaluating expression when not stopped

Author: Jonas Devlieghere Date: 2023-05-26T08:49:58-07:00 New Revision: e31f99464216ef4d04ffa821e174522b699780ee URL: https://github.com/llvm/llvm-project/commit/e31f99464216ef4d04ffa821e174522b699780ee DIFF: https://github.com/llvm/llvm-project/commit/e31f99464216ef4d04ffa821e174522b699780ee.d

[Lldb-commits] [PATCH] D151524: [lldb][NFCI] Change type of SBDebugger::m_instance_name

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151524/new/ https://reviews.llvm.org/D151524 ___

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

wallace accepted this revision. wallace added a comment. This seems reasonable to me and I'm accepting it to unblock this feature. When Greg gets back he should be able to provide some additional comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D151501: [LLDB] Explicitly declare constructor in `PersistentExpressionState`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd01917c507a3: [LLDB] Explicitly declare constructor in `PersistentExpressionState` (authored by Laszlo Kindrat ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] d01917c - [LLDB] Explicitly declare constructor in `PersistentExpressionState`

Author: Laszlo Kindrat Date: 2023-05-26T09:25:44-04:00 New Revision: d01917c507a3b195109001d1b9a91c4fbdbb5a71 URL: https://github.com/llvm/llvm-project/commit/d01917c507a3b195109001d1b9a91c4fbdbb5a71 DIFF: https://github.com/llvm/llvm-project/commit/d01917c507a3b195109001d1b9a91c4fbdbb5a71.diff

[Lldb-commits] [PATCH] D151366: [lldb] Disable variable watchpoints when going out of scope

antmo added a comment. Hi @mib, I think this broke lldb-arm-ubuntu bot (LocalVariableWatchpointDisabler.test failure): https://lab.llvm.org/buildbot/#/builders/17/builds/38136 Also visible on lldb-aarch64-windows here (TestVarPath.py issue is something else): https://lab.llvm.org/buildbot/#/buil

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.