[Lldb-commits] [PATCH] D151002: [lldb] Fix process pid parsing issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGaefa8f4460d1: [lldb] Fix process pid parsing issue (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151002/new/ https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfdd8988621b: [lldb/crashlog] Load inlined symbol into interactive crashlog (authored by mib). Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [lldb] aefa8f4 - [lldb] Fix process pid parsing issue

Author: Med Ismail Bennani Date: 2023-05-19T20:08:18-07:00 New Revision: aefa8f4460d12503d577c085069d632115e22ed4 URL: https://github.com/llvm/llvm-project/commit/aefa8f4460d12503d577c085069d632115e22ed4 DIFF: https://github.com/llvm/llvm-project/commit/aefa8f4460d12503d577c085069d632115e22ed4.

[Lldb-commits] [lldb] dfdd898 - [lldb/crashlog] Load inlined symbol into interactive crashlog

Author: Med Ismail Bennani Date: 2023-05-19T20:08:18-07:00 New Revision: dfdd8988621bcdce0364e0c3ab2d6ba52e875f32 URL: https://github.com/llvm/llvm-project/commit/dfdd8988621bcdce0364e0c3ab2d6ba52e875f32 DIFF: https://github.com/llvm/llvm-project/commit/dfdd8988621bcdce0364e0c3ab2d6ba52e875f32.

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 523980. mib marked 3 inline comments as done. mib added a comment. Address @kastiglione comments and reformat. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files: lldb/examples/python/crashlog.py lldb/

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:703 +symbol = ( +r'(?: +(?:' # spaces and + sign +r'(.+)' # symbol name this is just "spaces", not "spaces and + si

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Ok, looks good to me now. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 ___ lld

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 523961. mib marked 4 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files: lldb/examples/python/crashlog.py lldb/test/Shell/Scrip

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib marked 7 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:628-629 +description = "" +# Since images are parsed after threads, we need to build a +# map for every image with a list of all the s

[Lldb-commits] [PATCH] D151002: [lldb] Fix process pid parsing issue

mib added a comment. In D151002#4357886 , @bulbazord wrote: > You probably encountered this somewhere, is there a simple test we could add > here? The change looks fine to me nonetheless. This is specific to interactive scripted process and the only tes

[Lldb-commits] [PATCH] D151002: [lldb] Fix process pid parsing issue

bulbazord added a comment. You probably encountered this somewhere, is there a simple test we could add here? The change looks fine to me nonetheless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151002/new/ https://reviews.llvm.org/D151002

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

bulbazord added a comment. Looks good! A few minor comments. Comment at: lldb/examples/python/crashlog.py:628-629 +description = "" +# Since images are parsed after threads, we need to build a +# map for every image with a list of all the sym

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. I was doing this API conversion to use std::string_v

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

saugustine updated this revision to Diff 523951. saugustine added a comment. Moved the rate-limiting to Debugger.[cpp|h] Also wrote a custom getCurrentTime function, which doesn't do the much of the extra work the Timer.h version does. With this change, the timing is much better: On my local ma

[Lldb-commits] [PATCH] D151002: [lldb] Fix process pid parsing issue

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix an issue when parsing the process pid and setting it in the scripte

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 523948. mib added a comment. Address feedbacks: - Simplify and Improve regex - Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files: lldb/examples/python/crashlog.py lldb/test/Shell/ScriptInter

[Lldb-commits] [PATCH] D150996: LLVM_FALLTHROUGH => [[fallthrough]]. NFC

craig.topper created this revision. craig.topper added a reviewer: MaskRay. Herald added subscribers: ThomasRaoux, kbarton, hiraditya, nemanjai. Herald added a project: All. craig.topper requested review of this revision. Herald added a reviewer: zuban32. Herald added subscribers: lldb-commits, cfe

[Lldb-commits] [lldb] 3c4f16b - [lldb][NFCI] Consolidate segment names in ObjectFileMachO

Author: Alex Langford Date: 2023-05-19T13:06:40-07:00 New Revision: 3c4f16b6cab2964702d70a4834ea631bed7daaca URL: https://github.com/llvm/llvm-project/commit/3c4f16b6cab2964702d70a4834ea631bed7daaca DIFF: https://github.com/llvm/llvm-project/commit/3c4f16b6cab2964702d70a4834ea631bed7daaca.diff

[Lldb-commits] [lldb] 85cb7fb - Relax test

Author: Adrian Prantl Date: 2023-05-19T10:52:00-07:00 New Revision: 85cb7fbc07e3a974e5c2580e650f61177c941a76 URL: https://github.com/llvm/llvm-project/commit/85cb7fbc07e3a974e5c2580e650f61177c941a76 DIFF: https://github.com/llvm/llvm-project/commit/85cb7fbc07e3a974e5c2580e650f61177c941a76.diff

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

bulbazord accepted this revision. bulbazord added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150954/new/ https://reviews.llvm.org/D150954 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [lldb] aa2c2c8 - Work around a modularization issue in the Python headers.

Author: Adrian Prantl Date: 2023-05-19T10:22:51-07:00 New Revision: aa2c2c8e3c3fe74f2b374b3fdc703ca7b05f80a0 URL: https://github.com/llvm/llvm-project/commit/aa2c2c8e3c3fe74f2b374b3fdc703ca7b05f80a0 DIFF: https://github.com/llvm/llvm-project/commit/aa2c2c8e3c3fe74f2b374b3fdc703ca7b05f80a0.diff

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

Mordante added a comment. In D144509#4356160 , @hans wrote: > In D144509#4350052 , @Mordante > wrote: > >> In D144509#4349921 , @thakis wrote: >> >>> Reverted this and fo

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

Michael137 updated this revision to Diff 523804. Michael137 added a comment. - Move variable into `LLDBStandalone.cmake` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150954/new/ https://reviews.llvm.org/D150954 Files: lldb/cmake/modules/LLDBSta

[Lldb-commits] [PATCH] D150805: Proof of concept for reducing progress-reporting frequency.

JDevlieghere added a comment. In D150805#4351277 , @saugustine wrote: > This update switches to a time-based approach as suggested by Jordan. > However, the timing is about the same as the original. I believe because > calling getCurrentTime every iter

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

JDevlieghere added inline comments. Comment at: lldb/test/CMakeLists.txt:142-143 +set(LLDB_TEST_LIBCXX_ROOT_DIR "${LLVM_BINARY_DIR}" CACHE PATH +"The build root for libcxx. Used in standalone builds to point the API tests to a custom build of libcxx.") + I

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4350052 , @Mordante wrote: > In D144509#4349921 , @thakis wrote: > >> Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 >>

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

Michael137 added a comment. Outstanding question would be whether we want to mirror this change in `utils/lldb-dotest/CMakeLists.txt`. If so, we should probably extract all this libcxx logic into a common helper between the two. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D150954: [lldb][cmake] Allow specifying custom libcxx for tests in standalone builds

Michael137 created this revision. Michael137 added reviewers: aprantl, bulbazord, JDevlieghere. Herald added a subscriber: ekilmer. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Standalone builds cu