[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

bulbazord added a comment. Bug fixes look good to me, the perf and code simplifications are also great to see. A few nits and I have one concern. Otherwise looks fine to me, I think. Comment at: lldb/include/lldb/Target/DynamicLoader.h:270-273 + LoadBinaryWithUUIDAndAddress(P

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice added a comment. In D141907#4355228 , @tstellar wrote: > @paperchalice Do you need someone to commit this for you? Sure, I don't have the commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

tstellar added a comment. @paperchalice Do you need someone to commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141907/new/ https://reviews.llvm.org/D141907 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D150928: Two bug fixes for loading process save-core created core files, plus perf improvements

jasonmolenda created this revision. jasonmolenda added reviewers: jingham, bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I had two bugs wi

[Lldb-commits] [PATCH] D150914: [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName::GetFullNameWithoutCategory

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8d3f061ba41: [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150914/ne

[Lldb-commits] [lldb] e8d3f06 - [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName::GetFullNameWithoutCategory

Author: Alex Langford Date: 2023-05-18T16:23:15-07:00 New Revision: e8d3f061ba415e9f95739e0004fb75552d68df86 URL: https://github.com/llvm/llvm-project/commit/e8d3f061ba415e9f95739e0004fb75552d68df86 DIFF: https://github.com/llvm/llvm-project/commit/e8d3f061ba415e9f95739e0004fb75552d68df86.diff

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + bulbazord wrote: > aprantl wrote

[Lldb-commits] [PATCH] D150914: [lldb][NFCI] Pre-allocate storage in ObjCLanguage::MethodName::GetFullNameWithoutCategory

bulbazord created this revision. bulbazord added a reviewer: aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The size of a full ObjC MethodName can vary somewhat, but it is computable ahead of

[Lldb-commits] [lldb] e5a6950 - [lldb] Remove decl for non-existent ResolveSymbolContextForAddress overload (NFC)

Author: Dave Lee Date: 2023-05-18T15:30:19-07:00 New Revision: e5a695026c78e6bb1abf55a0878066459e1080bc URL: https://github.com/llvm/llvm-project/commit/e5a695026c78e6bb1abf55a0878066459e1080bc DIFF: https://github.com/llvm/llvm-project/commit/e5a695026c78e6bb1abf55a0878066459e1080bc.diff LOG:

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

This revision was automatically updated to reflect the committed changes. Closed by commit rG41714c959d65: [lldb] Guarantee the lifetimes of all strings returned from SBAPI (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150804

[Lldb-commits] [lldb] 41714c9 - [lldb] Guarantee the lifetimes of all strings returned from SBAPI

Author: Alex Langford Date: 2023-05-18T15:13:36-07:00 New Revision: 41714c959d65ff1dd842bc0a0d44f90b06440c39 URL: https://github.com/llvm/llvm-project/commit/41714c959d65ff1dd842bc0a0d44f90b06440c39 DIFF: https://github.com/llvm/llvm-project/commit/41714c959d65ff1dd842bc0a0d44f90b06440c39.diff

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' #

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

bulbazord updated this revision to Diff 523578. bulbazord marked an inline comment as done. bulbazord added a comment. Update SBModule::GetUUIDString -- I slightly changed behavior. Now the behavior matches the previous implementation exactly. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + aprantl wrote: > bulbazord wrote: > > aprantl wrote: > > > Using an llvm str

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

aprantl added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + bulbazord wrote: > aprantl wrote: > > Using an llvm string stream to construct

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

This revision was automatically updated to reflect the committed changes. bulbazord marked an inline comment as done. Closed by commit rG915256388f86: [lldb] Refactor ObjCLanguage::MethodName (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [lldb] 9152563 - [lldb] Refactor ObjCLanguage::MethodName

Author: Alex Langford Date: 2023-05-18T14:47:33-07:00 New Revision: 915256388f865a1a42808f168fc388fccff14eda URL: https://github.com/llvm/llvm-project/commit/915256388f865a1a42808f168fc388fccff14eda DIFF: https://github.com/llvm/llvm-project/commit/915256388f865a1a42808f168fc388fccff14eda.diff

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/API/SBFunction.cpp:181 + + return variable_sp->GetName().GetCString(); } mib wrote: > nit: This threw me off, I thought you forgot to create a `ConsString` but

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelector(); + std::string name_sans_category; + aprantl wrote: > Using an llvm s

[Lldb-commits] [PATCH] D150804: [lldb] Guarantee the lifetimes of all strings returned from SBAPI

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with nit. Comment at: lldb/source/API/SBFunction.cpp:181 + + return variable_sp->GetName().GetCString(); } nit: This threw me off, I thought you forgot to c

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

This revision was automatically updated to reflect the committed changes. Closed by commit rG16eb14806d1e: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150716/n

[Lldb-commits] [lldb] 16eb148 - [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

Author: Alex Langford Date: 2023-05-18T14:26:19-07:00 New Revision: 16eb14806d1ee88d9f0c6222c0d0953a208f7911 URL: https://github.com/llvm/llvm-project/commit/16eb14806d1ee88d9f0c6222c0d0953a208f7911 DIFF: https://github.com/llvm/llvm-project/commit/16eb14806d1ee88d9f0c6222c0d0953a208f7911.diff

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp:56 if (m_idx_offset == UINT32_MAX) { -DWARFAbbreviationDeclarationCollConstIter pos; -DWARFAbbreviationDeclarationCollConstIter end = m_decls.end(); -for (pos = m_d

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

bulbazord updated this revision to Diff 523500. bulbazord marked 2 inline comments as done. bulbazord added a comment. Redo include order in DWARFDebugAbbrev.h to match project guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150716/new/ ht

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

bulbazord marked 2 inline comments as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp:27 lldb::offset_t *offset_ptr) { + llvm::DataExtractor llvm_data = data.GetAsLLVM(); co

[Lldb-commits] [PATCH] D150826: [lldb] Implement GetValueTypeFromAddressType

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe9718dd5f2: [lldb] Implement GetValueTypeFromAddressType (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150826/new/ https://revi

[Lldb-commits] [lldb] 8fe9718 - [lldb] Implement GetValueTypeFromAddressType

Author: Augusto Noronha Date: 2023-05-18T10:29:15-07:00 New Revision: 8fe9718dd5f27168fc282c6420bfae0eb7ee6819 URL: https://github.com/llvm/llvm-project/commit/8fe9718dd5f27168fc282c6420bfae0eb7ee6819 DIFF: https://github.com/llvm/llvm-project/commit/8fe9718dd5f27168fc282c6420bfae0eb7ee6819.dif

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdb814552132d: [lldb] Delay removal of persistent results (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] db81455 - [lldb] Delay removal of persistent results

Author: Dave Lee Date: 2023-05-18T09:44:11-07:00 New Revision: db814552132d614e410118e22b22c89d35ae6062 URL: https://github.com/llvm/llvm-project/commit/db814552132d614e410118e22b22c89d35ae6062 DIFF: https://github.com/llvm/llvm-project/commit/db814552132d614e410118e22b22c89d35ae6062.diff LOG:

[Lldb-commits] [PATCH] D150716: [lldb][NFCI] Switch to using llvm::DWARFAbbreviationDeclaration

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Overall seems good to me. Minor comments inline. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAbbrev.cpp:27 lldb::of

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. One more comment inline but otherwise this is fine with me. Comment at: lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp:155 + llvm::StringRef selector_name = GetSelecto