[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

CaprYang added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:289 + +static bool hasSameElementOfPtrOrVecPtrs(Type *Ty1, Type *Ty2) { + assert(isPtrOrVecOfPtrsType(Ty1) && isPtrOrVecOfPtrsType(Ty2)); CaprYang wrote: > arsenm wrote

[Lldb-commits] [lldb] 617c31c - [LLDB] Fix typo in TestDataFormatterSynthVal.py

Author: Muhammad Omair Javaid Date: 2023-05-16T10:13:06+04:00 New Revision: 617c31c6a1ddd57c6b750b3882c177175067a735 URL: https://github.com/llvm/llvm-project/commit/617c31c6a1ddd57c6b750b3882c177175067a735 DIFF: https://github.com/llvm/llvm-project/commit/617c31c6a1ddd57c6b750b3882c177175067a7

[Lldb-commits] [PATCH] D150639: [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

JDevlieghere added a comment. This patch also uses `__FILE_NAME__` (Clang-specific extension that functions similar to __FILE__ but only renders the last path component (the filename) instead of an invocation dependent full path to that file.) when building with clang. CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D150639: [lldb] Define lldbassert based on NDEBUG instead of LLDB_CONFIGURATION_DEBUG

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, labath, mib. Herald added a project: All. JDevlieghere requested review of this revision. Whether assertions are enabled or not is orthogonal to the build type which could lead to surprising behavior for lldbassert. Previ

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

JDevlieghere added a comment. I have enabled Lua testing on the incremental bot on GreenDragon (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/). This has always been the intention (note how the job mentions "Python 3 and Lua 5.3") but wasn't enabled until earlier today. Repository

[Lldb-commits] [lldb] 9adf60f - [lldb] Fix lldb_assert -> lldbassert in docs

Author: Jonas Devlieghere Date: 2023-05-15T22:18:08-07:00 New Revision: 9adf60fc53fb105e331eec20e7fd2be71ee2a13c URL: https://github.com/llvm/llvm-project/commit/9adf60fc53fb105e331eec20e7fd2be71ee2a13c DIFF: https://github.com/llvm/llvm-project/commit/9adf60fc53fb105e331eec20e7fd2be71ee2a13c.d

[Lldb-commits] [PATCH] D150630: [lldb][docs] Update SB API design document

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, kastiglione. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The documentation should have been updated in 662548

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

jasonmolenda added a comment. Ah, makes sense, will update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150621/new/ https://reviews.llvm.org/D150621 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

bulbazord added a comment. In D150621#4344243 , @JDevlieghere wrote: > You can do this simpler with a single `std::once_flag`. +1 I like the idea of this patch a lot! LGTM otherwise. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 692ae97 - [lldb] Fix lua build after 27b6a4e63afe

Author: Alex Langford Date: 2023-05-15T17:24:00-07:00 New Revision: 692ae97ae71d62ce51d784681a0481fb54343fc1 URL: https://github.com/llvm/llvm-project/commit/692ae97ae71d62ce51d784681a0481fb54343fc1 DIFF: https://github.com/llvm/llvm-project/commit/692ae97ae71d62ce51d784681a0481fb54343fc1.diff

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

This revision was automatically updated to reflect the committed changes. Closed by commit rG692ae97ae71d: [lldb] Fix lua build after 27b6a4e63afe (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150624/new/ https://reviews.llv

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Let's fix the Lua build failures first Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150624/new/ https://reviews.llvm.org/D150624 ___

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

bulbazord requested review of this revision. bulbazord added a comment. So, I agree that we should definitely unify this or else we end up doing this for **every** scripting language that we add support for. That being said, I think this is actually better than what we had before because now we'

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. You can do this simpler with a single `std::once_flag`. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp:710-715 + std::lock_gu

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione added a comment. s/frame pointer/pointer to StackFrame/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione updated this revision to Diff 522384. kastiglione added a comment. check frame pointer before calling GuessLanguage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 Files: lldb/source/Command

[Lldb-commits] [PATCH] D150591: [lldb][DWARFASTParserClang] Don't create unnamed bitfields to account for vtable pointer

Michael137 updated this revision to Diff 522383. Michael137 added a comment. - Rephrase comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150591/new/ https://reviews.llvm.org/D150591 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser

[Lldb-commits] [PATCH] D150590: [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield creation into helper function

Michael137 updated this revision to Diff 522382. Michael137 added a comment. - Add doxygen comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150590/new/ https://reviews.llvm.org/D150590 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTPar

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

mib requested changes to this revision. mib added a comment. This revision now requires changes to proceed. We've already discussed that offline but I really think there should be a ScriptInterpreter `SWIGBridge` plugin and that would have all the method the Python and Lua SWIGBridge have in com

[Lldb-commits] [PATCH] D150157: [lldb] Mark most SBAPI methods involving private types as protected or private

bulbazord added a comment. This broke Lua support, so I am fixing it in D150624 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150157/new/ https://reviews.llvm.org/D150157 ___

[Lldb-commits] [PATCH] D150624: [lldb] Fix lua build after 27b6a4e63afe

bulbazord created this revision. bulbazord added reviewers: kparzysz, JDevlieghere, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This applies the same trick for Lua that I did for python in 27b

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. In D149914#4335858 , @aprantl wrote: > I'm not opposed to using this implementation, but have you considered using > something like the stdlib regex library to do the heavy lifting? I talked to Jonas and did a little research.

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

jingham added a comment. LGTM, Adrian's comment is still outstanding however. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149914/new/ https://reviews.llvm.org/D149914 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

bulbazord added a comment. Some more numbers: % hyperfine -w 3 -- "$lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCName' $App" Benchmark 1: $lldb -x -b -o 'b main' -o 'r' -o 'c' -o 'b $Selector' -o 'b $NonExistentSelector' -o 'b $FullObjCNam

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione added a comment. This change is tested using the original tests from D144044 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 __

[Lldb-commits] [PATCH] D150621: lldb PlatformDarwinKernel, delay local filesystem scan until needed

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. The darwin kernel debuggi

[Lldb-commits] [PATCH] D150129: [lldb] Refine call to decl printing helper (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d4f0e079554: [lldb] Refine call to decl printing helper (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150129/new/ https://

[Lldb-commits] [lldb] 8d4f0e0 - [lldb] Refine call to decl printing helper (NFC)

Author: Dave Lee Date: 2023-05-15T15:20:48-07:00 New Revision: 8d4f0e079554c5eb5c9effda58dbda3b17f03160 URL: https://github.com/llvm/llvm-project/commit/8d4f0e079554c5eb5c9effda58dbda3b17f03160 DIFF: https://github.com/llvm/llvm-project/commit/8d4f0e079554c5eb5c9effda58dbda3b17f03160.diff LOG:

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione updated this revision to Diff 522354. kastiglione added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150619/new/ https://reviews.llvm.org/D150619 Files: lldb/source/Commands/CommandObjectDWIMPrint.cpp lldb/source

[Lldb-commits] [PATCH] D150619: [lldb] Delay removal of persistent results

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up to "Suppress persistent result when running po" (D144044 <

[Lldb-commits] [PATCH] D149379: [lldb] Add tests for command removal

jingham added a comment. In D149379#4331059 , @wallace wrote: > The alias still works because it still holds a reference to it. I could add > that as a test The alias works but the original command is gone? Interesting. We should definitely test that

[Lldb-commits] [PATCH] D149914: [lldb] Refactor ObjCLanguage::MethodName

jingham added a comment. Your test measured setting a found simple breakpoint. That should measure filling all the names caches - we do that the first time you try to set a breakpoint of any sort. But doesn't measure the effects on lookup. I am guessing you will find the same "not much diffe

[Lldb-commits] [lldb] 870eb04 - [lldb] Set CMAKE_CXX_STANDARD before including LLDBStandalone

Author: Jonas Devlieghere Date: 2023-05-15T14:32:15-07:00 New Revision: 870eb04f1005da8278673f3cd1d1a640d16b63e6 URL: https://github.com/llvm/llvm-project/commit/870eb04f1005da8278673f3cd1d1a640d16b63e6 DIFF: https://github.com/llvm/llvm-project/commit/870eb04f1005da8278673f3cd1d1a640d16b63e6.d

[Lldb-commits] [PATCH] D150235: [lldb] Change definition of DisassemblerCreateInstance

This revision was automatically updated to reflect the committed changes. Closed by commit rGf464b7c764bc: [lldb] Change definition of DisassemblerCreateInstance (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150235/new/ http

[Lldb-commits] [lldb] f464b7c - [lldb] Change definition of DisassemblerCreateInstance

Author: Alex Langford Date: 2023-05-15T13:31:26-07:00 New Revision: f464b7c764bcb8f29f28025919800f49405e4e93 URL: https://github.com/llvm/llvm-project/commit/f464b7c764bcb8f29f28025919800f49405e4e93 DIFF: https://github.com/llvm/llvm-project/commit/f464b7c764bcb8f29f28025919800f49405e4e93.diff

[Lldb-commits] [PATCH] D150485: [lldb] Add support for negative integer to {SB, }StructuredData

JDevlieghere added inline comments. Comment at: lldb/include/lldb/API/SBStructuredData.h:70 /// Return the integer value if this data structure is an integer type. - uint64_t GetIntegerValue(uint64_t fail_value = 0) const; + template T GetIntegerValue(T fail_value = {}) con

[Lldb-commits] [lldb] 039b28e - [LLDB] Fix TestDataFormatterSynthVal.py for AArch64/Windows

Author: Muhammad Omair Javaid Date: 2023-05-16T00:14:20+04:00 New Revision: 039b28e14e6d5a4b9b9b333695dabe9dc57233b0 URL: https://github.com/llvm/llvm-project/commit/039b28e14e6d5a4b9b9b333695dabe9dc57233b0 DIFF: https://github.com/llvm/llvm-project/commit/039b28e14e6d5a4b9b9b333695dabe9dc57233

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. Ok, after looking at this more closely, it's a little clearer to me why `SBFileSpec::GetDirectory` was written this way to begin with. The method itself requires its return value to be denormalized (something not explicitly documented in the header nor the SWIG docstr

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord added a comment. > AssertionError: > 'C:\\Users\\tcwg\\llvm-worker\\lldb-aarch64-windows\\build\\lldb-test-build.noindex\\functionalities\\process_save_core\\TestProcessSaveCore.test_save_windows_mini_dump_dwarf\\a.out' > not found in > ['C:/Users/tcwg/llvm-worker/lldb-aarch64-windows

[Lldb-commits] [PATCH] D150366: [lldb][NFCI] Use llvm's libDebugInfo for DebugRanges

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150366/new/ https://reviews.llvm.org/D150366 ___

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG58e6caaba1cf: Revert "[lldb] Refactor SBFileSpec::GetDirectory" (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D149625?vs=518782&id=522285#toc Repository: rG LLVM Github Mo

[Lldb-commits] [lldb] 58e6caa - Revert "[lldb] Refactor SBFileSpec::GetDirectory"

Author: Muhammad Omair Javaid Date: 2023-05-15T22:49:00+04:00 New Revision: 58e6caaba1cf623292c8898be30a5a56722432b3 URL: https://github.com/llvm/llvm-project/commit/58e6caaba1cf623292c8898be30a5a56722432b3 DIFF: https://github.com/llvm/llvm-project/commit/58e6caaba1cf623292c8898be30a5a56722432

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This introduced test failures on windows lldb-aarch64-windows buildbot. lldb-api :: functionalities/process_save_core/TestProcessSaveCore.py lldb-api :: python_api/symbol-context/TestSy

[Lldb-commits] [PATCH] D150590: [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield creation into helper function

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h:239 + bool ShouldCreateUnnamedBitfield( + FieldInfo const &last_field_info, uint64_t last

[Lldb-commits] [PATCH] D150591: [lldb][DWARFASTParserClang] Don't create unnamed bitfields to account for vtable pointer

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** When filling out the LayoutInfo fo

[Lldb-commits] [PATCH] D150590: [lldb][DWARFASTParserClang][NFC] Extract condition for unnamed bitfield creation into helper function

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new private helper `DWARFASTP

[Lldb-commits] [PATCH] D150589: [lldb][DWARFASTParserClang][NFC] Simplify unnamed bitfield condition

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a reviewer: shafik. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Minor cleanup of redundant variable initializat

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

Michael137 added a comment. In D149949#4341608 , @labath wrote: > Just as a drive-by, since we're constructing a copy anyway it would be > possible to merge this construction with the "uniqueing" behavior of the > `visited` set. I.e., instead of making

[Lldb-commits] [PATCH] D149949: [lldb][TypeSystem] ForEach: Don't hold the TypeSystemMap lock across callback

labath added a comment. Just as a drive-by, since we're constructing a copy anyway it would be possible to merge this construction with the "uniqueing" behavior of the `visited` set. I.e., instead of making a literal copy of the map, just construct a `to_be_visited` set of /unique/ objects, and