[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace updated this revision to Diff 519338. wallace added a comment. add the language as a vendor extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/ https://reviews.llvm.org/D149702 Files: lldb/docs/python_api_enums.rst lldb

[Lldb-commits] [PATCH] D149803: Use the `addressing_bits` kv in the stop packet from the remote stub, if present

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Makes sense to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149803/new/ https://reviews.llvm.org/D149803 ___

[Lldb-commits] [PATCH] D149804: [lldb][NFCI] Add unittests for ObjCLanguage::MethodName

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, Michael137, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I have a patch to refactor this class and I'd like a

[Lldb-commits] [PATCH] D149803: Use the `addressing_bits` kv in the stop packet from the remote stub, if present

jasonmolenda created this revision. jasonmolenda added a reviewer: bulbazord. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. On an AArch

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

delcypher added inline comments. Comment at: lldb/examples/python/scripted_step.py:130 +def stop_description(self, stream): +stream.Print("Simple step completed") @jingham Thanks for implementing this. Is there a reason why the interface needs to a

[Lldb-commits] [PATCH] D149792: Add AArch64 MASK watchpoint support to debugserver

delcypher added inline comments. Comment at: lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py:132 value.GetType().GetPointeeType()) -# Watch for write to *g_char_ptr. -error = lldb.SBError() @jasonmolenda M

[Lldb-commits] [PATCH] D149792: Add AArch64 MASK watchpoint support to debugserver

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added subscribers: omjavaid, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. AArch64 supp

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 519255. nickdesaulniers added a comment. - update llvm-rust-demangle-fuzzer.cpp call site Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files: lldb/includ

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

MaskRay accepted this revision. MaskRay added a subscriber: labath. MaskRay added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Utility/ConstString.h:186 operator llvm::StringRef() const { return GetStringRef(); } + // Implici

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 519248. nickdesaulniers added a comment. - remove GetStringRef call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files: lldb/include/lldb/Utility/ConstSt

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: lldb/source/Core/Mangled.cpp:263 case eManglingSchemeRustV0: -demangled_name = GetRustV0DemangledStr(mangled_name); +demangled_name = GetRustV0DemangledStr(m_mangled.GetStringRef()); break; ---

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers created this revision. Herald added subscribers: JDevlieghere, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. I was doing this API conversion to use

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

wallace added a comment. In D149702#4316747 , @aprantl wrote: > You can also use a constant in the Vendor extension space, which might be > more appropriate until the languages sees adoption by a wider audience. That sounds like a better idea. Thanks! I

[Lldb-commits] [PATCH] D149702: [DebugInfo] Add language code for the new Mojo language

aprantl added a comment. You can also use a constant in the Vendor extension space, which might be more appropriate until the languages sees adoption by a wider audience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149702/new/ https://reviews.ll

[Lldb-commits] [PATCH] D148776: [Modules] Move modulemaps to header search directories. NFC intended.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24f36a215b4e: [Modules] Move modulemaps to header search directories. NFC intended. (authored by vsapsai). Changed prior to commit: https://review

[Lldb-commits] [lldb] 24f36a2 - [Modules] Move modulemaps to header search directories. NFC intended.

Author: Volodymyr Sapsai Date: 2023-05-03T13:07:47-07:00 New Revision: 24f36a215b4eabd1d0e4abcce0c9277085d88a96 URL: https://github.com/llvm/llvm-project/commit/24f36a215b4eabd1d0e4abcce0c9277085d88a96 DIFF: https://github.com/llvm/llvm-project/commit/24f36a215b4eabd1d0e4abcce0c9277085d88a96.di

[Lldb-commits] [PATCH] D149774: [lldb] Use templates to simplify {Get, Set}PropertyAtIndex (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I quite like the idea. Probably want to wait for others to look over it but I think it's good! Comment at: lldb/source/Core/Debugger.cpp:394 const uint32_t idx = eP

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

jingham added a comment. Committed as: c2be702104284cb3facf31124494b9a400296179 . I forgot to put the differential revision cookie in the commit message... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[Lldb-commits] [lldb] c2be702 - Allow scripted thread plans to modify the thread stop description when

Author: Jim Ingham Date: 2023-05-03T10:52:12-07:00 New Revision: c2be702104284cb3facf31124494b9a400296179 URL: https://github.com/llvm/llvm-project/commit/c2be702104284cb3facf31124494b9a400296179 DIFF: https://github.com/llvm/llvm-project/commit/c2be702104284cb3facf31124494b9a400296179.diff LO

[Lldb-commits] [PATCH] D149774: [lldb] Use templates to simplify {Get, Set}PropertyAtIndex (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: labath, bulbazord, jingham. Herald added a subscriber: arphaman. Herald added a project: All. JDevlieghere requested review of this revision. Use templates to simplify `{Get,Set}PropertyAtIndex`. It has always bothered me how cumbe

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace updated this revision to Diff 519163. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149719/new/ https://reviews.llvm.org/D149719 Files: lldb/include/lldb/Expression/REPL.h lldb/source/Expressio

[Lldb-commits] [PATCH] D149697: [lldb] Remove distribution_id from ArchSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd05ffdbb2c3: [lldb] Remove distribution_id from ArchSpec (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149697/new/ https://reviews

[Lldb-commits] [lldb] cd05ffd - [lldb] Remove distribution_id from ArchSpec

Author: Alex Langford Date: 2023-05-03T10:30:42-07:00 New Revision: cd05ffdbb2c303cbf476a3a48b3f67094d428e37 URL: https://github.com/llvm/llvm-project/commit/cd05ffdbb2c303cbf476a3a48b3f67094d428e37 DIFF: https://github.com/llvm/llvm-project/commit/cd05ffdbb2c303cbf476a3a48b3f67094d428e37.diff

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace updated this revision to Diff 519141. wallace added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149717/new/ https://reviews.llvm.org/D149717 Files: lldb/include/lldb/Core/Debugger.h Index: lldb/include/lldb

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

wallace added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:503-504 + /// Manually start the global event handler thread. It should be used by + /// programs that use LLDB as a library. + bool StartEventHandlerThread(); bulbazord wrote: > Th

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

wallace added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:115-120 + virtual void + OnExpressionEvaluated(const ExecutionContext &exe_ctx, llvm::StringRef code, +const EvaluateExpressionOptions &expr_options, +

[Lldb-commits] [PATCH] D149719: [LLDB] Add a hook to notify REPLs that an expression was evaluated

bulbazord added inline comments. Comment at: lldb/include/lldb/Expression/REPL.h:115-120 + virtual void + OnExpressionEvaluated(const ExecutionContext &exe_ctx, llvm::StringRef code, +const EvaluateExpressionOptions &expr_options, +

[Lldb-commits] [PATCH] D149717: [lldb] Make some functions useful to REPLs public

bulbazord added a reviewer: JDevlieghere. bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:503-504 + /// Manually start the global event handler thread. It should be used by + /// programs that use LLDB as a library. + bool StartEventHandlerThre

[Lldb-commits] [PATCH] D149697: [lldb] Remove distribution_id from ArchSpec

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. FWIW, I'd be very much in favour of removing distribution_id support altogether. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149697/new/ https