[Lldb-commits] [PATCH] D149567: [lldb] Group debugger properties (NFC)

JDevlieghere updated this revision to Diff 518385. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. Use one big Doxygen group for all the properties to make this less noisy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149567/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D149567: [lldb] Group debugger properties (NFC)

JDevlieghere added a comment. In D149567#4309195 , @mib wrote: > nit: Sometimes we have newlines between methods and sometimes we don't ... It > would be nice to be consistent, otherwise LGTM Methods relating to the same property are grouped together (i

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149565/new/ https://reviews.llvm.org/D149565 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D149567: [lldb] Group debugger properties (NFC)

mib added a comment. nit: Sometimes we have newlines between methods and sometimes we don't ... It would be nice to be consistent, otherwise LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149567/new/ https://reviews.llvm.org/D149567 ___

[Lldb-commits] [PATCH] D149567: [lldb] Group debugger properties (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: mib, bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. Group debugger properties in Doxygen groups. https://reviews.llvm.org/D149567 Files: lldb/include/lldb/Core/Debugger.h Index: lldb/in

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:298 + llvm::StringRef GetExternalEditor() const; + bool SetExternalEditor(llvm::StringRef editor); mib wrote: > newline This was i

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

mib added inline comments. Comment at: lldb/include/lldb/Core/Debugger.h:298 + llvm::StringRef GetExternalEditor() const; + bool SetExternalEditor(llvm::StringRef editor); newline Comment at: lldb/source/Host/macosx/objcxx/Host.mm:395-396

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, mib, jingham. Herald added a project: All. JDevlieghere requested review of this revision. Add a setting (`debugger.external-editor`) to specify an external editor instead of having to rely on the `LLDB_EXTERNAL_EDITOR`

[Lldb-commits] [PATCH] D149397: Host: generalise `GetXcodeSDKPath`

dyung added a comment. I’m also seeing this fail on 2 buildbots: https://lab.llvm.org/buildbot/#/builders/217/builds/20568 https://lab.llvm.org/buildbot/#/builders/243/builds/5576 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149397/new/ https://r