[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

bulbazord updated this revision to Diff 511954. bulbazord added a comment. Change return type to llvm::StringRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147833/new/ https://reviews.llvm.org/D147833 Files: lldb/include/lldb/Breakpoint/Break

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

JDevlieghere added a comment. In D147833#4253499 , @bulbazord wrote: > Yes, we definitely do that in many places. I see your point though, comparing > const c-string pointers can get pretty tricky if somebody refactors this in > the future. In that case

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

jasonmolenda added a comment. In D147833#4253499 , @bulbazord wrote: > > Yes, we definitely do that in many places. I see your point though, comparing > const c-string pointers can get pretty tricky if somebody refactors this in > the future. In tha

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

bulbazord added a comment. In D147833#4253416 , @jasonmolenda wrote: > idk maybe I'm over-thinking it, but this does make me a little uncomfortable. > We have at least one instance where someone did > `platform_sp->GetPluginName() == "ios-simulator"`

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

jasonmolenda added a comment. In D147833#4253416 , @jasonmolenda wrote: > idk maybe I'm over-thinking it, but this does make me a little uncomfortable. > We have at least one instance where someone did > `platform_sp->GetPluginName() == "ios-simulator

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

jasonmolenda added a comment. idk maybe I'm over-thinking it, but this does make me a little uncomfortable. We have at least one instance where someone did `platform_sp->GetPluginName() == "ios-simulator"` in ClangExpressionSourceCode.cpp (probably to avoid a dependency on an an apple platform