[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

JDevlieghere added inline comments. Comment at: lldb/source/Target/StackFrameList.cpp:823 +SelectMostRelevantFrame(); +m_selected_frame_set = true; + } jingham wrote: > JDevlieghere wrote: > > IIUC `SetSelectedFrame` always sets `m_selected_frame_set`

[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

jingham added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:139-144 /// The currently selected frame. uint32_t m_selected_frame_idx; + // Records whether anyone has set the selected frame on this stack yet. + // We only let recognizers change the

[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:139-144 /// The currently selected frame. uint32_t m_selected_frame_idx; + // Records whether anyone has set the selected frame on this stack yet. + // We only let recognizers change

[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

jingham created this revision. jingham added reviewers: JDevlieghere, mib. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. SelectMostRelevantFrame triggers the StackFrameRecognizer construction, which c

[Lldb-commits] [PATCH] D145832: [lldb][test] Add tests for clang::PreferredNameAttr formatting

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9ca707b69ba3: [lldb][test] Add tests for clang::PreferredNameAttr formatting (authored by Michael137). Repository: rG L

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG711a64412749: [clang][DebugInfo] Emit DW_AT_type of preferred name if available (authored by Michael137). Repository: r

[Lldb-commits] [lldb] 9ca707b - [lldb][test] Add tests for clang::PreferredNameAttr formatting

Author: Michael Buch Date: 2023-04-07T01:37:36+01:00 New Revision: 9ca707b69ba3802d0e31aa41c83f027027526d83 URL: https://github.com/llvm/llvm-project/commit/9ca707b69ba3802d0e31aa41c83f027027526d83 DIFF: https://github.com/llvm/llvm-project/commit/9ca707b69ba3802d0e31aa41c83f027027526d83.diff

[Lldb-commits] [lldb] 711a644 - [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Author: Michael Buch Date: 2023-04-07T01:37:36+01:00 New Revision: 711a64412749ae73709562b591ab1609a3ee7751 URL: https://github.com/llvm/llvm-project/commit/711a64412749ae73709562b591ab1609a3ee7751 DIFF: https://github.com/llvm/llvm-project/commit/711a64412749ae73709562b591ab1609a3ee7751.diff

[Lldb-commits] [PATCH] D147746: [lldb][NFC] Delete unused function Breakpoint::GetEventIdentifier

This revision was automatically updated to reflect the committed changes. Closed by commit rGb04bc87c9edc: [lldb][NFC] Delete unused function Breakpoint::GetEventIdentifier (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147746

[Lldb-commits] [lldb] b04bc87 - [lldb][NFC] Delete unused function Breakpoint::GetEventIdentifier

Author: Alex Langford Date: 2023-04-06T17:14:09-07:00 New Revision: b04bc87c9edca0e93330948b88292ebcde891ce2 URL: https://github.com/llvm/llvm-project/commit/b04bc87c9edca0e93330948b88292ebcde891ce2 DIFF: https://github.com/llvm/llvm-project/commit/b04bc87c9edca0e93330948b88292ebcde891ce2.diff

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implement SymbolFile::ContainsCompileOption, which returns true if the string

[Lldb-commits] [PATCH] D147292: [lldb] Add support for the DW_AT_trampoline attribute with a boolean

augusto2112 updated this revision to Diff 511549. augusto2112 marked 3 inline comments as done. augusto2112 added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147292/new/ https://reviews.llvm.org/D147292 Files: lld

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

sgraenitz requested changes to this revision. sgraenitz added a comment. This revision now requires changes to proceed. First of all, yes the existing code is incorrect. Thanks for looking into this. However, I am afraid this isn't the right solution. In the `if` body you can not `std::move()` f

[Lldb-commits] [PATCH] D147746: [lldb][NFC] Delete unused function Breakpoint::GetEventIdentifier

bulbazord created this revision. bulbazord added reviewers: mib, JDevlieghere, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is unused Repository: rG LLVM Github Monorepo https://r

[Lldb-commits] [PATCH] D147736: [lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED

This revision was automatically updated to reflect the committed changes. Closed by commit rG2279f77d2855: [lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D147736?vs=511516

[Lldb-commits] [lldb] 2279f77 - [lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED

Author: Jonas Devlieghere Date: 2023-04-06T14:56:34-07:00 New Revision: 2279f77d2855d9caa0ece466462d34bcfdf4fb3d URL: https://github.com/llvm/llvm-project/commit/2279f77d2855d9caa0ece466462d34bcfdf4fb3d DIFF: https://github.com/llvm/llvm-project/commit/2279f77d2855d9caa0ece466462d34bcfdf4fb3d.d

[Lldb-commits] [PATCH] D147736: [lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED

bulbazord accepted this revision. bulbazord added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/API/SBDefines.h:33 +// supports the attribute. +#if defined(SWIG) or _cplusplus < 201300 +#undef LLDB_DEPRECATED nit:

[Lldb-commits] [lldb] a58eefa - [lldb] Rename test module.map files to module.modulemap (NFC)

Author: Dave Lee Date: 2023-04-06T14:00:21-07:00 New Revision: a58eefa115588d6385ac40d05eb677267f48fc89 URL: https://github.com/llvm/llvm-project/commit/a58eefa115588d6385ac40d05eb677267f48fc89 DIFF: https://github.com/llvm/llvm-project/commit/a58eefa115588d6385ac40d05eb677267f48fc89.diff LOG:

[Lldb-commits] [PATCH] D147736: [lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED

JDevlieghere updated this revision to Diff 511516. JDevlieghere added a comment. Add a comment explaining why we're undefing the macro. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147736/new/ https://reviews.llvm.org/D147736 Files: lldb/include/lldb/API/SBDefines.h lldb/include/l

[Lldb-commits] [PATCH] D147736: [lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED

JDevlieghere added a comment. FWIW I added the current `[[deprecated]]` attribute in ea95da180900 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147736/new/ https://reviews.llvm.org/D147736 _

[Lldb-commits] [PATCH] D147736: [lldb] Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED

JDevlieghere created this revision. JDevlieghere added reviewers: labath, DavidSpickett, jingham, bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. Add an LLDB_DEPRECATED macro similar to LLVM_DEPRECATED. We cannot directly reuse the LLVM one, because it's def

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd added a comment. In D146965#4240075 , @DavidSpickett wrote: > Two things come to mind: > > - Core files (though it is embedded so is that even a thing?) Looked into core dumping in LLDB a bit, I think it pretty much requires that there is an OS,

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 511497. kuilpd added a comment. Added a test for registers, breakpoints, stepping, backtracing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/include/l

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

bulbazord added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:869-873 LLDB_LOG(log, "ObjectFilePECOFF::AppendFromExportTable - failed to get export " "table entry name: {0}", llvm::f

[Lldb-commits] [PATCH] D147482: [lldb] Add an overload to SetModuleLoadAddress that takes an unsigned value

This revision was automatically updated to reflect the committed changes. Closed by commit rGea95da180900: [lldb] Add an overload to SetModuleLoadAddress that takes an unsigned value (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D147

[Lldb-commits] [lldb] ea95da1 - [lldb] Add an overload to SetModuleLoadAddress that takes an unsigned value

Author: Jonas Devlieghere Date: 2023-04-06T10:43:54-07:00 New Revision: ea95da1809008abd9b81b0fb2cc6ec6438c4c0e0 URL: https://github.com/llvm/llvm-project/commit/ea95da1809008abd9b81b0fb2cc6ec6438c4c0e0 DIFF: https://github.com/llvm/llvm-project/commit/ea95da1809008abd9b81b0fb2cc6ec6438c4c0e0.d

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

compnerd added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:869-873 LLDB_LOG(log, "ObjectFilePECOFF::AppendFromExportTable - failed to get export " "table entry name: {0}", llvm::fm

[Lldb-commits] [PATCH] D147606: [lldb] fix #61942, discard "empty" ranges in DWARF to better handle gcc binary

JDevlieghere added a comment. In D147606#4247462 , @jwnhy wrote: > In D147606#4246832 , @JDevlieghere > wrote: > >> The change looks fine and regardless of whether this makes sense or even >> complies with the s

[Lldb-commits] [PATCH] D147482: [lldb] Add an overload to SetModuleLoadAddress that takes an unsigned value

JDevlieghere added a comment. Writing this made me realize we can solve this more elegantly. We can have both overloads and deprecate the one that takes an `int64_t`, mark it as deprecated and not expose it to SWIG. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147482/new/ https://rev

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added a comment. FYI, this bugfix was attempted back in 2021 here: https://reviews.llvm.org/D101237 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/test/API/types/TestEmptyBase.py:25-42 +def test(self): +"""Test that recursive structs are displayed correctly.""" +self.build(dictionary=self.sources) +self.setTearDownCleanup(dictionary=self.sources)

[Lldb-commits] [PATCH] D147482: [lldb] Add an overload to SetModuleLoadAddress that takes an unsigned value

JDevlieghere added a comment. In D147482#4248858 , @jasonmolenda wrote: > LGTM. We can detect this This is one of those cases where I'd like to mark > SBTarget::SetModuleLoadAddress as deprecated. I like that you detect this > situation in SBTarget:

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { + clang::CXXReco

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1481 +// To fix this we scan base classes in reverse order to determine +// overlapping offsets. Wnen found we consider such class as empty +// base with all fie

[Lldb-commits] [PATCH] D147482: [lldb] Add an overload to SetModuleLoadAddress that takes an unsigned value

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM. We can detect this This is one of those cases where I'd like to mark SBTarget::SetModuleLoadAddress as deprecated. I like that you detect this situation in SBTarget::SetLo

[Lldb-commits] [PATCH] D147642: [lldb][ObjectFileELF] Support AArch32 in ApplyRelocations

peter.smith added a comment. From the Arm side this looks good. Strictly speaking R_ARM_ABS32 doesn't require overflow checking, but in this context adding it makes sense. It is definitely the case that addends are signed in Arm, I guess there may be a 32-bit ABI that has unsigned REL addends,

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 511362. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserC

[Lldb-commits] [PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 added a comment. I'll submit later today then if nobody has any other objections Will add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 ___

[Lldb-commits] [PATCH] D147627: [lldb][ObjectFileELF] Improve error output for unsupported arch/relocations

DavidSpickett added a comment. Agreed. The tangled web of switch statements makes my head spin so if you ever feel like tackling that please do :) Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:2704 +default: + assert(false && "unexpected re