[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging (NFC)

mib added a comment. This depends on D145294 , D145295 & D145296 so make sure you take a look at those diffs :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D145297: [lldb] Add an example of interactive scripted process debugging (NFC)

mib created this revision. mib added reviewers: labath, JDevlieghere, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch is a proof of concept that shows how a scripted process could be used wi

[Lldb-commits] [PATCH] D145296: [lldb/Plugin] Add breakpoint setting support to ScriptedProcesses.

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds support for breakpoint setting to Scripted Processes. For now, Scripted Pr

[Lldb-commits] [PATCH] D145295: [lldb] Move ScriptedProcess private state update to implementation

mib created this revision. mib added reviewers: JDevlieghere, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. While debugging a Scripted Process, in order to update its state and work nicely with lld

[Lldb-commits] [PATCH] D145294: [lldb/API] Introduce SBProcess::ForceScriptedState method

mib created this revision. mib added reviewers: bulbazord, JDevlieghere, jingham. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new method to the SBProcess API called ForceScriptedStat

[Lldb-commits] [lldb] c0b4ca1 - [lldb] Simplify error string in ScriptedInterface (NFC)

Author: Med Ismail Bennani Date: 2023-03-03T20:18:28-08:00 New Revision: c0b4ca107a3b605f810bd60642907e6a77f7c6d3 URL: https://github.com/llvm/llvm-project/commit/c0b4ca107a3b605f810bd60642907e6a77f7c6d3 DIFF: https://github.com/llvm/llvm-project/commit/c0b4ca107a3b605f810bd60642907e6a77f7c6d3.

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

mib closed this revision. mib added a comment. Landed in e6cac17b563f CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144224/new/ https://reviews.llvm.org/D144224 ___ lldb-c

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

mib closed this revision. mib added a comment. Landed in f190ec688270 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144237/new/ https://reviews.llvm.org/D144237 ___ lldb-c

[Lldb-commits] [PATCH] D145260: [lldb/swig] Fix ref counting issue in SBProcess::GetScriptedImplementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGebdbc26a3e79: [lldb/swig] Fix ref counting issue in SBProcess::GetScriptedImplementation (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb9d4c94a603d: [lldb/Plugins] Add Attach capabilities to ScriptedProcess (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to {, platform }process commands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3014a1c5a130: [lldb] Add scripted process launch/attach option to {,platform }process commands (authored by mib). Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] ebdbc26 - [lldb/swig] Fix ref counting issue in SBProcess::GetScriptedImplementation

Author: Med Ismail Bennani Date: 2023-03-03T19:33:02-08:00 New Revision: ebdbc26a3e79e64e9b2786a8b413618a5b5c115d URL: https://github.com/llvm/llvm-project/commit/ebdbc26a3e79e64e9b2786a8b413618a5b5c115d DIFF: https://github.com/llvm/llvm-project/commit/ebdbc26a3e79e64e9b2786a8b413618a5b5c115d.

[Lldb-commits] [lldb] efc5236 - [lldb] Improve error reporting in ScriptedInterface

Author: Med Ismail Bennani Date: 2023-03-03T19:33:02-08:00 New Revision: efc52361ddb7282825f1f813553f322bd119b830 URL: https://github.com/llvm/llvm-project/commit/efc52361ddb7282825f1f813553f322bd119b830 DIFF: https://github.com/llvm/llvm-project/commit/efc52361ddb7282825f1f813553f322bd119b830.

[Lldb-commits] [lldb] f190ec6 - [lldb/Plugins] Add memory writing capabilities to Scripted Process

Author: Med Ismail Bennani Date: 2023-03-03T19:33:02-08:00 New Revision: f190ec6882706d30c606e62986512371925288a9 URL: https://github.com/llvm/llvm-project/commit/f190ec6882706d30c606e62986512371925288a9 DIFF: https://github.com/llvm/llvm-project/commit/f190ec6882706d30c606e62986512371925288a9.

[Lldb-commits] [lldb] b9d4c94 - [lldb/Plugins] Add Attach capabilities to ScriptedProcess

Author: Med Ismail Bennani Date: 2023-03-03T19:33:02-08:00 New Revision: b9d4c94a603d3cc1f44ab7dd1d4f3ae9c80da98b URL: https://github.com/llvm/llvm-project/commit/b9d4c94a603d3cc1f44ab7dd1d4f3ae9c80da98b DIFF: https://github.com/llvm/llvm-project/commit/b9d4c94a603d3cc1f44ab7dd1d4f3ae9c80da98b.

[Lldb-commits] [PATCH] D142059: [lldb/Plugins] Add ScriptedProcess::GetCapabilities affordance (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d5348be2561: [lldb/Plugins] Add ScriptedProcess::GetCapabilities affordance (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142059/ne

[Lldb-commits] [lldb] e02a355 - [lldb/Plugins] Clean-up Scripted Process interface requirements (NFC)

Author: Med Ismail Bennani Date: 2023-03-03T19:33:02-08:00 New Revision: e02a355f9846d5ec9cd64b086674770ecc795c26 URL: https://github.com/llvm/llvm-project/commit/e02a355f9846d5ec9cd64b086674770ecc795c26 DIFF: https://github.com/llvm/llvm-project/commit/e02a355f9846d5ec9cd64b086674770ecc795c26.

[Lldb-commits] [lldb] e6cac17 - [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

Author: Med Ismail Bennani Date: 2023-03-03T19:33:01-08:00 New Revision: e6cac17b563f2e2bc7d04347b0b40a9fe12334c9 URL: https://github.com/llvm/llvm-project/commit/e6cac17b563f2e2bc7d04347b0b40a9fe12334c9 DIFF: https://github.com/llvm/llvm-project/commit/e6cac17b563f2e2bc7d04347b0b40a9fe12334c9.

[Lldb-commits] [lldb] 3014a1c - [lldb] Add scripted process launch/attach option to {, platform }process commands

Author: Med Ismail Bennani Date: 2023-03-03T19:33:02-08:00 New Revision: 3014a1c5a130daeb73f6d3b7280c5ceaeadc66a8 URL: https://github.com/llvm/llvm-project/commit/3014a1c5a130daeb73f6d3b7280c5ceaeadc66a8 DIFF: https://github.com/llvm/llvm-project/commit/3014a1c5a130daeb73f6d3b7280c5ceaeadc66a8.

[Lldb-commits] [lldb] 2d5348b - [lldb/Plugins] Add ScriptedProcess::GetCapabilities affordance (NFC)

Author: Med Ismail Bennani Date: 2023-03-03T19:33:02-08:00 New Revision: 2d5348be2561402e284e26a9adf3a2e28e70c1f5 URL: https://github.com/llvm/llvm-project/commit/2d5348be2561402e284e26a9adf3a2e28e70c1f5 DIFF: https://github.com/llvm/llvm-project/commit/2d5348be2561402e284e26a9adf3a2e28e70c1f5.

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for adding those tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144224/new/ https://reviews.llvm.org/D144224 ___ lldb-c

[Lldb-commits] [PATCH] D144224: [lldb] Extend SWIG SBProcess interface with WriteMemoryAsCString method

mib updated this revision to Diff 502332. mib added a comment. Handle empty string case and add tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144224/new/ https://reviews.llvm.org/D144224 Files: lldb/bindings/interface/SBProcessExtensions.i lldb/test/API/python_api/process/Tes

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere updated this revision to Diff 502330. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Address Greg's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145180/new/ https://reviews.llvm.org/D145180 Files: lldb/include/lldb/Symbol/Symbol.h

[Lldb-commits] [PATCH] D144237: [lldb/Plugins] Add memory writing capabilities to Scripted Process

mib updated this revision to Diff 502319. mib added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144237/new/ https://reviews.llvm.org/D144237 Files: lldb/bindings/python/python-swigsafecast.swig lldb/examples/python/scripted_process/scripted_process.py lldb/inc

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143104/new/ https://reviews.llvm.org/D143104 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to {, platform }process commands

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM modulo inline comments. Comment at: lldb/include/lldb/Target/Process.h:235-239 + std::string m_scripted_process_class_name; // The name of the class that wi

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib updated this revision to Diff 502270. mib added a comment. - Address last feedbacks - Fix unittest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143104/new/ https://reviews.llvm.org/D143104 Files: lldb/bindings/python/python-swigsafecast.swig lldb/bindings/python/python-wrapper

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

bulbazord added a comment. I still think it's a little weird that you can create LaunchInfo or AttachInfo, call SetScriptedProcessDictionary, and still have the ScriptedMetadata be "invalid", but I suppose it makes no sense if there is no class name anyway. Just a few small things. Everything e

[Lldb-commits] [PATCH] D143104: [lldb/Plugins] Add Attach capabilities to ScriptedProcess

mib updated this revision to Diff 502265. mib edited the summary of this revision. mib added a comment. - Address @bulbazord comment about only being able to assign the Scripted Metadata attributes once. - Add necessary SWIG wrappers to convert the internal type into SB counterpart and back. C

[Lldb-commits] [PATCH] D139945: [lldb] Add scripted process launch/attach option to platform commands

mib updated this revision to Diff 502259. mib added a comment. Fix build failures after rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139945/new/ https://reviews.llvm.org/D139945 Files: lldb/include/lldb/API/SBAttachInfo.h lldb/include/lldb/API/SBStructuredData.h lldb/incl

[Lldb-commits] [lldb] 96e39fd - [lldb][test] NativePDB/ast-types: fix expected pointer format

Author: Michael Buch Date: 2023-03-03T21:41:18Z New Revision: 96e39fdbb90b26191fc79b6226f299e3c10e559b URL: https://github.com/llvm/llvm-project/commit/96e39fdbb90b26191fc79b6226f299e3c10e559b DIFF: https://github.com/llvm/llvm-project/commit/96e39fdbb90b26191fc79b6226f299e3c10e559b.diff LOG:

[Lldb-commits] [PATCH] D145260: [lldb/swig] Fix ref counting issue in SBProcess::GetScriptedImplementation

mib updated this revision to Diff 50. mib added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145260/new/ https://reviews.llvm.org/D145260 Files: lldb/bindings/python/python-typemaps.swig lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py

[Lldb-commits] [PATCH] D145260: [lldb/swig] Fix ref counting issue in SBProcess::GetScriptedImplementation

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Can we turn that crash into a small test case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145260/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D145260: [lldb/swig] Fix ref counting issue in SBProcess::GetScriptedImplementation

mib created this revision. mib added reviewers: bulbazord, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. When using SBProcess::GetScriptedImplementation in python, if the process has a valid imp

[Lldb-commits] [PATCH] D145241: [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex

Michael137 added a comment. Looks like this is causing windows tests to fail: https://lab.llvm.org/buildbot#builders/219/builds/1013 Investigating... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145241/new/ https://reviews.llvm.org/D145241

[Lldb-commits] [PATCH] D145180: [lldb] Introduce new SymbolFileJSON and ObjectFileJSON

JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Thanks for the feedback Greg, they're all great suggestions. In D145180#4166302 , @clayborg wrote: > From reading this it looks like your main use case is to supply additional

[Lldb-commits] [PATCH] D145203: Add HitCount into Breakpoint statistics

This revision was automatically updated to reflect the committed changes. Closed by commit rG83263aeceb8e: Add HitCount into Breakpoint statistics (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145203/new/ https://reviews.ll

[Lldb-commits] [lldb] 83263ae - Add HitCount into Breakpoint statistics

Author: Jeffrey Tan Date: 2023-03-03T10:28:56-08:00 New Revision: 83263aeceb8e89709a5da417db753a02bb5a0fbd URL: https://github.com/llvm/llvm-project/commit/83263aeceb8e89709a5da417db753a02bb5a0fbd DIFF: https://github.com/llvm/llvm-project/commit/83263aeceb8e89709a5da417db753a02bb5a0fbd.diff L

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6bd46e713c6d: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member… (authored by Michael137). Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D145241: [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex

This revision was automatically updated to reflect the committed changes. Closed by commit rGb642fd5ee250: [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D145240: [lldb][TypeSystemClang][NFC] Factor out l/r-value reference logic for IsXXXType APIs

This revision was automatically updated to reflect the committed changes. Closed by commit rGd84117d0ef5f: [lldb][TypeSystemClang][NFC] Factor out l/r-value reference logic for IsXXXType… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 6bd46e7 - [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

Author: Michael Buch Date: 2023-03-03T17:44:36Z New Revision: 6bd46e713c6d8deda7bdae8b1efadb99c88b4443 URL: https://github.com/llvm/llvm-project/commit/6bd46e713c6d8deda7bdae8b1efadb99c88b4443 DIFF: https://github.com/llvm/llvm-project/commit/6bd46e713c6d8deda7bdae8b1efadb99c88b4443.diff LOG:

[Lldb-commits] [lldb] d84117d - [lldb][TypeSystemClang][NFC] Factor out l/r-value reference logic for IsXXXType APIs

Author: Michael Buch Date: 2023-03-03T17:44:35Z New Revision: d84117d0ef5fe818990ec2a5199f4b8ceee927b5 URL: https://github.com/llvm/llvm-project/commit/d84117d0ef5fe818990ec2a5199f4b8ceee927b5 DIFF: https://github.com/llvm/llvm-project/commit/d84117d0ef5fe818990ec2a5199f4b8ceee927b5.diff LOG:

[Lldb-commits] [lldb] b642fd5 - [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex

Author: Michael Buch Date: 2023-03-03T17:44:36Z New Revision: b642fd5ee250247ccefb38099169b4ee8ac4112b URL: https://github.com/llvm/llvm-project/commit/b642fd5ee250247ccefb38099169b4ee8ac4112b DIFF: https://github.com/llvm/llvm-project/commit/b642fd5ee250247ccefb38099169b4ee8ac4112b.diff LOG:

[Lldb-commits] [PATCH] D145245: [lldb] Ignore libcxx std::ranges global variables in frame var

Michael137 added a comment. Whoops, last second variable name change broke the build bot. Fixed in `4d909c556e2caa8e150b892384fe8d42e774f8b0` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145245/new/ https://reviews.llvm.org/D145245 _

[Lldb-commits] [lldb] 4d909c5 - [lldb] Build fix: variable name typo

Author: Michael Buch Date: 2023-03-03T17:41:32Z New Revision: 4d909c556e2caa8e150b892384fe8d42e774f8b0 URL: https://github.com/llvm/llvm-project/commit/4d909c556e2caa8e150b892384fe8d42e774f8b0 DIFF: https://github.com/llvm/llvm-project/commit/4d909c556e2caa8e150b892384fe8d42e774f8b0.diff LOG:

[Lldb-commits] [PATCH] D145245: [lldb] Ignore libcxx std::ranges global variables in frame var

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGde10c1a82440: [lldb] Ignore libcxx std::ranges global variables in frame var (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [lldb] de10c1a - [lldb] Ignore libcxx std::ranges global variables in frame var

Author: Michael Buch Date: 2023-03-03T17:36:43Z New Revision: de10c1a824405833a0f49b22e7fa3f32a1393cc3 URL: https://github.com/llvm/llvm-project/commit/de10c1a824405833a0f49b22e7fa3f32a1393cc3 DIFF: https://github.com/llvm/llvm-project/commit/de10c1a824405833a0f49b22e7fa3f32a1393cc3.diff LOG:

[Lldb-commits] [PATCH] D145245: [lldb] Ignore libcxx std::ranges global variables in frame var

Michael137 updated this revision to Diff 502164. Michael137 added a comment. - Fix typo - Add doxygen comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145245/new/ https://reviews.llvm.org/D145245 Files: lldb/include/lldb/Target/LanguageRunt

[Lldb-commits] [PATCH] D145241: [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5280 case clang::Type::MemberPointer: -break; +return lldb::eFormatHex; case clang::T

[Lldb-commits] [PATCH] D145245: [lldb] Ignore libcxx std::ranges global variables in frame var

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. I think this is fine. It's concise, adds useful plugin functionality and we're already hardcoding all sorts of special knowledge about libc++. Comment at: lldb/include/lld

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nice. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:1394 + if (CompilerType CT = valobj.GetCompilerType(); + CT.IsFunctionP

[Lldb-commits] [PATCH] D145245: [lldb] Ignore libcxx std::ranges global variables in frame var

Michael137 updated this revision to Diff 502126. Michael137 added a comment. - Remove leftover debug code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145245/new/ https://reviews.llvm.org/D145245 Files: lldb/include/lldb/Target/LanguageRuntime.

[Lldb-commits] [PATCH] D145245: [lldb] Ignore libcxx std::ranges global variables in frame var

Michael137 added a comment. Alternative to https://reviews.llvm.org/D142993 The other option would be introducing a new clang attribute that indicates "we don't want the debugger to display this but still keep the debug-info". This is what artificial does for inline-functions. So we could exten

[Lldb-commits] [PATCH] D145245: [lldb] Ignore libcxx std::ranges global variables in frame var

Michael137 added a comment. Herald added a subscriber: JDevlieghere. Alternative to https://reviews.llvm.org/D142993 The other option would be introducing a new clang attribute that indicates "we don't want the debugger to display this but still keep the debug-info". This is what artificial doe

[Lldb-commits] [PATCH] D145245: [lldb] Ignore libcxx std::ranges global variables in frame var

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The motivation is to avoid cluttering LLDB's global variable view for std::range

[Lldb-commits] [PATCH] D145242: [lldb][TypeSystemClang] Use the CXXFunctionPointerSummaryProvider for member-function pointers

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. With this patch member-function pointers are formatted using `CXXFunctionPointer

[Lldb-commits] [PATCH] D145241: [lldb][TypeSystemClang] Format pointers to member functions as eFormatHex

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Before this patch, LLDB used to format pointers to members, such as, void (Fo

[Lldb-commits] [PATCH] D145240: [lldb][TypeSystemClang][NFC] Factor out l/r-value reference logic for IsXXXType APIs

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This will be useful as we add more `IsXXXType` APIs for different function types