[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

2023-02-21 Thread Tim Neumann via Phabricator via lldb-commits
TimNN added a comment. Herald added a subscriber: StephenFan. The ThinLTO related breakage I mentioned above should be fixed as of https://github.com/llvm/llvm-project/commit/451799bb8261bde52bbfef226d019caf1d82aa42. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

2023-02-21 Thread Alexander Yermolovich via Phabricator via lldb-commits
ayermolo updated this revision to Diff 499365. ayermolo added a comment. Fixed logic for DwarfMap, also removed an assert in AppleDWARFIndex::GetGlobalVariables. Before when it would invoke GetDwoNum it will go to a virtual API that alays returned nullopt. The ID was handled through GetOSOIndexF

[Lldb-commits] [PATCH] D144528: [lldb] Warn when Mach-O files have overlapping segments

2023-02-21 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! May be we should throw an error when loading a binary with overlapping segments, instead of just showing an error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D144528: [lldb] Warn when Mach-O files have overlapping segments

2023-02-21 Thread Alex Langford via Phabricator via lldb-commits
bulbazord created this revision. bulbazord added reviewers: jasonmolenda, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I recently came across a binary that for some reason had overlapp

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-02-21 Thread Petr Hosek via Phabricator via lldb-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509 ___

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-02-21 Thread Siva Chandra via Phabricator via lldb-commits
sivachandra accepted this revision. sivachandra added a comment. Herald added subscribers: sstefan1, JDevlieghere. OK for libc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144509/new/ https://reviews.llvm.org/D144509

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-02-21 Thread Mark de Wever via Phabricator via lldb-commits
Mordante created this revision. Mordante added reviewers: bollu, tstellar, mehdi_amini, MaskRay, ChuanqiXu, to268, kparzysz, thieta, tschuett, mgorny, stellaraccident, mizvekov, ldionne, jdoerfert, phosek. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1, bzchee

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

2023-02-21 Thread Emre Kultursay via Phabricator via lldb-commits
emrekultursay added a comment. Can you submit the change for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144240/new/ https://reviews.llvm.org/D144240 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D144240: Clear read_fd_set if EINTR received

2023-02-21 Thread Emre Kultursay via Phabricator via lldb-commits
emrekultursay added a comment. > As discussed internally, it would be great if we could remove this > android-specific code path (by removing support for OS versions which > necessitated it). For now, Android Studio still requires the ability to debug API levels 16-19. The next time that min A