[Lldb-commits] [PATCH] D142824: [lldb][NFC] Use move instead of copy

ccotter added a comment. Thanks! I don't have push access, so if you're good with this, could you please land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142824/new/ https://reviews.llvm.org/D142824

[Lldb-commits] [PATCH] D143024: [lldb] Use ${CMAKE_COMMAND} -E remove instead of remove_directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f8fd57cb663: [lldb] Use ${CMAKE_COMMAND} -E remove instead of remove_directory (authored by JDevlieghere). Herald added a project: LLDB. Repository

[Lldb-commits] [lldb] 9f8fd57 - [lldb] Use ${CMAKE_COMMAND} -E remove instead of remove_directory

Author: Jonas Devlieghere Date: 2023-01-31T15:34:36-08:00 New Revision: 9f8fd57cb6638f8137d82b1ceb02845626816b4f URL: https://github.com/llvm/llvm-project/commit/9f8fd57cb6638f8137d82b1ceb02845626816b4f DIFF: https://github.com/llvm/llvm-project/commit/9f8fd57cb6638f8137d82b1ceb02845626816b4f.d

[Lldb-commits] [PATCH] D143022: [lldb][Test] Fix import-std-module and data-formatter tests on older compilers

Michael137 updated this revision to Diff 493751. Michael137 added a comment. - Defined missing variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143022/new/ https://reviews.llvm.org/D143022 Files: lldb/test/API/commands/expression/import-s

[Lldb-commits] [PATCH] D143024: [lldb] Use ${CMAKE_COMMAND} -E remove instead of remove_directory

JDevlieghere created this revision. JDevlieghere added a reviewer: bulbazord. Herald added a project: All. JDevlieghere requested review of this revision. We no longer need to remove a directory downstream and also contrary to my previous observations, remove_directory isn't sufficient to remove

[Lldb-commits] [PATCH] D143022: [lldb][Test] Fix import-std-module and data-formatter tests on older compilers

Michael137 created this revision. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes API tests for older compilers. Since https://reviews.llvm.org/D141828 defaulted arguments will be omitted, but o

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. > - My main source of frustration was that my concern is getting > overlooked/ignored (not necessarily your fault -- I've been told I am not > always sufficiently clear). I think that is something we could live with, if > we thing the other cleanups in this patch are w

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

MaskRay added a comment. edeaf16f2c2f02d6e43312d48d26d354d87913f3 (2011) added the CMake variable `CLANG_RESOURCE_DIR` but did not explain why. The patch introduced conditions in C++ code like std::string path_to_clang_dir = std::string(CLANG_RESOURCE_DIR).empty()

[Lldb-commits] [PATCH] D143012: Add a bit of error checking to SBProcess::ReadMemory to check if a nullptr destination buffer was provided, return error

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I helped a developer using SB API yesterday who had a bug and t

[Lldb-commits] [lldb] 8a16a06 - [lldb][NFC] Remove copy of debugserver entitlements plist

Author: Alex Langford Date: 2023-01-31T12:58:37-08:00 New Revision: 8a16a069540a6c9662e53b64679b1f5ce8e51956 URL: https://github.com/llvm/llvm-project/commit/8a16a069540a6c9662e53b64679b1f5ce8e51956 DIFF: https://github.com/llvm/llvm-project/commit/8a16a069540a6c9662e53b64679b1f5ce8e51956.diff

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. In D138618#4092040 , @clayborg wrote: > How about we make DIERef constructor always take all the info that is needed > to construct the objects correctly: > > DIERef(DWARFDie die); > DIERef(SymbolFileDWARF *dwarf, dw_offset_t

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. I've reverted this change from `main` branch, let me know if there's anything I can do to help with addressing the build issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 __

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode the new default

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. I like this. I have no opinion on having `-i/-b` versus `--mode/-m` to indicate which mode crashlog.py should use, though I think that using an enum makes it easier to add new modes down

[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added reviewers: MaskRay, thesamesam, tstellar. mgorny added a comment. Ok, this turned out to be surprisingly painless, at least within our packaging. However, I'd prefer if someone more experienced looked at the CMake changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [lldb] b27e4f7 - [lldb] Fix warning about unhandled enum value `WasmExternRef` (NFC).

Author: Jorge Gorbe Moya Date: 2023-01-31T10:26:39-08:00 New Revision: b27e4f72213e78cacf0ce5bfd127261ec0b9309b URL: https://github.com/llvm/llvm-project/commit/b27e4f72213e78cacf0ce5bfd127261ec0b9309b DIFF: https://github.com/llvm/llvm-project/commit/b27e4f72213e78cacf0ce5bfd127261ec0b9309b.di

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

This revision was automatically updated to reflect the committed changes. Closed by commit rG8aa313755118: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer (authored by avogelsgesang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [lldb] 8aa3137 - [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

Author: Adrian Vogelsgesang Date: 2023-01-31T07:40:31-08:00 New Revision: 8aa313755118bf43c6042fb316b6c243b2c59be2 URL: https://github.com/llvm/llvm-project/commit/8aa313755118bf43c6042fb316b6c243b2c59be2 DIFF: https://github.com/llvm/llvm-project/commit/8aa313755118bf43c6042fb316b6c243b2c59be2

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

avogelsgesang added a comment. Since I am still blocked on solving the Apple-specific issues in https://reviews.llvm.org/D132735 and couldn't solve them in time for LLVM-16, I now rebased this change directly on `main`, so that it no longer depends on the refactorings from the other commit. My

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

avogelsgesang updated this revision to Diff 493583. avogelsgesang marked an inline comment as done. avogelsgesang added a comment. fix crash in cases where the promise type is unknown even after an attempt at devirtualization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht