omjavaid reopened this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
LLDB windows buildbots were broken by the TestSectionAPI.py test. I dont
have full context of the commit to fix it. Reverting it temporarily.
https://lab.llvm.org/buildbot/#/builders/83/bui
Author: Muhammad Omair Javaid
Date: 2023-01-30T12:34:37+05:00
New Revision: e1bbe50f5a48e9b5407de9e5f4ab8197dedc85c5
URL:
https://github.com/llvm/llvm-project/commit/e1bbe50f5a48e9b5407de9e5f4ab8197dedc85c5
DIFF:
https://github.com/llvm/llvm-project/commit/e1bbe50f5a48e9b5407de9e5f4ab8197dedc85
erikdesjardins added inline comments.
Comment at: llvm/test/DebugInfo/X86/gnu-public-names.ll:68-71
; ASM: .byte 32 # Attributes: VARIABLE, EXTERNAL
+; ASM-NEXT: .asciz "ns::global_namespace_variable" # External Name
+; ASM: .byte 32
erikdesjardins created this revision.
Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3,
wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, wenlei, msifontes,
jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob,
antiagainst, shauheen, r
akyrtzi added a comment.
Hi @domada, these changes break compilation of clang, with such build error:
FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o
In file included from /llvm-project/clang/lib/AST/ASTContext.cpp:81:
In file included from
/llvm-project/llvm/i
chrisbazley added a comment.
Hi, thanks very much for looking at my patch. I added the link that you
proposed to all of the patches in the stack.
> Assuming that we want to go in this direction, it seems quite expensive to
> model this as a fast qualifier rather than an extended qualifier.
Tru
chrisbazley added a comment.
Please refer to
https://discourse.llvm.org/t/rfc-optional-a-type-qualifier-to-indicate-pointer-nullability/
and https://www.open-std.org/jtc1/sc22/wg14/www/docs/n3089.pdf for the wider
context of this commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LA
This revision was automatically updated to reflect the committed changes.
Emmmer marked an inline comment as done.
Closed by commit rG1d7961fd1a36: [LLDB][RISCV] Add RVV registers enums
(authored by Emmmer).
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG L
Author: Emmmer
Date: 2023-01-29T18:07:56+08:00
New Revision: 1d7961fd1a36f0955423362932e1591e7d26ba9d
URL:
https://github.com/llvm/llvm-project/commit/1d7961fd1a36f0955423362932e1591e7d26ba9d
DIFF:
https://github.com/llvm/llvm-project/commit/1d7961fd1a36f0955423362932e1591e7d26ba9d.diff
LOG: [
