[Lldb-commits] [PATCH] D141174: [test] Add more tests for _regexp-break, the 'b' shortcut.

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test more exhaustively tests all the different shortcuts that `_regexp-break` provides. I have a follow up to pro

[Lldb-commits] [PATCH] D141165: [lldb] Fix symbol table use after free

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Symbol/SymbolFile.cpp:188-190 + auto *symtab = GetSymtab(); + if (symtab) +symtab->SectionFileAddressesChanged(); -

[Lldb-commits] [PATCH] D141165: [lldb] Fix symbol table use after free

augusto2112 created this revision. augusto2112 added reviewers: labath, jingham, JDevlieghere. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The symbol file stores a raw pointer to the main object

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. @dblaikie If getter/setter APIs are a blocker, I can remove them and do casts (uint32_t) instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

erichkeane added a comment. Note that the Clang 16 branch is coming up approximately on January 24, and this needs to be reverted or perf-regression fixed by then. @mizvekov : If you or someone else don't have a solution/revert to this by January 13th, @aaron.ballman and I will begin the proce

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. Note that the Clang 16 branch is coming up approximately on January 24, and this needs to be reverted or have the issue reported by @steven_wu fixed by then. @mizvekov : If you or someone else don't have a solution/revert to this by January 13th, @aaron.ballman and

[Lldb-commits] [PATCH] D140066: Add a final fallback technique to the old Darwin dynamic loader plugin to find the dyld_all_image_infos structure

This revision was automatically updated to reflect the committed changes. Closed by commit rG75d268d1fa60: When loading mach-o corefile, new fallback for finding images (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140066/

[Lldb-commits] [lldb] 75d268d - When loading mach-o corefile, new fallback for finding images

Author: Jason Molenda Date: 2023-01-06T10:46:39-08:00 New Revision: 75d268d1fa607a2a9c814040a8d8d5267b49de4c URL: https://github.com/llvm/llvm-project/commit/75d268d1fa607a2a9c814040a8d8d5267b49de4c DIFF: https://github.com/llvm/llvm-project/commit/75d268d1fa607a2a9c814040a8d8d5267b49de4c.diff

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 486794. eloparco added a comment. Fix disassemble on variable-length instructions and disassemble with positive offset Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D14035

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2194 + if (index == sb_instructions.size() + 1) { +fprintf(stderr, "current line not found in disassembled instructions\n"); +return response_instructions; eloparco wrote:

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2194 + if (index == sb_instructions.size() + 1) { +fprintf(stderr, "current line not found in disassembled instructions\n"); +return response_instructions; clayborg wrote:

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto bytes_offset = -instruction_offset * bytes_per_instruction; + auto start_addr = base_addr - bytes_offset; + const auto disassemble_bytes = instruction_count * bytes_per_instruc

[Lldb-commits] [PATCH] D141042: [lldb] Allow configuring on Windows with python interpreter within a junction

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e84e038447e: [lldb] Allow configuring on Windows with python interpreter within a junction (authored by zero9178). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 9e84e03 - [lldb] Allow configuring on Windows with python interpreter within a junction

Author: Markus Böck Date: 2023-01-06T09:58:35+01:00 New Revision: 9e84e038447e283d020ae01aebb15e0e66ef3642 URL: https://github.com/llvm/llvm-project/commit/9e84e038447e283d020ae01aebb15e0e66ef3642 DIFF: https://github.com/llvm/llvm-project/commit/9e84e038447e283d020ae01aebb15e0e66ef3642.diff L