[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

2022-12-28 Thread Lu Weining via Phabricator via lldb-commits
SixWeining added a comment. The tests LGTM. Comment at: lldb/unittests/Instruction/LoongArch/TestLoongArchEmulator.cpp:1-2 +//===-- TestLoongArchEmulator.cpp +//-===// +// Merge these lines into one. CHANGES SINCE L

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

2022-12-28 Thread Hui Li via Phabricator via lldb-commits
lh03061238 updated this revision to Diff 485565. lh03061238 retitled this revision from "[LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch" to "[LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch". lh03061238 edited the summary of this revision. lh03061238 a

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

2022-12-28 Thread Hui Li via Phabricator via lldb-commits
lh03061238 added a comment. In D140386#4007705 , @DavidSpickett wrote: > Please split this patch into 2: > > - the cleanup of the existing branch instructions > - the addition of the new ones > > The changes look good but let's keep each commit to doing

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

2022-12-28 Thread Vitaly Buka via Phabricator via lldb-commits
vitalybuka added a comment. This bot is broken after the patch https://lab.llvm.org/buildbot/#/builders/236/builds/1480 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

2022-12-28 Thread Wang Pengcheng via Phabricator via lldb-commits
pcwang-thead added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:10 +/// \file +/// This header is deprecated in favour of `llvm/Support/RISCVISAInfo.h`. +/// zixuan-wu wrote: > I think there is a typo that should be 'in favour of > `llvm

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

2022-12-28 Thread Zixuan Wu via Phabricator via lldb-commits
zixuan-wu added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:10 +/// \file +/// This header is deprecated in favour of `llvm/Support/RISCVISAInfo.h`. +/// I think there is a typo that should be 'in favour of `llvm/TargetParser/RISCVISAIn