[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

seehearfeel added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.h:58 + uint32_t reg_num) override; + lldb::addr_t ReadPC(bool *success); + bool WritePC(lldb::addr_t pc);

[Lldb-commits] [lldb] e0fdc56 - [lldb] Don't use Optional::getPointer (NFC)

Author: Kazu Hirata Date: 2022-12-07T17:42:59-08:00 New Revision: e0fdc563585f38e7b20507b541dacbfe58aa904b URL: https://github.com/llvm/llvm-project/commit/e0fdc563585f38e7b20507b541dacbfe58aa904b DIFF: https://github.com/llvm/llvm-project/commit/e0fdc563585f38e7b20507b541dacbfe58aa904b.diff L

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo abandoned this revision. ayermolo added a comment. Redid in D139577 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___

[Lldb-commits] [PATCH] D139577: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 481047. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139577/new/ https://reviews.llvm.org/D139577 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFRewriter.cpp

[Lldb-commits] [PATCH] D139577: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. Re-did D139379 after pushing it by mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139577/new/ https://reviews.llvm.org/D139577 ___ lld

[Lldb-commits] [PATCH] D139577: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo created this revision. Herald added subscribers: mstorsjo, hoy, modimo, wenlei, arphaman, hiraditya. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a project: All. ayermolo requested review of this revision. Herald added subs

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. Accidentally pushed when pushing bolt changes. Reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 480994. ayermolo added a comment. rebase, clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFR

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

bulbazord added inline comments. Comment at: lldb/test/API/functionalities/scripted_process/main.cpp:18 + std::unique_lock lock(mutex); + cv.notify_one(); + n = foo(n); Why do you need this initial notification? Comment at: lldb/test/API/fun

[Lldb-commits] [PATCH] D139461: Fix dwarf5-lazy-dwo.c for the default c target not being c99.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5bda52f00b: Fix dwarf5-lazy-dwo.c for the default c target not being c99. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [lldb] fc5bda5 - Fix dwarf5-lazy-dwo.c for the default c target not being c99.

Author: Mitch Phillips Date: 2022-12-07T09:07:56-08:00 New Revision: fc5bda52f00b63fbe4b503b813380d9b81ee7f0b URL: https://github.com/llvm/llvm-project/commit/fc5bda52f00b63fbe4b503b813380d9b81ee7f0b DIFF: https://github.com/llvm/llvm-project/commit/fc5bda52f00b63fbe4b503b813380d9b81ee7f0b.diff

[Lldb-commits] [lldb] 40ade84 - Revert "Store OptTable::Info::Name as a StringRef"

Author: serge-sans-paille Date: 2022-12-07T17:29:53+01:00 New Revision: 40ade845be698355b230abc19c7a76b200188772 URL: https://github.com/llvm/llvm-project/commit/40ade845be698355b230abc19c7a76b200188772 DIFF: https://github.com/llvm/llvm-project/commit/40ade845be698355b230abc19c7a76b200188772.d

[Lldb-commits] [lldb] bdfa310 - Store OptTable::Info::Name as a StringRef

Author: serge-sans-paille Date: 2022-12-07T16:32:37+01:00 New Revision: bdfa3100dc3ea9e9ce4d3d4100ea6bb4c3fa2b81 URL: https://github.com/llvm/llvm-project/commit/bdfa3100dc3ea9e9ce4d3d4100ea6bb4c3fa2b81 DIFF: https://github.com/llvm/llvm-project/commit/bdfa3100dc3ea9e9ce4d3d4100ea6bb4c3fa2b81.d

[Lldb-commits] [PATCH] D139461: Fix dwarf5-lazy-dwo.c for the default c target not being c99.

Eric accepted this revision. Eric added a comment. This revision is now accepted and ready to land. LGTM. It would also be fine to not check the language. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139461/new/ https://reviews.llvm.org/D139461 _

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib updated this revision to Diff 480796. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/ https://reviews.llvm.org/D139484 Files: lldb/test/API/functionalities/scripted_process/Makefile lldb/test/API/functionalities/scripte

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta added a comment. I think this is ready to land @Mordante or is there anything else missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ lldb-comm

[Lldb-commits] [PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

rahmanl updated this revision to Diff 479906. rahmanl added a comment. - Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100808/new/ https://reviews.llvm.org/D100808 Files: llvm/include/llvm/CodeGen/BasicBlockSectionsProfileReader.h llvm

[Lldb-commits] [PATCH] D138141: [amdgpu] Reimplement LDS lowering

JonChesterfield updated this revision to Diff 480484. JonChesterfield added a comment. Herald added subscribers: cfe-commits, libc-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, hanchung, kadircet, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, steakhal, mtrofin, Enna1,

[Lldb-commits] [PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

rahmanl updated this revision to Diff 479905. rahmanl added a comment. Herald added subscribers: cfe-commits, libc-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, hanchung, kadircet, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, steakhal, mtrofin, Enna1, bzcheeseman, ko

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

MaskRay accepted this revision. MaskRay added a comment. Please check these builds all work: - default - `-DLLVM_LINK_LLVM_DYLIB=on` - `-DBUILD_SHARED_LIBS=on` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137

Re: [Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

> I don't know what tools are installed on the builder but I'll ask around the office on Monday, I know there are people who are more familiar with how these bots are set up. Sounds good. Thank you! > FWIW I could repo promise_type failure on my macOS desktop which has the current Xcode 14 tools

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. Thank you for working on this @lenary - LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137

Re: [Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

Hm... wait a second... Which clang-version is https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ using? Is it using an older version of clang? Does that version already contain the patch https://reviews.llvm.org/D132580? If not, that might explain things... On Fri, Nov 25, 2022 at 11:18

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

MaskRay added a comment. The name `llvm/lib/TargetParser` LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___ lldb-commits mailing list lldb-commits@lists

Re: [Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

Hi Jason, Sorry for the late reply - your mail got caught in my spam filter, and I just realized about the build breakage now after you reverted the commits. Just to confirm: I looked at the original change again, and I think I know what's going wrong here: Devirtualization fails, and `promise_ty

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. > As for the name TargetParser. @arsenm came up with the name > SubtargetRegistry. I am fine with either names. @fpetrogalli I'm going to stick with TargetParser, because I think this is less confusing, given that TargetRegistry is already a component. Repository: rG

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added inline comments. Comment at: clang/lib/Lex/CMakeLists.txt:3 -set(LLVM_LINK_COMPONENTS support) +set(LLVM_LINK_COMPONENTS + Support fpetrogalli wrote: > I wonder how `support` was not being detected as a linking error... Not sure, but I still think

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli added a comment. @lenary - thank you for the update! I have added a bunch of miso comments, a bit repetitive... by the time I realised they were repetitive it was faster to get to the bottom of it than removing them! In D137838#3931295 , @l

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. I've updated the patch to use forwarding headers (and to rebase past some changes that have happened in the interim). The patch is still huge because of the number of places using the TargetParsers, which need the component added to their CMakeLists.txt. I think after t

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

MaskRay added a comment. Moving target-specific parsers outside LLVMSupport LGTM. I even objected a bit when more stuff of this kind was introduced into LLVMSupport. +1 for adding temporary forwarding headers for now to avoid update all `#include` users. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. In D137838#3921828 , @thakis wrote: > This is a gigantic diff. I'd recommend keeping the .h files in the old place > for v0 and make them just forwarding headers that include the header at the > new location. That way, you don't

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli added a comment. Hi @lenary - thank you for working on this! The patch is reasonable to me. I agree on the suggestion of using forwarding headers or the first iteration of the change, it will make it easier to review. I'll adapt the auto-get patch at D137517

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

thakis added a comment. This is a gigantic diff. I'd recommend keeping the .h files in the old place for v0 and make them just forwarding headers that include the header at the new location. That way, you don't have to update oodles of include lines in this patch, and it makes it a bit easier t

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. I landed the Clang bits in 94738a5ac34283bb034b022602b9f9e93d67081f , thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1373

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

thakis added inline comments. Herald added a reviewer: njames93. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:47 // complete architecture list, nor a reasonable subset. The problem is that - // historically the driver driver accepts this and also ties its -march= //

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

kadircet added a comment. LGTM for changes under `clang-tools-extra/clangd` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D137503: [CMake] Fix -Wstrict-prototypes

thesamesam added a comment. Thanks! Agreed -- I'll file the backport issue now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137503/new/ https://reviews.llvm.org/D137503 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

to268 accepted this revision. to268 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. Herald added a subscriber: Michael137. Apologies to everyone who has automatically been marked as a reviewer for this change. There is more context for it here: https://discourse.llvm.org/t/targetparser-auto-generation-of-riscv-cpu-definitions/66419/4?u=lenary Repositor

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

mgorny added inline comments. Comment at: clang/CMakeLists.txt:14 set(CLANG_BUILT_STANDALONE TRUE) + if ("${CMAKE_VERSION}" VERSION_LESS "3.20.0") +message(WARNING I wonder if we could move this to `CMakePolicy.cmake`, though admittedly you'd have to som

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

ldionne added a comment. LGTM (sorry, it looks like I approved on behalf of all libc++ vendors but that wasn't my intention). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 _

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59052468c3e3: Move googletest to the third-party directory (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D131919?vs=46

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

MaskRay accepted this revision as: MaskRay. MaskRay added a comment. I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for standalone builds is not necessary. The check in `llvm/CMakeLists.txt` suffices. It's unlikely the users will use different cmake versions to configure

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917644 , @MaskRay wrote: > I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for > standalone builds is not necessary. The check in `llvm/CMakeLists.txt` > suffices. > It's unlikely the users w

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917616 , @thieta wrote: > I think this is fine as we have discussed before. But I really dislike the > code duplication for the check. We could put it in a include() I guess - but > maybe it's not worth it. I wante

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta accepted this revision as: thieta. thieta added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. I think this is fine as we have discussed before. But I really dislike the code duplication for the check. We could put it in a include() I guess

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante created this revision. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiag

[Lldb-commits] [PATCH] D137503: [CMake] Fix -Wstrict-prototypes

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32a2af44e1e8: [CMake] Fix -Wstrict-prototypes (authored by thesame

[Lldb-commits] [PATCH] D133890: [CMake] Do these replacements to make use of D132608

Ericson2314 updated this revision to Diff 473684. Ericson2314 added a comment. Herald added a subscriber: Moerafaat. Rebase, rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133890/new/ https://reviews.llvm.org/D133890 Files: bolt/

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

Rageking8 added a comment. In D137338#3912135 , @aaron.ballman wrote: > In D137338#3907281 , @Rageking8 > wrote: > >> I am ok with you guys taking the parts of this revision that you reviewed >> and directly co

[Lldb-commits] [PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added a comment. I have done the deduping @phosek requested, and changed the variable names from `CMAKE_*` to `LLVMPROJ_*` which hopefully satisfies everyone's criteria. Happy with other non `LLVM_` options too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 updated this revision to Diff 473679. Ericson2314 added a comment. Herald added a subscriber: Moerafaat. Dedup code, rename variables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132608/new/ https://reviews.llvm.org/D132608 Files: b

[Lldb-commits] [PATCH] D137503: [CMake] Fix -Wstrict-prototypes

MaskRay added a comment. In D137503#3910651 , @aaron.ballman wrote: > LGTM, thank you for this! If we do a 15.0.5, I think these changes should > probably go into there as well (WDYT?) I support this. This will make llvm-project 15.0.5 buildable by mor

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. In D137338#3907281 , @Rageking8 wrote: > I am ok with you guys taking the parts of this revision that you reviewed and > directly commiting them to the repo, just like how the person above did it. > This is to break the re

[Lldb-commits] [PATCH] D137503: [CMake] Fix -Wstrict-prototypes

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thank you for this! If we do a 15.0.5, I think these changes should probably go into there as well (WDYT?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137503/new/ https:/

[Lldb-commits] [PATCH] D137503: [CMake] Fix -Wstrict-prototypes

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137503/new/ https://reviews.llvm.org/D137503 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D137503: [CMake] Fix -Wstrict-prototypes

thesamesam created this revision. thesamesam added reviewers: mgorny, aaron.ballman. Herald added a reviewer: bollu. Herald added subscribers: libcxx-commits, Enna1, pengfei. Herald added projects: libunwind, All. Herald added a reviewer: libunwind. thesamesam requested review of this revision. Her

[Lldb-commits] [PATCH] D137503: [CMake] Fix -Wstrict-prototypes

thesamesam added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. Note that we of course don't have to bother doing this for C++ sources and test programs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Ericson2314 added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

Rageking8 added a comment. I am ok with you guys taking the parts of this revision that you reviewed and directly commiting them to the repo, just like how the person above did it. This is to break the revision up to smaller parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

probinson accepted this revision. probinson added a comment. Yes, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

curdeius added inline comments. Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:341 if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) { - // Handle C++ base classes. Non-virtual bases can treated a a kind of + // Handle C++ base classes. Non-virtual bases can treated a

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CodeGenTBAA.cpp:341 if (const CXXRecordDecl *CXXRD = dyn_cast(RD)) { - // Handle C++ base classes. Non-virtual bases can treated a a kind of + // Handle C++ base classes. Non-virtual bases can treat

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

tstellar added a comment. Herald added a subscriber: Moerafaat. @probinson Does this latest update look better? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/new/ https://reviews.llvm.org/D131919

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. The clang parts generally LG, but I spotted a few things. Thank you for this cleanup effort! Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:467 - /// Return a matcher that that points to the same implementation, but sets th

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

int3 added a comment. lld/MachO changes lgtm Comment at: lld/MachO/Driver.cpp:1386 // ld64 does something really weird. It attempts to realign the value to the -// page size, but assumes the the page size is 4K. This doesn't work with +// page size, but assumes th

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

tianshilei1992 added a comment. Can you verify if projects enabled by `LLVM_ENABLE_RUNTIMES` (not `LLVM_ENABLE_PROJECTS`) will still be installed properly, aka in LLVM's lib directory? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

Amir accepted this revision. Amir added a comment. BOLT changes LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

mgorny added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if (!

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

sivachandra accepted this revision. sivachandra added a comment. Changes in the libc directory LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ lldb-co

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

DavidSpickett added a comment. Looked at the lldb changes, some comments for you. If you want to get a "looks good" for those please submit a separate review with only the lldb parts and I'll review that instead. As others said, appreciate the effort but the review process doesn't scale well t

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

tianshilei1992 added a comment. Changes to `openmp` look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

ldionne accepted this revision. ldionne added a comment. Thanks for the fixes. LGTM for `libcxx/`, `libcxxabi/` and `libunwind/`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 __

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

Meinersbur added a comment. Changes in `/polly/` look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aartbik added a comment. LGTM for sparse changes (note that you could have made your life a bit easier if you had broken this revision up at least over different projects, getting a global "LGTM" from somebody may be a bit hard now ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille updated this revision to Diff 472945. serge-sans-paille added a comment. + Release Note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337 Files: bolt/CMakeLists.txt bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

foad added a comment. I committed the lib/Target/AMDGPU parts as 5073ae2a883f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 __

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

glider added subscribers: pcc, glider. glider added inline comments. Comment at: clang/docs/DataFlowSanitizerDesign.rst:54 - /// Returns whether the given label label contains the label elem. + /// Returns whether the given label contains the label elem. int dfsan_has_labe

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

jhenderson added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: Michael137, sstefan1, JDevlieghere. This is going to be impossible to cleanly review as-is. Could it be broken into lots of smaller chunks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, tstellar, mgorny, sylvestre.ledru. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1, bzcheeseman, kosarev, ayermolo, sdasgup3, wenzhicui, wrengr, cota, StephenFan, teijeong, rdzh

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

sylvestre.ledru added a comment. Maybe add it to the release notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

MaskRay added a comment. Herald added a subscriber: Moerafaat. > We held off on this before as `LLVM_LIBDIR_SUFFIX` conflicted with it. Now we > return this. > > I imagine this is too potentially-breaking to make LLVM 15. That's fine. ... These sentences are no longer relevant and should be remo

Re: [Lldb-commits] [lldb] 3e03873 - [lldb][Test] Fix TestFrameFormatNameWithArgs.test on Windows/Linux

That's a known issue for the NativePDB plugin: https://github.com/llvm/llvm-project/issues/51933. Because currently the plugin internally looks up function names by full names. Even if you try to set a breakpoint with a full function name, the plugin itself only receives the basename. On Wed, Nov

Re: [Lldb-commits] [lldb] 3e03873 - [lldb][Test] Fix TestFrameFormatNameWithArgs.test on Windows/Linux

> For example the type `const char *` also has a summary provider, and I'd hope that this feature does not depend on the specific way in which that summary is computed. Yea, it would be nice to have this on Linux. Will try to use a type whose format is compatible across platforms Am Mi., 2. Nov.

[Lldb-commits] [PATCH] D131919: Move googletest to the third-party directory

tstellar updated this revision to Diff 468784. tstellar marked 4 inline comments as done. tstellar added a comment. Herald added a subscriber: zero9178. Rebase and fix some missed path updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131919/ne

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added a comment. In D128465#3826150 , @mgorny wrote: > Is anyone working on a solution that would work for people using a zstd > install method that's actually supported upstream? I have created D134990 , it'd be

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

mgorny added a comment. Is anyone working on a solution that would work for people using a zstd install method that's actually supported upstream? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

phosek added a comment. In D128465#3800479 , @andrewrk wrote: > if(LLVM_ENABLE_ZSTD) > list(APPEND imported_libs zstd::libzstd_shared) > endif() > > This hard codes shared linking which breaks the use case of static linking > LLVM. This was addr

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

andrewrk added a comment. Compiler infrastructure should not assume the existence of a Linux distribution. The portable way is simple and can easily be supported. One should be able to install `$prefix/lib/libzstd.a` and `$prefix/include/zstd.h`, then have that prefix searched as part of the st

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

andrewrk added a comment. if(LLVM_ENABLE_ZSTD) list(APPEND imported_libs zstd::libzstd_shared) endif() This hard codes shared linking which breaks the use case of static linking LLVM. Also LLVM needs to now include a Findzstd.cmake file or else we get this error: CMake Error at cmake/

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

MaskRay added a comment. zstd provides GNU Makefile, CMake, and Meson. The CMake files are only installed when configured with CMake. Debian and Ubuntu lack such files. The pkg-config file libzstd.pc is probably the most portable file. (I have also used it for a binutils-gdb patch.) I think we

[Lldb-commits] [PATCH] D133890: [CMake] Do these replacements to make use of D132608

compnerd added a comment. I don't see anything wrong with this change per se, but I'm conflicted on the name of the variable. These are not standard variables but are encroaching on the CMake namespace. What happens if upstream decides to use these names? I think that we should keep the name

[Lldb-commits] [PATCH] D132608: [CMake] Clean up CMake binary dir handling

phosek added a comment. I agree with @tianshilei1992, I think we should avoid introducing new `CMAKE_` variables to avoid confusion. The same applies to module names, for example I don't think we should be introducing `GNUBinaryDirs` which can be easily confused for `GNUInstallDirs`. I would p

[Lldb-commits] [PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added a comment. @tianshilei1992 that is a fair point. I would be open to calling them something else. I just don't want to call them `LLVM_*` because that would be confusing since there is (a) LLVM in particular (b) the monorepo / project as a whole, and this variable are about *n

[Lldb-commits] [PATCH] D132608: [CMake] Clean up CMake binary dir handling

tianshilei1992 added a comment. Is it a good idea to define variables starting with `CMAKE`? That might be confusing for later maintenance by other developers because chances are that they will think those variables are CMake provided variables, try to look up into CMake document to see what th

[Lldb-commits] [PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 added inline comments. Comment at: libcxx/CMakeLists.txt:421 +if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE) + set(default_install_path "${CMAKE_INSTALL_INCLUDEDIR}/${LLVM_DEFAULT_TARGET_TRIPLE}/c++/v1") +else() ldionne wrote: > ldionne wrote:

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

Ericson2314 updated this revision to Diff 460222. Ericson2314 added a comment. Rebase, fix some issues (by the looks of it) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586 Files: clang/CMakeLists.txt

  1   2   >