[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. avogelsgesang marked an inline comment as done. Closed by commit rGcd3091a88f7c: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer (authore

[Lldb-commits] [lldb] cd3091a - [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

Author: Adrian Vogelsgesang Date: 2022-11-20T14:26:36-08:00 New Revision: cd3091a88f7c55c90d9b5fff372ce1cdfc71948d URL: https://github.com/llvm/llvm-project/commit/cd3091a88f7c55c90d9b5fff372ce1cdfc71948d DIFF: https://github.com/llvm/llvm-project/commit/cd3091a88f7c55c90d9b5fff372ce1cdfc71948d

[Lldb-commits] [PATCH] D137900: Make only one function that needs to be implemented when searching for types.

clayborg added a comment. In D137900#3938759 , @aprantl wrote: > I still have a few more questions about the interface design here. May main > goal is to eliminate as much mutable state and objects being passed by > reference as makes sense (and no more

[Lldb-commits] [lldb] aac1c3b - Add a new top level statistic that tracks how many modules have variable errors.

Author: Greg Clayton Date: 2022-11-20T12:34:16-08:00 New Revision: aac1c3b15aae7a13f6861c6a58729d68d2f1eab0 URL: https://github.com/llvm/llvm-project/commit/aac1c3b15aae7a13f6861c6a58729d68d2f1eab0 DIFF: https://github.com/llvm/llvm-project/commit/aac1c3b15aae7a13f6861c6a58729d68d2f1eab0.diff

[Lldb-commits] [PATCH] D138383: Add a new top level statistic that tracks how many modules have variable errors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaac1c3b15aae: Add a new top level statistic that tracks how many modules have variable errors. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [lldb] 4346318 - [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

Author: Adrian Vogelsgesang Date: 2022-11-20T11:18:52-08:00 New Revision: 4346318f5c700f4e85f866610fb8328fc429319b URL: https://github.com/llvm/llvm-project/commit/4346318f5c700f4e85f866610fb8328fc429319b DIFF: https://github.com/llvm/llvm-project/commit/4346318f5c700f4e85f866610fb8328fc429319b

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4346318f5c70: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty… (authored by avogelsgesang). Changed prior to commit: ht

[Lldb-commits] [lldb] fb61dce - [lldb] Fix test expectation in `TestCoroutineHandle.py` for 32-bit systems

Author: Adrian Vogelsgesang Date: 2022-11-20T10:30:29-08:00 New Revision: fb61dce1adc4572e794e836861915d8ae372749d URL: https://github.com/llvm/llvm-project/commit/fb61dce1adc4572e794e836861915d8ae372749d DIFF: https://github.com/llvm/llvm-project/commit/fb61dce1adc4572e794e836861915d8ae372749d

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added a comment. In D138259#3938841 , @aprantl wrote: > Generally, I think this can be useful information. I don't have any better > suggestion, but I'd like to ask the room if we think that `` > is a good message for the end users. (`Forward-d

[Lldb-commits] [PATCH] D138383: Add a new top level statistic that tracks how many modules have variable errors.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, GeorgeHuyubo, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We have a statistic on each module named "debugI

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg updated this revision to Diff 476754. clayborg added a comment. Changed the API comment describing the SBType::IsTypeForcefullyCompleted(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138259/new/ https://reviews.llvm.org/D138259 Files:

[Lldb-commits] [PATCH] D138259: Add the ability to see when a type in incomplete.

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBType.h:212 + /// Returns true for types that were incomplete in the debug information but + /// should have been a complete. When the debugger constructs types, we must + /// have enough information to reconst

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mgorny added a comment. Thanks, it builds fine for me now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134033/new/ https://reviews.llvm.org/D134033 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D138376: Use None consistently (NFC)

tschuett added a comment. https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138376/new/ https://reviews.llvm.org/D138376 __

[Lldb-commits] [PATCH] D138376: Use None consistently (NFC)

ayermolo added a comment. Is there an a RFC for this or something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138376/new/ https://reviews.llvm.org/D138376 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

This revision was automatically updated to reflect the committed changes. Closed by commit rG01f4c305fae9: Reapply "[LLDB] Devirtualize coroutine promise types for `std… (authored by avogelsgesang). Changed prior to commit: https://reviews.llvm.org/D132624?vs=475327&id=476743#toc Repository:

[Lldb-commits] [lldb] 01f4c30 - Reapply "[LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`"

Author: Adrian Vogelsgesang Date: 2022-11-20T06:35:16-08:00 New Revision: 01f4c305fae9ff2f165ce0f635a90f8e2292308c URL: https://github.com/llvm/llvm-project/commit/01f4c305fae9ff2f165ce0f635a90f8e2292308c DIFF: https://github.com/llvm/llvm-project/commit/01f4c305fae9ff2f165ce0f635a90f8e2292308c

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

avl added a comment. @JDevlieghere Is this assertion happened in single thread mode only, or multi-thread mode only, or both? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138176/new/ https://reviews.llvm.org/D138176 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D138376: Use None consistently (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fa870b1bd6c: Use None consistently (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm