[Lldb-commits] [PATCH] D138376: Use None consistently (NFC)

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. `enum class NoneType { None = 1 };` is from 0cd22f9540c0591132ec991c51103cf800cf4e24 (2017) for MSVC workaround. I assume it is no longer needed.. Repository: rG LLVM Github Monore

[Lldb-commits] [lldb] c903136 - [lldb] Use Optional::has_value instead of Optional::hasValue (NFC)

Author: Kazu Hirata Date: 2022-11-19T23:22:48-08:00 New Revision: c903136f195b65f175797eaf856213b1a6826fa2 URL: https://github.com/llvm/llvm-project/commit/c903136f195b65f175797eaf856213b1a6826fa2 DIFF: https://github.com/llvm/llvm-project/commit/c903136f195b65f175797eaf856213b1a6826fa2.diff L

[Lldb-commits] [PATCH] D138376: Use None consistently (NFC)

kazu created this revision. Herald added subscribers: Moerafaat, zero9178, mtrofin, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle

[Lldb-commits] [PATCH] D138276: TableGen: require tablegen cl::opts to be registered explicitly

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. This is similar to `mlir::register*Options` and looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

MaskRay added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:846 + auto AddStream = [&](size_t Task, + Twine ModuleName) -> std::unique_ptr { int FD = -1; `Twine` should only be used as const refer

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mib added a comment. @mgorny @dyung 41f3e6b74df1 should fix this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134033/new/ https://reviews.llvm.org/D134033 ___

[Lldb-commits] [lldb] 41f3e6b - [lldb/Plugins] Fix build failure with GCC in ScriptedPythonInterface::Dispatch

Author: Med Ismail Bennani Date: 2022-11-19T13:24:47-08:00 New Revision: 41f3e6b74df173198c67f46f223b9815334d42a2 URL: https://github.com/llvm/llvm-project/commit/41f3e6b74df173198c67f46f223b9815334d42a2 DIFF: https://github.com/llvm/llvm-project/commit/41f3e6b74df173198c67f46f223b9815334d42a2.

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mib added a comment. In D134033#3939219 , @mgorny wrote: > I can confirm that it doesn't fail with clang. I think I have a fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134033/new/ https://reviews.ll

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mgorny added a comment. I can confirm that it doesn't fail with clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134033/new/ https://reviews.llvm.org/D134033 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D138250: [lldb/Python] Unify PythonFormat & GetPythonValueFormatString (NFC)

mib closed this revision. mib added a comment. Landed in 27a26e7ab7d8a8b47c63f68bd1801fc2f9342637 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138250/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mib added a comment. In D134033#3939186 , @mgorny wrote: > In D134033#3939158 , @mib wrote: > >> @mgorny @dyung `error: too few template-parameter-lists` this seems to be a >> `g++` error. Could you try building

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mgorny added a comment. In D134033#3939158 , @mib wrote: > @mgorny @dyung `error: too few template-parameter-lists` this seems to be a > `g++` error. Could you try building with clang to confirm my theory ? I'll > try to fix the issue but I have no way

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mib added a comment. @mgorny @dyung `error: too few template-parameter-lists` this seems to be a `g++` error. Could you try building with clang to confirm my theory ? I'll try to fix the issue but I have no way to reproduce it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

dyung added a comment. This seems to have broken the cross-project-test buildbot as well: https://lab.llvm.org/buildbot/#/builders/217/builds/15302 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134033/new/ https://reviews.llvm.org/D134033 ___

[Lldb-commits] [PATCH] D134033: [lldb/Plugins] Improve error reporting when reading memory in Scripted Process

mgorny added a comment. LLDB no longer builds for me after this change (could be related to swig 4.1.0): [1/5] Building CXX object tools/lldb/source/Plugins/ScriptInterpre...ldbPluginScriptInterpreterPython.dir/ScriptedPythonInterface.cpp.o FAILED: tools/lldb/source/Plugins/ScriptInterprete