[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

TimNN added a comment. I didn't manage to repro with `opt`, so still no compilable IR. I did some more debugging, though: - Inside `removeDeadArgumentsFromCallers`, `CB->getCalledFunction()->dump()` (after the modification) is `define void @_RNvXs0_NtNtCs840rfDNPFol_10proc_macro6bridge3rpchINt

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. I will do that and recommit, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

stella.stamenova added a comment. In D133366#3923291 , @kastiglione wrote: > Ugh, the test that is failing uses windows paths but runs on both windows and > non-windows machines. I will revert this and the two fix commits. You should be able to test fo

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. Reverted in rG01f924d0e37a5deae51df0d77e10a15b63aa0c0f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 _

[Lldb-commits] [lldb] 01f924d - [lldb] Revert SBFileSpec.fullpath path separator fix

Author: Dave Lee Date: 2022-11-12T14:17:28-08:00 New Revision: 01f924d0e37a5deae51df0d77e10a15b63aa0c0f URL: https://github.com/llvm/llvm-project/commit/01f924d0e37a5deae51df0d77e10a15b63aa0c0f DIFF: https://github.com/llvm/llvm-project/commit/01f924d0e37a5deae51df0d77e10a15b63aa0c0f.diff LOG:

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. Ugh, the test that is failing uses windows paths but runs on both windows and non-windows machines. I will revert this and the two fix commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @stella.stamenova I realized that test has more paths that need fixing. The rest are fixed in rG760c75fe2d25e06644271cb1338f8b0f8d9abc70 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 760c75f - [lldb] Complete fix of test after 5223366416fb

Author: Dave Lee Date: 2022-11-12T14:12:13-08:00 New Revision: 760c75fe2d25e06644271cb1338f8b0f8d9abc70 URL: https://github.com/llvm/llvm-project/commit/760c75fe2d25e06644271cb1338f8b0f8d9abc70 DIFF: https://github.com/llvm/llvm-project/commit/760c75fe2d25e06644271cb1338f8b0f8d9abc70.diff LOG:

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @stella.stamenova fix is rG1ee299a57d0b5f49b6c37d81474ea030e3b122de Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] 1ee299a - [lldb] Fix test after 5223366416fb

Author: Dave Lee Date: 2022-11-12T14:09:49-08:00 New Revision: 1ee299a57d0b5f49b6c37d81474ea030e3b122de URL: https://github.com/llvm/llvm-project/commit/1ee299a57d0b5f49b6c37d81474ea030e3b122de DIFF: https://github.com/llvm/llvm-project/commit/1ee299a57d0b5f49b6c37d81474ea030e3b122de.diff LOG:

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. @stella.stamenova fix about to be committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

stella.stamenova added a comment. This broke the Windows lldb bot: https://lab.llvm.org/buildbot/#/builders/83/builds/25854 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

TimNN added a comment. I've included excerpts from the IR below. It will take me a bit to provide something compilable. Though you are right, the `noundef` did indeed get removed from the `call`. *** IR Dump Before DeadArgumentEliminationPass on [module] *** ; Function Attrs: nonlazybind uw

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

nikic added a comment. @TimNN Do you have an IR sample for this? DAE is supposed to strip UB-implying attributes when converting arguments to poison here: https://github.com/llvm/llvm-project/blob/cbe5b2dd914b7ee47bb4d0f67af154a40be4d208/llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp#LL291C

[Lldb-commits] [PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

TimNN added a comment. I'm still trying to properly minimize this, but this definitely interacts badly with other optimizations (which triggers the Rust CI failure I mentioned above): - We start with two functions, `outer` and `inner`. `outer` calls `inner`. `outer` has a `noundef` argument tha

[Lldb-commits] [lldb] c899b24 - [lldb] [cmake] Fix another typo in third-party/unittest path

Author: Michał Górny Date: 2022-11-12T10:35:19+01:00 New Revision: c899b243f681fa75cb68144a4d599fdada764d78 URL: https://github.com/llvm/llvm-project/commit/c899b243f681fa75cb68144a4d599fdada764d78 DIFF: https://github.com/llvm/llvm-project/commit/c899b243f681fa75cb68144a4d599fdada764d78.diff