[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Well, I still don't claim to understand this code, but I am happy to stamp anything that fixes bugs by deleting code. Just as an idea for future work, you may want to check that we're correctl

[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

labath added a comment. I believe the reasons are still relevant. Basically the problem is that listening on `localhost:x` creates two sockets (one for 127.0.0.1, one for ::1), and there's no way to guarantee that we'll be able to grab the same port for both (one could be taken by some other ap

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

labath added inline comments. Comment at: lldb/test/API/commands/expression/fixits/TestFixIts.py:54 +# FIXME: LLDB struggles with this when stdlib has debug info. +if not lldbutil.has_debug_info_in_libcxx(target): +self.assertEquals(value.GetError().Ge

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione added a comment. I updated the test in D133395 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133259/new/ https://reviews.llvm.org/D133259 ___ lldb-commits m

[Lldb-commits] [PATCH] D133395: [lldb] Update regex to be less fragile in TestDataFormatterGenericUnordered

kastiglione created this revision. kastiglione added reviewers: mib, rupprecht, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow up to D129386 where

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione updated this revision to Diff 458347. kastiglione added a comment. Expect inline namespace to be __[[:alnum:]]+:: Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133259/new/ https://reviews.llvm.org/D133259 Files: lldb/source/Plugins/L

[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

rupprecht added a comment. I previously converted some tests to support running in ipv6-only environments in D87333 , but we weren't running these tests so I missed them. Looking at history, I see D58131 specifically changed thi

[Lldb-commits] [lldb] 2c38201 - [test] Fix typo in setting the wrong Context test field

Author: Jordan Rupprecht Date: 2022-09-06T18:59:03-07:00 New Revision: 2c38201b091a82ac89f5668706baceff37c07197 URL: https://github.com/llvm/llvm-project/commit/2c38201b091a82ac89f5668706baceff37c07197 DIFF: https://github.com/llvm/llvm-project/commit/2c38201b091a82ac89f5668706baceff37c07197.di

[Lldb-commits] [PATCH] D133393: [test] Use localhost in place of 127.0.0.1 to run in ipv6-only environments.

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D133393 Files: lldb/unittests/tools/lldb-server/tests

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133129/new/ https://reviews.llvm.org/D133129 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg added inline comments. Comment at: lldb/include/lldb/Target/StackFrame.h:264 /// A pointer to a list of variables. - VariableList *GetVariableList(bool get_file_globals); + VariableList *GetVariableList(bool get_file_globals, Status *error_ptr); --

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

kastiglione added a comment. Thanks for the report about the `__cc`, I can try to come up with something less fragile. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:76 +auto ident_end = +name.find_if_not([](char c) { return std::isalnum(

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg updated this revision to Diff 458310. clayborg added a comment. Use -grecord-command-line instead of setting RC_DEBUG_OPTIONS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133164/new/ https://reviews.llvm.org/D133164 Files: lldb/bindin

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg added inline comments. Comment at: lldb/include/lldb/Target/StackFrame.h:264 /// A pointer to a list of variables. - VariableList *GetVariableList(bool get_file_globals); + VariableList *GetVariableList(bool get_file_globals, Status *error_ptr); --

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu updated this revision to Diff 458299. zequanwu added a comment. - Removed `GetParentDeclContextForSymbol` as this is not necesssary. We can get the demangled names from CVSymbol and then using it to create tag decl or namespace decl. - Add test cases with same base names, but with diffe

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

rupprecht added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxxUnorderedMap.cpp:76 +auto ident_end = +name.find_if_not([](char c) { return std::isalnum(c) || c == '_'; }); +if (ident_end != llvm::StringRef::npos && ident_end >= 1) {

[Lldb-commits] [PATCH] D133259: [lldb] Don't assume name of libc++ inline namespace in LibCxxUnorderedMap

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. LGTM -- I patched this in to verify it fixes the test failure we saw. However, and not something that needs to happen in this patch (you could though), but the test actually isn't failin

[Lldb-commits] [lldb] 9690308 - Fix another place were we suggest lldb.target in a Frame Recognizer.

Author: Jim Ingham Date: 2022-09-06T13:24:21-07:00 New Revision: 9690308f78b26df8461f5ac1cb5ba83344254e55 URL: https://github.com/llvm/llvm-project/commit/9690308f78b26df8461f5ac1cb5ba83344254e55 DIFF: https://github.com/llvm/llvm-project/commit/9690308f78b26df8461f5ac1cb5ba83344254e55.diff LO

[Lldb-commits] [lldb] edea4a3 - You can't use lldb.target in a frame recognizer.

Author: Jim Ingham Date: 2022-09-06T13:20:48-07:00 New Revision: edea4a349d04972783d74d00af9245768d6b586e URL: https://github.com/llvm/llvm-project/commit/edea4a349d04972783d74d00af9245768d6b586e DIFF: https://github.com/llvm/llvm-project/commit/edea4a349d04972783d74d00af9245768d6b586e.diff LO

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

rupprecht added a comment. In D133181#3771747 , @labath wrote: > (I've reverted the pthread_kill part, as the mac build did not like it.) Thanks! I didn't get any buildbot notification; do LLDB build bots not send email? Repository: rG LLVM Github M

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

rupprecht requested changes to this revision. rupprecht added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp:293 +r = llvm::sys::RetryAfterSignal(-1, read, pipe.GetReadFileDescriptor(), pos, +

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. I had add extra checks to some tests which are known to fail with debug builds of the standard library, disabling them while a fix is not proposed. Didn't want devs using debug configures to suddenly start seeing test failures Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve updated this revision to Diff 458240. fdeazeve added a comment. Added test changes for tests known to be faulty in the presence of a standard library containing debug symbols, so that developers using debug builds don't see any failures. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D133243: [LLDB][NativePDB] Fix PdbAstBuilder::GetParentDeclContextForSymbol when ICF happens.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:634-659 +name_components = name_components.drop_back(); +if (!name_components.empty()) { + // Render the current list of scope nodes as a fully qualified name, and

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366 ___ lldb

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

kastiglione added a comment. thanks for the fast reply Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://reviews.llvm.org/D133365 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 940704c - [lldb] Fix CommunicationKDP following D133251

Author: Dave Lee Date: 2022-09-06T10:48:12-07:00 New Revision: 940704cc585e8a1b92aa76d2a5720cdde1be4491 URL: https://github.com/llvm/llvm-project/commit/940704cc585e8a1b92aa76d2a5720cdde1be4491 DIFF: https://github.com/llvm/llvm-project/commit/940704cc585e8a1b92aa76d2a5720cdde1be4491.diff LOG:

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

This revision was automatically updated to reflect the committed changes. Closed by commit rG940704cc585e: [lldb] Fix CommunicationKDP following D133251 (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://rev

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione added a comment. Herald added a subscriber: JDevlieghere. will add a test before committing, there was no immediately obvious place for a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133366/new/ https://reviews.llvm.org/D133366

[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

kastiglione created this revision. kastiglione added a reviewer: mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix `fullpath` to not assume a `/` path separator. This was discovered when D1331

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

mgorny added a comment. … and thanks a lot for doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://reviews.llvm.org/D133365 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. That's the same thing that I did for gdb-remote, so I suppose it is correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://r

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

kastiglione added a comment. Note that these two fields are only used in `CommunicationKDP::CheckForPacket`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133365/new/ https://reviews.llvm.org/D133365 ___

[Lldb-commits] [PATCH] D133251: [lldb] [Core] Split read thread support into ThreadedCommunication

kastiglione added a comment. I created D133365 , which solves the compilation issue but I don't know whether it's semantically correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133251/new/ https://reviews.llv

[Lldb-commits] [PATCH] D133365: [lldb] Fix CommunicationKDP following D133251

kastiglione created this revision. kastiglione added reviewers: mgorny, labath, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add `m_bytes` and `m_bytes_mutex` to `CommunicationKDP`, follo

[Lldb-commits] [PATCH] D133251: [lldb] [Core] Split read thread support into ThreadedCommunication

kastiglione added a comment. Herald added a subscriber: JDevlieghere. > `CommunicationKDP` is updated in order to (hopefully) compile with the new > code. However, I do not have a Darwin box to test it, so I've limited the > changes to the bare minimum. Compilation fails: /Users/buildslave/

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

mgorny accepted this revision. mgorny added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteLaunch.py:18 +args = [exe_path, "stderr:arg1", "stderr:arg2", "stderr:arg3"] +hex_args = [seven.h

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

labath added inline comments. Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteLaunch.py:18 +args = [exe_path, "stderr:arg1", "stderr:arg2", "stderr:arg3"] +hex_args = [seven.hexlify(x) for x in args] + mgorny wrote: > Since we no longer s

[Lldb-commits] [lldb] bd323e4 - Revert "[lldb][bindings] Fix module_access handling of regex"

Author: Stella Stamenova Date: 2022-09-06T08:57:28-07:00 New Revision: bd323e42c84476f26bd2f8447f0b0f0dfc204bcb URL: https://github.com/llvm/llvm-project/commit/bd323e42c84476f26bd2f8447f0b0f0dfc204bcb DIFF: https://github.com/llvm/llvm-project/commit/bd323e42c84476f26bd2f8447f0b0f0dfc204bcb.di

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

mgorny added inline comments. Comment at: lldb/test/API/tools/lldb-server/TestGdbRemoteLaunch.py:18 +args = [exe_path, "stderr:arg1", "stderr:arg2", "stderr:arg3"] +hex_args = [seven.hexlify(x) for x in args] + Since we no longer support Python 2,

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

labath updated this revision to Diff 458172. labath added a comment. Add windows error msg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133352/new/ https://reviews.llvm.org/D133352 Files: lldb/source/Host/posix/ProcessLauncherPosixFork.cpp ll

[Lldb-commits] [PATCH] D133352: [lldb-server] Report launch error in vRun packets

labath created this revision. labath added reviewers: mgorny, rupprecht. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Uses our existing "error string" extension to provide a better indication of why the launch failed (the client does not make

[Lldb-commits] [PATCH] D132395: [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

labath added a comment. Oh, and there's also 1b) read once, but retry in case of signals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132395/new/ https://reviews.llvm.org/D132395 ___ lldb-commits maili

[Lldb-commits] [PATCH] D132395: [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

labath added a comment. I just ran into a similar problem, and I realized that (at least for reading) there are actually *three* variants of these calls that can be useful, depending on the case. 1. perform exactly one syscall, return what you get -- important when you don't want to block 2. r

[Lldb-commits] [PATCH] D133181: [test] Remove problematic thread from MainLoopTest to fix flakiness

labath added a comment. (I've reverted the pthread_kill part, as the mac build did not like it.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133181/new/ https://reviews.llvm.org/D133181 ___ lldb-commit

[Lldb-commits] [lldb] 65596ce - [lldb] Go back to process-directed signals in MainLoopTest.cpp

Author: Pavel Labath Date: 2022-09-06T14:00:53+02:00 New Revision: 65596cede8a4bcb8532b37702aa2b42270d4315c URL: https://github.com/llvm/llvm-project/commit/65596cede8a4bcb8532b37702aa2b42270d4315c DIFF: https://github.com/llvm/llvm-project/commit/65596cede8a4bcb8532b37702aa2b42270d4315c.diff

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. In D131160#3771693 , @labath wrote: > Are you sure about that? > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46639 is just > running the commit now. I'd actually suspect the breakage is caused by > D133181

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

labath added a comment. Are you sure about that? https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46639 is just running the commit now. I'd actually suspect the breakage is caused by D133181 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. I think this may have broken tests on Darwin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131160/new/ https://reviews.llvm.org/D131160 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D133251: [lldb] [Core] Split read thread support into ThreadedCommunication

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG9823d42557eb: [lldb] [Core] Split read thread support into ThreadedCommunication (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: htt

[Lldb-commits] [lldb] 9823d42 - [lldb] [Core] Split read thread support into ThreadedCommunication

Author: Michał Górny Date: 2022-09-06T13:09:42+02:00 New Revision: 9823d42557eb1da3ecf2f771ea2cbc84a988ef92 URL: https://github.com/llvm/llvm-project/commit/9823d42557eb1da3ecf2f771ea2cbc84a988ef92 DIFF: https://github.com/llvm/llvm-project/commit/9823d42557eb1da3ecf2f771ea2cbc84a988ef92.diff

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a8bbd26ab22: [lldb] Enable the insertion of "pending callbacks" to MainLoops from other… (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] 6a8bbd2 - [lldb] Enable the insertion of "pending callbacks" to MainLoops from other threads

Author: Pavel Labath Date: 2022-09-06T10:56:10+02:00 New Revision: 6a8bbd26ab22e5c4962b86fc5385b04f0e690b92 URL: https://github.com/llvm/llvm-project/commit/6a8bbd26ab22e5c4962b86fc5385b04f0e690b92 DIFF: https://github.com/llvm/llvm-project/commit/6a8bbd26ab22e5c4962b86fc5385b04f0e690b92.diff

[Lldb-commits] [PATCH] D132395: [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

mgorny added a comment. Yeah, you're right. This is not a problem worth addressing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132395/new/ https://reviews.llvm.org/D132395 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D132283: [lldb] [Core] Reimplement Communication::ReadThread using MainLoop

mgorny added inline comments. Comment at: lldb/source/Core/Communication.cpp:427 // Notify the read thread. - m_connection_sp->InterruptRead(); labath wrote: > mgorny wrote: > > labath wrote: > > > mgorny wrote: > > > > labath wrote: > > > > > Have you cons