[Lldb-commits] [PATCH] D132283: [lldb] [Core] Reimplement Communication::ReadThread using MainLoop

mgorny added inline comments. Comment at: lldb/source/Core/Communication.cpp:427 // Notify the read thread. - m_connection_sp->InterruptRead(); labath wrote: > Have you considered putting this code (some version of it) inside > `InterruptRead`? Basically r

[Lldb-commits] [PATCH] D132735: [LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer

ChuanqiXu added a comment. The summary looks good to me. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:70 + +static bool IsNoopResumeDestroy(Function *f) { + if (!f) Maybe `IsNoopCoro` or something else looks better? Repository: rG LLV

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

ChuanqiXu added a comment. In D132624#3754299 , @avogelsgesang wrote: > @labath D132815 addresses your point: With > that change, the `promise` member now is typed as a pointer. > > I would prefer to land the patches i

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang added a comment. @labath D132815 addresses your point: With that change, the `promise` member now is typed as a pointer. I would prefer to land the patches in the order D132624 (this review), D132735

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

avogelsgesang created this revision. avogelsgesang added reviewers: labath, dblaikie, aprantl, ChuanqiXu, mib. Herald added a project: All. avogelsgesang requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. So far, the pretty printer for `std::c

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 456197. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid