[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

clayborg updated this revision to Diff 454695. clayborg added a comment. Added a test case that tests that we can load a .dwo file with a DWO ID of zero. Was unable to get clang to emit extra stuff in the skeleton compile unit even with -fsplit-dwarf-inlining. Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D132433: [lldb] Teach LLDB about filesets (WIP)

JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. https://reviews.llvm.org/D132433 Files: lldb/include/lldb/Symbol/ObjectFile.h lldb/source/Plugins/Ob

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

ChuanqiXu added a reviewer: dblaikie. ChuanqiXu added a comment. LGTM. But I am not familiar with debugger internals. So I'll leave the formal acceptance for other reviewers. Comment at: lldb/source/Plugins/Language/CPlusPlus/Coroutines.cpp:138 +} \ No newline at end of file

[Lldb-commits] [PATCH] D131437: Don't index the skeleton CU when we have a fission compile unit.

clayborg added a comment. So I can't get -fsplit-dwarf-inlining to emit anything when I try to cross with clang. I add the flag but no extra function info gets emitted in the dwarf in the main executable. I tried: clang++ -gdwarf-5 -gsplit-dwarf -fsplit-dwarf-inlining -c main.cpp -o main2.o

[Lldb-commits] [lldb] c21dfa9 - [lldb] Remove prefer-dynamic-value test override

Author: Dave Lee Date: 2022-08-22T15:46:03-07:00 New Revision: c21dfa9e4931a0a339813a5d384fc2eb0deee235 URL: https://github.com/llvm/llvm-project/commit/c21dfa9e4931a0a339813a5d384fc2eb0deee235 DIFF: https://github.com/llvm/llvm-project/commit/c21dfa9e4931a0a339813a5d384fc2eb0deee235.diff LOG:

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc21dfa9e4931: [lldb] Remove prefer-dynamic-value test override (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

kastiglione updated this revision to Diff 454636. kastiglione added a comment. Fixed description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132382/new/ https://reviews.llvm.org/D132382 Files: lldb/packages/Python/lldbsuite/test/configuration.

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:1139 + AddCXXSynthetic( // XXX + cpp_category_sp, I need to remove this. This is a left-over from an earlier implementation sketch Repository:

[Lldb-commits] [PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

avogelsgesang created this revision. avogelsgesang added reviewers: ChuanqiXu, aprantl, labath, mib, JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: All. avogelsgesang requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-comm

[Lldb-commits] [PATCH] D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

This revision was automatically updated to reflect the committed changes. Closed by commit rGae376feb0b19: Modify all register values whose byte size matches the address size to be… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] ae376fe - Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

Author: Greg Clayton Date: 2022-08-22T14:48:16-07:00 New Revision: ae376feb0b1922294884257811b9659eed83e1e1 URL: https://github.com/llvm/llvm-project/commit/ae376feb0b1922294884257811b9659eed83e1e1 DIFF: https://github.com/llvm/llvm-project/commit/ae376feb0b1922294884257811b9659eed83e1e1.diff

[Lldb-commits] [PATCH] D131705: Don't create sections for SHN_ABS symbols in ELF files.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0697d7c3fb5: Don't create sections for SHN_ABS symbols in ELF files. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131705/new/ http

[Lldb-commits] [lldb] f0697d7 - Don't create sections for SHN_ABS symbols in ELF files.

Author: Greg Clayton Date: 2022-08-22T14:46:27-07:00 New Revision: f0697d7c3fb5296cfec1718206aceb77b7ca9ab8 URL: https://github.com/llvm/llvm-project/commit/f0697d7c3fb5296cfec1718206aceb77b7ca9ab8 DIFF: https://github.com/llvm/llvm-project/commit/f0697d7c3fb5296cfec1718206aceb77b7ca9ab8.diff

[Lldb-commits] [PATCH] D129521: Add the ability to run expressions that call fork() or vfork().

clayborg added a comment. Ping. I would love to get this in if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129521/new/ https://reviews.llvm.org/D129521 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

mib added a comment. This would be pretty neat, if we're able to make it work without creating side-effects to other component. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132307/new/ https://reviews.llvm.org/D132307 ___

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

augusto2112 accepted this revision. augusto2112 added a comment. I think this is a good change. One related thing that we could look into fixing is that currently both run-target and no-run-target do the **exact** same thing. Not sure if we could remove one of them since this could break user's

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. I've had this issue in the past in a test where the variable value would not match what I'd get on an interactive debug session, until I added that flag. I think this makes sense to have consistency

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

mib added a comment. > were changed to be run with no-dynamic-value. I don't the reasons for not > changing the tests, perhaps to avoid determining which tests to change and > how. I don't ** know ** the reasons ... ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

kastiglione added inline comments. Comment at: lldb/source/Utility/CMakeLists.txt:29 + PROPERTIES COMPILE_OPTIONS + "-fcxx-exceptions" +) labath wrote: > kastiglione wrote: > > kastiglione wrote: > > > JDevlieghere wrote: > > > > kastiglione wrote: > > > > > th

[Lldb-commits] [PATCH] D132397: [LLDB] Clean up after command fails

zequanwu created this revision. zequanwu added a reviewer: JDevlieghere. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `CommandObject::CheckRequirements()` requires m_exe_ctx being cleaned up. Repos

[Lldb-commits] [PATCH] D132395: [lldb] [gdb-remote] Use Communication::WriteAll() over Write()

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added subscribers: kristof.beyls, arichardson. Herald added a project: All. mgorny requested review of this revision. Replace the uses of Communication::Write() with WriteAll() to avoid partial write

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

kastiglione added inline comments. Comment at: lldb/test/API/sanity/TestSettingSkipping.py:15-32 + @skipIf(py_version=('>=', (3, 0))) def testSkip(self): """This setting is on by default""" self.assertTrue(False, "This test should not run!") - @skipIf(setting=('t

[Lldb-commits] [PATCH] D132382: [lldb] Remove prefer-dynamic-value test override

kastiglione created this revision. kastiglione added reviewers: augusto2112, JDevlieghere, mib, aprantl. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove the test override of `target.prefer-dyn

[Lldb-commits] [PATCH] D132231: [lldb][ClangExpression] Remove storage-class check when creating AsmLabel

This revision was automatically updated to reflect the committed changes. Closed by commit rG09f608fda51c: [lldb][ClangExpression] Remove storage-class check when creating AsmLabel (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D132271: [lldb][Test] Replace expect() with expect_expr() in TestNamespaceLookup.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f19f98710f8: [lldb][Test] Replace expect() with expect_expr() in TestNamespaceLookup.py (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [lldb] 09f608f - [lldb][ClangExpression] Remove storage-class check when creating AsmLabel

Author: Michael Buch Date: 2022-08-22T13:22:20+01:00 New Revision: 09f608fda51ca9dd2d88c2985bad1cfc1e36251e URL: https://github.com/llvm/llvm-project/commit/09f608fda51ca9dd2d88c2985bad1cfc1e36251e DIFF: https://github.com/llvm/llvm-project/commit/09f608fda51ca9dd2d88c2985bad1cfc1e36251e.diff

[Lldb-commits] [lldb] 6f19f98 - [lldb][Test] Replace expect() with expect_expr() in TestNamespaceLookup.py

Author: Michael Buch Date: 2022-08-22T13:22:19+01:00 New Revision: 6f19f98710f897ecaf148f42da6eec9d14631449 URL: https://github.com/llvm/llvm-project/commit/6f19f98710f897ecaf148f42da6eec9d14631449 DIFF: https://github.com/llvm/llvm-project/commit/6f19f98710f897ecaf148f42da6eec9d14631449.diff

[Lldb-commits] [lldb] b21de9b - [lldb] Silence a GCC warning about missing returns after a fully covered switch. NFC.

Author: Martin Storsjö Date: 2022-08-22T14:53:29+03:00 New Revision: b21de9b38f4b5f2ae6d49f973b683f118b9d58cb URL: https://github.com/llvm/llvm-project/commit/b21de9b38f4b5f2ae6d49f973b683f118b9d58cb DIFF: https://github.com/llvm/llvm-project/commit/b21de9b38f4b5f2ae6d49f973b683f118b9d58cb.diff

[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

This revision was automatically updated to reflect the committed changes. Closed by commit rG65f6a8c23b53: [LLDB] Fix: make m_target_arch private (authored by Emmmer). Changed prior to commit: https://reviews.llvm.org/D132353?vs=454426&id=454434#toc Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [lldb] 65f6a8c - [LLDB] Fix: make m_target_arch private

Author: Emmmer Date: 2022-08-22T18:01:44+08:00 New Revision: 65f6a8c23b5315628c980149be73e692be8e2aa6 URL: https://github.com/llvm/llvm-project/commit/65f6a8c23b5315628c980149be73e692be8e2aa6 DIFF: https://github.com/llvm/llvm-project/commit/65f6a8c23b5315628c980149be73e692be8e2aa6.diff LOG: [

[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. I think there are a few more commented out asserts, check that a grep for `m_target_arch` in `lldb/` doesn't turn up anything you wouldn't expect. Otherwise LGTM. If you find any

[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

Emmmer updated this revision to Diff 454426. Emmmer added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132353/new/ https://reviews.llvm.org/D132353 Files: lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_i386.cpp lldb/source/Plugins/Pro

[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoInterface.h:64 - // FIXME make private. lldb_private::ArchSpec m_target_arch; Rare footage of a fixme getting fixed :) Thanks! Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/RegisterContextFreeBSD_powerpc.cpp:227 const RegisterInfo *RegisterContextFreeBSD_powerpc64::GetRegisterInfo() const { // assert (m_target_arch.GetCore() == ArchSpec::eCore_powerpc); + if (

[Lldb-commits] [PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

sebastian-ne added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:89 - set(LLVM_EXPORTED_SYMBOL_FILE ${LLVM_BINARY_DIR}/libllvm-c.exports) The lib here is not used as a folder, so this should probably not be replaced? It should probably in

[Lldb-commits] [PATCH] D132353: [LLDB] Fix: make m_target_arch private

Emmmer created this revision. Herald added subscribers: atanasyan, jrtc27, nemanjai, emaste. Herald added a project: All. Emmmer edited the summary of this revision. Emmmer added reviewers: JDevlieghere, DavidSpickett. Emmmer added a project: LLDB. Emmmer added subscribers: imkiva, liaolucy. Emmmer

[Lldb-commits] [PATCH] D132231: [lldb][ClangExpression] Remove storage-class check when creating AsmLabel

Michael137 updated this revision to Diff 454406. Michael137 added a comment. - Move one passing test case out of xfail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132231/new/ https://reviews.llvm.org/D132231 Files: lldb/source/Plugins/SymbolFi

[Lldb-commits] [PATCH] D132191: Treat a UUID of all zeros consistently to mean "Invalid UUID"

labath accepted this revision. labath added inline comments. Comment at: lldb/include/lldb/Utility/UUID.h:47 + /// Creates a UUID from the data pointed to by the bytes argument. static UUID fromData(const void *bytes, uint32_t num_bytes) { if (bytes) Th

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

labath added a comment. What's the reasoning behind `TriggerPendingCallbacks`? I was assuming that the addition of a callback would cause it to run automatically... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131160/new/ https://reviews.llvm.org/D131160 _

[Lldb-commits] [PATCH] D132217: [lldb] [Core] Harmonize Communication::Read() returns w/ thread

labath added a comment. In D132217#3735180 , @mgorny wrote: > @labath, any chance you could take a look at the failures on Windows? I'm > wondering if this is because "pipes don't work like that on Windows" or if > there's a way to make them work. For n

[Lldb-commits] [PATCH] D132231: [lldb][ClangExpression] Remove storage-class check when creating AsmLabel

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Yeah, fixing this correctly is not going to be trivial. Off the top of my head, I can think of two solutions (creating per-file ASTs for static objects, or putting all static objects from a gi

[Lldb-commits] [PATCH] D132307: [lldb] Switch RegularExpression from llvm::Regex to std::regex

labath requested changes to this revision. labath added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Utility/CMakeLists.txt:29 + PROPERTIES COMPILE_OPTIONS + "-fcxx-exceptions" +) kastiglione wrote: > kastiglione wrote