[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. In D129377#3673237 , @mib wrote: > In D129377#3673204 , @mstorsjo > wrote: > >> This broke building of Clang, when it's set up by symlinking >> `llvm-project/clang` into `llvm-project/l

[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

wallace added a comment. Just one more change and good to go Comment at: lldb/include/lldb/Core/Disassembler.h:87 + virtual lldb::InstructionControlFlowKind + GetControlFlowKind(const ExecutionContext *exe_ctx) = 0; could add a default implementation here?

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

smeenai added a comment. In D130309#3673365 , @thakis wrote: > Still broken on windows for me: http://45.33.8.238/win/62911/step_4.txt Seeing the same errors here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D130403: Use the range-based overload of llvm::sort where possible

gribozavr created this revision. Herald added subscribers: carlosgalvezp, cishida, cmtice, usaxena95, kadircet, arphaman, mgrang. Herald added a reviewer: jhenderson. Herald added a reviewer: aaron.ballman. Herald added a reviewer: ributzka. Herald added a project: All. gribozavr requested review

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

thakis added a comment. Still broken on windows for me: http://45.33.8.238/win/62911/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/ https://reviews.llvm.org/D130309 ___ lldb-commits

[Lldb-commits] [lldb] c18304e - [lldb] Remote accidental logs left in TestGuiExpandThreadsTree

Author: Augusto Noronha Date: 2022-07-22T16:06:49-07:00 New Revision: c18304e60067b904941fbcfb3ca1649798b242f6 URL: https://github.com/llvm/llvm-project/commit/c18304e60067b904941fbcfb3ca1649798b242f6 DIFF: https://github.com/llvm/llvm-project/commit/c18304e60067b904941fbcfb3ca1649798b242f6.dif

[Lldb-commits] [lldb] 3b8a1cc - [lldb] Disable TestGuiExpandThreadsTree

Author: Augusto Noronha Date: 2022-07-22T16:00:51-07:00 New Revision: 3b8a1cc38ab72afe6889f3c1fff7c3deb8ac26ec URL: https://github.com/llvm/llvm-project/commit/3b8a1cc38ab72afe6889f3c1fff7c3deb8ac26ec DIFF: https://github.com/llvm/llvm-project/commit/3b8a1cc38ab72afe6889f3c1fff7c3deb8ac26ec.dif

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mib added a comment. In D129377#3673204 , @mstorsjo wrote: > This broke building of Clang, when it's set up by symlinking > `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake > configure errors out like this: > > -- Configuring d

[Lldb-commits] [lldb] d959324 - Revert "[lldb/Fuzzer] Add fuzzer for expression evaluator"

Author: Med Ismail Bennani Date: 2022-07-22T15:24:40-07:00 New Revision: d959324e1efec12c3924c17b7d90db0b37eb84c3 URL: https://github.com/llvm/llvm-project/commit/d959324e1efec12c3924c17b7d90db0b37eb84c3 DIFF: https://github.com/llvm/llvm-project/commit/d959324e1efec12c3924c17b7d90db0b37eb84c3.

[Lldb-commits] [PATCH] D130401: Implement better path matching in FileSpecList::FindCompatibleIndex(...).

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, yinghuitan. Herald added subscribers: arphaman, mgorny. Herald added a project: All. clayborg requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstef

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

clayborg abandoned this revision. clayborg added a comment. Abandoning since I am going to add FileSpecList::FindCompatibleIndex(...) which doesn't match the original description of this patch. I will submit a new one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mstorsjo added a comment. This broke building of Clang, when it's set up by symlinking `llvm-project/clang` into `llvm-project/llvm/tools`. In that case, cmake configure errors out like this: -- Configuring done CMake Error in tools/clang/tools/clang-fuzzer/handle-cxx/CMakeLists.txt: T

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

This revision was automatically updated to reflect the committed changes. Closed by commit rGb797834748f1: [lldb/Fuzzer] Add fuzzer for expression evaluator (authored by cassanova). Changed prior to commit: https://reviews.llvm.org/D129377?vs=444761&id=446982#toc Repository: rG LLVM Github M

[Lldb-commits] [lldb] b797834 - [lldb/Fuzzer] Add fuzzer for expression evaluator

Author: Chelsea Cassanova Date: 2022-07-22T17:32:00-04:00 New Revision: b797834748f1954950880bf50fb78abedd4494e6 URL: https://github.com/llvm/llvm-project/commit/b797834748f1954950880bf50fb78abedd4494e6 DIFF: https://github.com/llvm/llvm-project/commit/b797834748f1954950880bf50fb78abedd4494e6.d

[Lldb-commits] [PATCH] D130396: Cache the value for absolute path in FileSpec.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdabe877248b8: Cache the value for absolute path in FileSpec. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130396/new/ https://revie

[Lldb-commits] [lldb] dabe877 - Cache the value for absolute path in FileSpec.

Author: Greg Clayton Date: 2022-07-22T14:04:52-07:00 New Revision: dabe877248b85b34878e75d5510339325ee087d0 URL: https://github.com/llvm/llvm-project/commit/dabe877248b85b34878e75d5510339325ee087d0 DIFF: https://github.com/llvm/llvm-project/commit/dabe877248b85b34878e75d5510339325ee087d0.diff

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg added a comment. In D130309#3673046 , @mstorsjo wrote: > In D130309#3673045 , @clayborg > wrote: > >> Another fix for linux: >> >> commit 0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24 >>

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

mstorsjo added a comment. In D130309#3673045 , @clayborg wrote: > Another fix for linux: > > commit 0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24 > (HEAD > -> main, origin/main, origin/HEA

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg added a comment. Another fix for linux: commit 0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24 (HEAD -> main, origin/main, origin/HEAD) Author: Greg Clayton Date: Fri Jul 22 13:59:06 2022 -0700 Fix buildbot breakage a

[Lldb-commits] [lldb] 0bbce7a - Fix buildbot breakage after https://reviews.llvm.org/D130309.

Author: Greg Clayton Date: 2022-07-22T13:59:06-07:00 New Revision: 0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24 URL: https://github.com/llvm/llvm-project/commit/0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24 DIFF: https://github.com/llvm/llvm-project/commit/0bbce7a4c2d2bff622bdadd4323f93f5d90e6d24.diff

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

mstorsjo added a comment. In D130309#3672934 , @clayborg wrote: > Submitted a fix for the buildbots: > > commit f959d815f4637890ebbacca379f1c38ab47e4e14 > (HEAD > -> main) > Author: G

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

JDevlieghere added inline comments. Comment at: lldb/source/Utility/ArchSpec.cpp:1390-1395 + case ArchSpec::eCore_riscv64: +if (!enforce_exact_match) { + if (core2 == ArchSpec::eCore_riscv64) +return true; +} +break; I don't think this i

[Lldb-commits] [PATCH] D130396: Cache the value for absolute path in FileSpec.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130396/new/ https://reviews.llvm.org/D130396 ___

[Lldb-commits] [PATCH] D130045: Implement better path matching in FileSpecList::FindFileIndex(...).

clayborg added a comment. Submitted the absolute caching stuff in FileSpec with https://reviews.llvm.org/D130396. I will rebase this on top of that diff when it gets checked in. I will also revert changes to FindFileIndex, and then add a new FindContainedFileIndex(...) with the contents of thi

[Lldb-commits] [PATCH] D130396: Cache the value for absolute path in FileSpec.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added subscribers: lldb-commits, aheejin. Herald added a project: LLDB. Checking if a path is absolute can be expensive and cu

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg added a comment. Submitted a fix for the buildbots: commit f959d815f4637890ebbacca379f1c38ab47e4e14 (HEAD -> main) Author: Greg Clayton Date: Fri Jul 22 13:24:04 2022 -0700 Fix buildbot breakage after https://r

[Lldb-commits] [lldb] f959d81 - Fix buildbot breakage after https://reviews.llvm.org/D130309.

Author: Greg Clayton Date: 2022-07-22T13:24:26-07:00 New Revision: f959d815f4637890ebbacca379f1c38ab47e4e14 URL: https://github.com/llvm/llvm-project/commit/f959d815f4637890ebbacca379f1c38ab47e4e14 DIFF: https://github.com/llvm/llvm-project/commit/f959d815f4637890ebbacca379f1c38ab47e4e14.diff

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

clayborg added a comment. Looking at the build breakage now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/ https://reviews.llvm.org/D130309 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

mstorsjo added a comment. I ran into this build break too - please try to fix or revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/ https://reviews.llvm.org/D130309 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

thakis added a comment. This doesn't build, as far as I can tell: http://45.33.8.238/linux/82002/step_4.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/ https://revie

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

clayborg added a comment. Can we add a test for this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130307/new/ https://reviews.llvm.org/D130307 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9429b67b8e30: [NFC] Improve FileSpec internal APIs and usage in preparation for adding… (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [lldb] 9429b67 - [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

Author: Greg Clayton Date: 2022-07-22T10:12:31-07:00 New Revision: 9429b67b8e300e638d7828bbcb95585f85c4df4d URL: https://github.com/llvm/llvm-project/commit/9429b67b8e300e638d7828bbcb95585f85c4df4d DIFF: https://github.com/llvm/llvm-project/commit/9429b67b8e300e638d7828bbcb95585f85c4df4d.diff

[Lldb-commits] [PATCH] D130320: Move GetControlFlowKind's logic to DisassemblerLLVMC.cpp

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great! thank you. I'll land this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130320/new/ https://reviews.llvm.org/D130320 ___ lldb-com

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov added a comment. In D112374#3666531 , @kimgr wrote: > From a purely personal perspective, I'd prefer if this landed after the > branch for llvm-15. > > We try to co-release IWYU shortly after LLVM/Clang are released, to get a > public API-compa

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer updated this revision to Diff 446766. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/ https://reviews.llvm.org/D130342 Files: lldb/source/Host/common/HostInfoBase.cpp lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp lldb/source/Plugins/Process/Linux/CMake

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add Register Info and Context

Emmmer created this revision. Emmmer added reviewers: labath, DavidSpickett, JDevlieghere, jingham. Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosb

[Lldb-commits] [PATCH] D130341: [lldb] [gdb-remote] Use vKill packet if multiprocess & available

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Prefer the modern vKill packet over k if the server reports multiprocess support. This ensures

[Lldb-commits] [PATCH] D130340: [lldb] [gdb-remote] Refactor killing process and move it to client

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Refactor the code responsible for sending the "k" packet and move it into GDBRemoteCommunicatio

[Lldb-commits] [PATCH] D130307: [LLDB][Reliability] Fix register value unpacking

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Thanks! I'm bothered that no test hit this but I deal with that (it's probably because no instruction you'd need to emulate uses these registers). Repository: rG LLVM Github

[Lldb-commits] [lldb] 1ac12a5 - [lldb][ARM] Invert emulation test assert message

Author: David Spickett Date: 2022-07-22T09:35:30Z New Revision: 1ac12a517767c0108a6859b723bc1351d8ba2157 URL: https://github.com/llvm/llvm-project/commit/1ac12a517767c0108a6859b723bc1351d8ba2157 DIFF: https://github.com/llvm/llvm-project/commit/1ac12a517767c0108a6859b723bc1351d8ba2157.diff LOG

[Lldb-commits] [PATCH] D130285: [lldb] Handle jumping to the end in DW_OP_skip/DW_OP_bra

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c39c31a9952: [lldb] Handle jumping to the end in DW_OP_skip/DW_OP_bra (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130285/new/ https:

[Lldb-commits] [lldb] 5c39c31 - [lldb] Handle jumping to the end in DW_OP_skip/DW_OP_bra

Author: Andy Yankovsky Date: 2022-07-22T09:22:40Z New Revision: 5c39c31a99525630dfe684fed48292a50fd0c3c9 URL: https://github.com/llvm/llvm-project/commit/5c39c31a99525630dfe684fed48292a50fd0c3c9 DIFF: https://github.com/llvm/llvm-project/commit/5c39c31a99525630dfe684fed48292a50fd0c3c9.diff LOG

[Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

aarzilli added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128504/new/ https://reviews.llvm.org/D128504 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] 8184b25 - [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Author: Michael Buch Date: 2022-07-22T08:02:09+01:00 New Revision: 8184b252cdab2fbe44f766d6de28b29ebe4c8753 URL: https://github.com/llvm/llvm-project/commit/8184b252cdab2fbe44f766d6de28b29ebe4c8753 DIFF: https://github.com/llvm/llvm-project/commit/8184b252cdab2fbe44f766d6de28b29ebe4c8753.diff

[Lldb-commits] [lldb] 317c8bf - [LLDB][Expression] Allow instantiation of IR Entity from ValueObject

Author: Michael Buch Date: 2022-07-22T08:02:08+01:00 New Revision: 317c8bf84d185c6b4a51a415c0deb7f8af661cb6 URL: https://github.com/llvm/llvm-project/commit/317c8bf84d185c6b4a51a415c0deb7f8af661cb6 DIFF: https://github.com/llvm/llvm-project/commit/317c8bf84d185c6b4a51a415c0deb7f8af661cb6.diff

[Lldb-commits] [lldb] fcf4e25 - [LLDB][NFC] Create variable for hardcoded alignment/size constants in materializer

Author: Michael Buch Date: 2022-07-22T08:02:07+01:00 New Revision: fcf4e252f4d992cade4bdfe5aed10ff96fa40202 URL: https://github.com/llvm/llvm-project/commit/fcf4e252f4d992cade4bdfe5aed10ff96fa40202 DIFF: https://github.com/llvm/llvm-project/commit/fcf4e252f4d992cade4bdfe5aed10ff96fa40202.diff