[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay reopened this revision. MaskRay added a comment. This revision is now accepted and ready to land. This patch has changed a lot from what I have reviewed. The CMake change should be added along with `llvm::compression::zstd::*` functions. Otherwise the change just introduces some CMake var

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ MaskRay wrote: > This needs a change in lld/test/CMakeLists.txt > > L

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ This needs a change in lld/test/CMakeLists.txt Looks like you haven't

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ldionne added inline comments. Comment at: llvm/CMakeLists.txt:441 +set(LLVM_ENABLE_ZSTD "ON" CACHE STRING "Use zstd for compression/decompression if available. Can be ON, OFF, or FORCE_ON") + This broke builds that do not specify `LLVM_ENABLE_ZSTD=OFF` explic

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf07caf20b9d3: [llvm] cmake config groundwork to have ZSTD in LLVM (authored by ckissane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 443362. cassanova edited the summary of this revision. cassanova added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Building the expression evaluator fuzzer is now conditional on the CLANG_ENABLE_PROTO_FUZZER CMake varia

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443310. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files:

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. marked fixed comments as done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ lldb-comm

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443308. ckissane added a comment. - Merge remote-tracking branch 'origin/main' into ckissane.add-zstd.0-cmake - added have_zstd to compiler-rt/test/lit.common.cfg.py, clang-tools-extra/clangd/test/lit.cfg.py and several lit.site.cfg.py.in files Repository:

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu added a comment. In D125509#3637271 , @dyung wrote: > Hi @zequanwu, your change is causing a test failure in the cross-project-test > suite on the PS4 linux bot. Can you take a look and revert if you need time > to investigate? > > https://lab.

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

JDevlieghere added a comment. I went ahead and reverted your change to turn the bot green again: commit e4c5bca597a6f12e8f789a53e862387b9808ff48 (HEAD -> main, origin/main, origin/HEAD) Author: Jonas Devlieghere Date: Thu Jul 7 16:28:35 2022 -0700 Revert "[LLDB][NFC] Decouple d

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

JDevlieghere added a comment. This is breaking a bunch of tests on GreenDragon: lldb-api.functionalities/location-list-lookup.TestLocationListLookup.py lldb-api.functionalities/param_entry_vals/basic_entry_values.TestBasicEntryValues.py lldb-api.functionalities/return-value.TestReturnValue

[Lldb-commits] [PATCH] D127444: [libc++] Use ABI tags instead of internal linkage to provide per-TU insulation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2e86866be0f: [libc++] Re-apply the use of ABI tags to provide per-TU insulation (authored by ldionne). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

dyung added subscribers: Orlando, dyung. dyung added a comment. Hi @zequanwu, your change is causing a test failure in the cross-project-test suite on the PS4 linux bot. Can you take a look and revert if you need time to investigate? https://lab.llvm.org/buildbot/#/builders/217/builds/7945 a

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

phosek added inline comments. Comment at: llvm/cmake/modules/FindZSTD.cmake:1 +# Copyright (c) Meta Platforms, Inc. and affiliates. +# MaskRay wrote: > How did you derive this? > > The file seems contributed by you (I don't think facebook/zstd has such a > file

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added a comment. Consider adding `have_zstd` to `compiler-rt/test/lit.common.cfg.py` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ lldb-commits ma

[Lldb-commits] [PATCH] D127444: [libc++] Use ABI tags instead of internal linkage to provide per-TU insulation

ldionne updated this revision to Diff 443066. ldionne added a comment. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Band-aid for the LLDB issue, and also include 6148c79a in the comm

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM although I think I'd be more comfortable with Petr's +2 for cmake changes. Would it be better instead to expose `LLVM_ENABLE_ZSTD` to subrepos like clangd or flang until they're

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 443035. ckissane added a comment. start breaking this up further, this is now the add cmake config patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: cla

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane marked 2 inline comments as done. ckissane added a comment. mark outdated comments done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 ___ lldb-commit

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay accepted this revision. MaskRay added a comment. Please check both `LLVM_ENABLE_ZSTD={on,off}` work. Ideally, check that when zstd' cmake (`libzstd-dev` on Debian) is unavailable, `LLVM_ENABLE_ZSTD=on` works (there is no zstd functionality but the cmake invocation should succeed). ===

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. Thanks for this patch Guy. As just discussed in the RISC-V sync-up call, it would be helpful from a review perspective to write down at least a simple plain-text description of the changes to the psABI doc needed to reflect the BE ABI implemented by GCC (and soon LLVM), per

[Lldb-commits] [PATCH] D128166: ManagedStatic: Destroy from destructor

nhaehnle added a comment. Herald added a subscriber: anlunx. Abandoning this in favor of removing ManagedStatic entirely via the stack of changes that ends in D129134 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster abandoned this revision. treapster added a comment. Abandoning because @MaskRay already implemented it in D128029 and D128030 . Thanks for your time, @MaskRay! Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D129131: Remove uses of llvm_shutdown

nhaehnle created this revision. nhaehnle added reviewers: efriedma, lattner. Herald added a reviewer: bollu. Herald added subscribers: anlunx, bzcheeseman, ayermolo, sdasgup3, wenzhicui, wrengr, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, jvesely, Joons

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. > I currently don't quite understand how to configure the build bot, and how to > set the test configuration, I went through this article but didn't find > useful information for me, could someone help me. Start with https://llvm.org/docs/HowToAddABuilder.html ins

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer marked 8 inline comments as done. Emmmer added a comment. > Minor thing but if you call this in the constructor it's one less place to = > false all the things. It is a virtual function so I decided not to call it from the constructor. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer updated this revision to Diff 442006. Emmmer added a comment. - Format the standard llvm header. - add `RegisterContextPOSIX_riscv64.cpp` and `RegisterContextPOSIX_riscv64.h` - add Floating-Point Register support. > I wouldn't say that the presence of a buildbot is an absolute requirement

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

labath added a comment. In D128250#3598291 , @Emmmer wrote: > In D128250#3598223 , @DavidSpickett > wrote: > >> I'll give this a more thorough read later just one comment for now. >> >> In the meantime, what's yo

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei updated this revision to Diff 441410. gbenyei added a comment. Removed LLD and JIT related parts - JIT is out of my scope, and LLD will be in an additional patch. Fixed additional remarks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12861

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei marked 3 inline comments as done. gbenyei added inline comments. Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:554 .buildGraph(); - } else { -assert((*ELFObj)->getArch() == Triple::riscv32 && - "Invalid triple for RISCV ELF object file

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei marked 3 inline comments as done. gbenyei added a comment. In D128612#3620911 , @MaskRay wrote: > In D128612#3618167 , @gbenyei wrote: > >> In D128612#3617955 , @M

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

MaskRay added inline comments. Comment at: llvm/cmake/modules/FindZSTD.cmake:1 +# Copyright (c) Meta Platforms, Inc. and affiliates. +# How did you derive this? The file seems contributed by you (I don't think facebook/zstd has such a file). It should not have

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

MaskRay added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.h:144 + +StringRef LayoutEndianness = Triple.isLittleEndian() ? "e" : "E"; + gbenyei wrote: > MaskRay wrote: > > You may use a `char` and possibly fold this into the expression below. >

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

liaolucy added a comment. Thanks all. Command: -DLLVM_ENABLE_PROJECTS="clang;lldb;lld" , it works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128250/new/ https://reviews.llvm.org/D128250 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 441102. ckissane added a comment. add AlgorithmName to compression namespaces CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-extra/clangd/te

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 441114. ckissane edited the summary of this revision. ckissane added a comment. - feat: add zstd compression - Merge branch 'ckissane.refactor-compression-namespace' into ckissane.add-zstd-compression - Merge branch 'ckissane.refactor-compression-namespace'

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

MaskRay added a comment. In D128612#3618167 , @gbenyei wrote: > In D128612#3617955 , @MaskRay wrote: > >> lld/ELF change should be dropped from this change. Don't use >> `config->endianness`. >> I feel sad that f

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei added a comment. In D128612#3617906 , @jhenderson wrote: > Objcopy aspects look good, thanks. Thanks Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_riscv.cpp:554 .buildGraph(); - } else { -assert((*ELFObj)->ge

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

gbenyei added a comment. In D128612#3617955 , @MaskRay wrote: > lld/ELF change should be dropped from this change. Don't use > `config->endianness`. > I feel sad that for little-endian users who don't use big-endian, every write > now is slightly slower

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

DavidSpickett added a comment. FWIW I do get the same error in a clean directory without this patch applied: -- LLDB version: 15.0.0git CMake Error at /home/david.spickett/llvm-project/lldb/cmake/modules/LLDBConfig.cmake:289 (message): Expected directory for clang-resource headers not f

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

jhenderson added a comment. Objcopy aspects look good, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128612/new/ https://reviews.llvm.org/D128612 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D128612: RISC-V big-endian support implementation

MaskRay added a comment. lld/ELF change should be dropped from this change. Don't use `config->endianness`. I feel sad that for little-endian users who don't use big-endian, every write now is slightly slower due to a check ;-) Comment at: clang/lib/Basic/Targets/RISCV.cpp:12

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer added a comment. In D128250#3617409 , @liaolucy wrote: > I try to build lldb with the patch, but fail: > > The environment： > > cat /proc/cpuinfo > processor : 0 > hart: 2 > isa : rv64imafdc > mmu

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

liaolucy added a comment. In D128250#3617617 , @Emmmer wrote: > In D128250#3617409 , @liaolucy > wrote: > >> I try to build lldb with the patch, but fail: >> >> The environment： >> >> cat /proc/cpuinfo >> pr

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

liaolucy added a comment. I try to build lldb with the patch, but fail: The environment： cat /proc/cpuinfo processor : 0 hart: 2 isa : rv64imafdc mmu : sv39 uarch : sifive,u74-mc llvm commit: d1b098fc

[Lldb-commits] [PATCH] D128465: Zstandard as a second compression method to LLVM

ckissane updated this revision to Diff 440747. ckissane edited the summary of this revision. ckissane added a comment. make it the second stage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[Lldb-commits] [lldb] 77a38f6 - jGetLoadedDynamicLibrariesInfos can inspect machos not yet loaded

Author: Jason Molenda Date: 2022-07-08T15:13:49-07:00 New Revision: 77a38f6839980bfac61babb40d83772c51427011 URL: https://github.com/llvm/llvm-project/commit/77a38f6839980bfac61babb40d83772c51427011 DIFF: https://github.com/llvm/llvm-project/commit/77a38f6839980bfac61babb40d83772c51427011.diff

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

This revision was automatically updated to reflect the committed changes. Closed by commit rG77a38f683998: jGetLoadedDynamicLibrariesInfos can inspect machos not yet loaded (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://reviews.llvm.org/D128069 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 443360. persona0220 marked 8 inline comments as done. persona0220 added a comment. Added a struct `InstructionOpcodeAndModrm`, which contains primary_opcode, opcode_len and modrm bytes decoded from `InstructionLengthDecode` function. CHANGES SINCE LAST

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

jasonmolenda updated this revision to Diff 443345. jasonmolenda added a comment. Final small patch revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128956/new/ https://reviews.llvm.org/D128956 Files: lldb/test/API/macosx/unregistered-mach

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

dmlary marked 2 inline comments as done. dmlary added a comment. @JDevlieghere if I'm reading this right, yours is the last approval this review needs. Is there anything else you would like to be updated in this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. almost there! I like the tests btw :) Comment at: lldb/source/Commands/Options.td:304 + def disassemble_options_kind : Option<"kind", "k">, +Desc<"Show instr

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:749 +static bool mach_header_validity_test (uint32_t magic, uint32_t cputype) { + if (magic != MH_MAGIC && magic != MH_CIGAM && magic != MH

[Lldb-commits] [PATCH] D50304: [lldb] Fix thread step until to not set breakpoint(s) on incorrect line numbers

RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50304/new/ https://reviews.llvm.org/D50304 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

persona0220 updated this revision to Diff 443281. persona0220 marked 4 inline comments as done. persona0220 added a comment. Herald added a subscriber: mgorny. - Delete PTI_MAP enum and use opcode_len instead. - Add a unit test - Divide existing Disassembler test into x86 / ARM subdirectory -

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova created this revision. cassanova added reviewers: JDevlieghere, mib. cassanova added a project: LLDB. Herald added a subscriber: mgorny. Herald added a project: All. cassanova requested review of this revision. Herald added a subscriber: lldb-commits. This commit adds a fuzzer for LLDB's

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 updated this revision to Diff 443227. Michael137 added a comment. - Cleaned up documentation further Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129364/new/ https://reviews.llvm.org/D129364 Files: lldb/source/Plugins/Language/CPlusP

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Michael137 added a comment. One potential functional change here would be the removal of `GetFullCompilerType` in the `$__lldb_objc_class` code path. Could probably just put it back since it's not immediately obvious how I'd test it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [lldb] d2e8686 - [libc++] Re-apply the use of ABI tags to provide per-TU insulation

Author: Louis Dionne Date: 2022-07-08T08:38:36-04:00 New Revision: d2e86866be0f17295c5f677333c2a9952e259dd7 URL: https://github.com/llvm/llvm-project/commit/d2e86866be0f17295c5f677333c2a9952e259dd7 DIFF: https://github.com/llvm/llvm-project/commit/d2e86866be0f17295c5f677333c2a9952e259dd7.diff

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Michael137 created this revision. Michael137 added reviewers: jingham, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This member variable was removed a while ago in 443427357f539f5ac97e664a

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 updated this revision to Diff 443212. Michael137 added a comment. - Fixed class documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129364/new/ https://reviews.llvm.org/D129364 Files: lldb/source/Plugins/Language/CPlusPlus/CPl

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 created this revision. Michael137 added reviewers: aprantl, jingham. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a formatter for libcxx's `std::unordered_map` iterators.

[Lldb-commits] [lldb] 132d711 - [lldb/test] Disable TestStringLiteralExpr.test on Windows

Author: serge-sans-paille Date: 2022-07-08T12:17:31+02:00 New Revision: 132d711554cbb3db0b0efd1e88d2acb9278b6be9 URL: https://github.com/llvm/llvm-project/commit/132d711554cbb3db0b0efd1e88d2acb9278b6be9 DIFF: https://github.com/llvm/llvm-project/commit/132d711554cbb3db0b0efd1e88d2acb9278b6be9.d

[Lldb-commits] [PATCH] D129338: Tell the user which pathname was invalid...

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:2640 if (!pathname || !pathname[0]) { -error.SetErrorString("invalid pathname"); +error.SetErrorString("empty path"); return false; -

[Lldb-commits] [PATCH] D128956: make debugserver able to inspect mach-o binaries present in memory, but not yet registered with dyld

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Looks good from my perspective. Comment at: lldb/test/API/macosx/unregistered-macho/main.c:48 + memcpy(p, &uuid, sizeof(uuid)); + p += sizeof(uuid); + ---

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

This revision was automatically updated to reflect the committed changes. Closed by commit rGb042d15d2e39: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test (authored by jchecahi, committed by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [lldb] b042d15 - [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

Author: Jesus Checa Hidalgo Date: 2022-07-08T10:01:07+02:00 New Revision: b042d15d2e39eea528c51a30fe637b9ea84250d3 URL: https://github.com/llvm/llvm-project/commit/b042d15d2e39eea528c51a30fe637b9ea84250d3 DIFF: https://github.com/llvm/llvm-project/commit/b042d15d2e39eea528c51a30fe637b9ea84250d3

[Lldb-commits] [PATCH] D129261: [lldb/test] Add Shell/Expr/TestStringLiteralExpr.test

serge-sans-paille added a comment. I checked the test base and didn't find any similar test either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129261/new/ https://reviews.llvm.org/D129261 ___ lldb-com