[Lldb-commits] [PATCH] D125154: [lldb] Specify aguments of `image list`

kastiglione created this revision. kastiglione added reviewers: aprantl, jingham. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Register positional argument details in `CommandObjectTargetModulesLi

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

kastiglione added inline comments. Comment at: lldb/examples/python/cont_to_bkpt.py:5-6 +def __init__(self, debugger, unused): +self.dbg = debugger +self.interp = debugger.GetCommandInterpreter() + Are these properties needed by lldb?

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

kastiglione added inline comments. Comment at: lldb/examples/python/cont_to_bkpt.py:21 + +if len(bkpt_ids) == 0: +result.SetError("No breakpoint to run to") can also be `if not bkpt_ids:` Comment at: lldb/examples/python/con

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

kastiglione added inline comments. Comment at: lldb/examples/python/cont_to_bkpt.py:13 +try: +int_val = int(str) +except: is it worth supporting named breakpoints in addition to IDs Comment at: lldb/examp

[Lldb-commits] [PATCH] D125148: Add an example command that runs to one of a set of breakpoints

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In a situation where you have a lot of breakpoints set, some enabled and

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. In D124731#3498195 , @hawkinsw wrote: > (for real) Updating the patch based on helpful feedback from @jingham. I used to know better how to make sure that phabricator notified people that the commit was updated based on their f

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw updated this revision to Diff 427794. hawkinsw added a comment. (for real) Updating the patch based on helpful feedback from @jingham. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 Files: lld

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw updated this revision to Diff 427791. hawkinsw added a comment. Updated patch including responses to helpful feedback from @jingham. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 Files: lldb/

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1873-1875 + if (message.size() + prefix_width + suffix_width >= term_width) +message.erase(message.begin() + term_width - prefix_width - suffix_width, + message.end()); ---

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib updated this revision to Diff 427692. mib added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124785/new/ https://reviews.llvm.org/D124785 Files: lldb/include/lldb/Core/DebuggerEvents.h lldb/source/Core/Debugger.cpp lldb/test/API/functionalities/progress_

[Lldb-commits] [PATCH] D125107: [lldb] Parallelize fetching symbol files in crashlog.py

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Very cool! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125107/new/ https://reviews.llvm.org/D125107 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D125107: [lldb] Parallelize fetching symbol files in crashlog.py

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:272 if self.show_symbol_progress(): -print('Getting symbols for %s %s...\n' % (uuid_str, self.path), end=' ') +print('Getting symbols for %s %s...' % (uu

[Lldb-commits] [PATCH] D125107: [lldb] Parallelize fetching symbol files in crashlog.py

JDevlieghere created this revision. JDevlieghere added reviewers: mib, clayborg. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. When using dsymForUUID, the majority of time symbolication a crashlog with crashlog.py is spent w

[Lldb-commits] [lldb] 6ed81ab - Fix LLDB test broken by 499d0b96cb52c828e7fc4d58825b5e8b3f9931c5

Author: Sam McCall Date: 2022-05-06T17:09:02+02:00 New Revision: 6ed81abec2531984e8068de80637bc9f5a041655 URL: https://github.com/llvm/llvm-project/commit/6ed81abec2531984e8068de80637bc9f5a041655 DIFF: https://github.com/llvm/llvm-project/commit/6ed81abec2531984e8068de80637bc9f5a041655.diff LO

[Lldb-commits] [PATCH] D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

sammccall added a comment. Sorry, bad merge and this broke everything. Fixed in f44552ab387b9087fb815251064782f8fb60e643 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125012/new/ https://reviews.llvm.org/D125012 ___

[Lldb-commits] [PATCH] D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG499d0b96cb52: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC (authored by sammccall). Changed prior to commit: ht

[Lldb-commits] [lldb] 499d0b9 - [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

Author: Sam McCall Date: 2022-05-06T16:21:48+02:00 New Revision: 499d0b96cb52c828e7fc4d58825b5e8b3f9931c5 URL: https://github.com/llvm/llvm-project/commit/499d0b96cb52c828e7fc4d58825b5e8b3f9931c5 DIFF: https://github.com/llvm/llvm-project/commit/499d0b96cb52c828e7fc4d58825b5e8b3f9931c5.diff LO

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

DavidSpickett updated this revision to Diff 427612. DavidSpickett added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125090/new/ https://reviews.

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

DavidSpickett added a comment. The logic for handling misalignment is all done in DumpDataExtractor so that is covered by the "memory read --show-tags" tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125090/new/ https://reviews.llvm.org/D1250

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

DavidSpickett updated this revision to Diff 427609. DavidSpickett added a comment. Test that show-tags without finding anything doesn't do anything strange. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125090/new/ https://reviews.llvm.org/D125090

[Lldb-commits] [PATCH] D125089: [lldb] Change implementation of memory read --show-tags option

DavidSpickett added a reviewer: omjavaid. DavidSpickett added a comment. I did try to add the option via Options.td but adding a multi character short option there doesn't seem to work. I could enable that but it seems like just as much work to make an option group for it. Repository: rG LLV

[Lldb-commits] [PATCH] D125090: [lldb] Add --show-tags option to "memory find"

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is off by default. If you get a result and that memory has memory tags, when --show-tags is given you'll se

[Lldb-commits] [PATCH] D125089: [lldb] Change implementation of memory read --show-tags option

DavidSpickett created this revision. Herald added a subscriber: mgorny. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This does 2 things: - Moves it after the short options. Which makes sense gi

[Lldb-commits] [PATCH] D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125012/new/ https://reviews.llvm.org/D125012 __

[Lldb-commits] [lldb] 0dfafa4 - [lldb] Correct hex digit regex in some tests

Author: David Spickett Date: 2022-05-06T09:28:21Z New Revision: 0dfafa489230061cdde39d9e7294bb61d23f1064 URL: https://github.com/llvm/llvm-project/commit/0dfafa489230061cdde39d9e7294bb61d23f1064 DIFF: https://github.com/llvm/llvm-project/commit/0dfafa489230061cdde39d9e7294bb61d23f1064.diff LOG