[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. One nit that you can choose to fix if desired Comment at: lldb/source/Target/Platform.cpp:1229-1230 + + if (archs.empty()) +return nullptr; + ---

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere updated this revision to Diff 419005. JDevlieghere edited the summary of this revision. JDevlieghere added a comment. Change the algorithm to pick the selected/host platform if it matches at least one architecture. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122684/new/

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1277-1279 + // Prefer the selected platform if it matches all architectures. + if (selected_platform_matches_all_archs) +return selected_platform_sp; clayborg wrote: > JDevliegh

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

clayborg added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:103 + static lldb::PlatformSP + GetPlatformForArchitectures(std::vector archs, + const ArchSpec &process_host_arch, Comment at: lldb

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. In D122684#3415303 , @clayborg wrote: > So this will fix LLDB complaining when a binary contains arm64 and x86_64 > when debugging on either platform? Great, we ran into this qu

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

aprantl added inline comments. Comment at: lldb/source/Target/Platform.cpp:1228 + platforms.erase(std::unique(platforms.begin(), platforms.end()), + platforms.end()); +} aprantl wrote: > would std::unique be more idiomatic? Not sure why I didn't

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Target/Platform.cpp:1277-1279 + // Prefer the selected platform if it matches all architectures. + if (selected_platform_matches_all_archs) +return selected_platform_s

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

aprantl added inline comments. Comment at: lldb/include/lldb/Target/Platform.h:102 + static lldb::PlatformSP + GetPlatformForArchitectures(std::vector archs, Would you mind adding a doxygen comment for this? I'm asking because the semantics are not clear to

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

clayborg added a comment. So this will fix LLDB complaining when a binary contains arm64 and x86_64 when debugging on either platform? Great, we ran into this quite a bit lately! Comment at: lldb/source/Target/Platform.cpp:1277-1279 + // Prefer the selected platform if it mat

[Lldb-commits] [lldb] 8991ad4 - [lldb] Make ModuleSpecList iterable (NFC)

Author: Jonas Devlieghere Date: 2022-03-29T15:26:54-07:00 New Revision: 8991ad43ffc56420dda6c797811b2bababe842da URL: https://github.com/llvm/llvm-project/commit/8991ad43ffc56420dda6c797811b2bababe842da DIFF: https://github.com/llvm/llvm-project/commit/8991ad43ffc56420dda6c797811b2bababe842da.d

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 418981. zrthxn added a comment. Prevent crash on printing info when we have 0 instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files: lldb/source/Plugins

[Lldb-commits] [PATCH] D121844: Applying clang-tidy modernize-use-equals-default over LLDB

shafik marked 2 inline comments as done. shafik added inline comments. Comment at: lldb/source/Core/Value.cpp:667 -const ValueList &ValueList::operator=(const ValueList &rhs) { +const ValueList &ValueList::operator=(const ValueList &rhs) { // NOLINT(modernize-use-equals-defau

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 418977. zrthxn added a comment. Update memory calc function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Files: lldb/source/Plugins/Trace/intel-pt/DecodedThread.c

[Lldb-commits] [PATCH] D122603: [intelpt] Refactor timestamps out of IntelPTInstruction

zrthxn updated this revision to Diff 418975. zrthxn marked 7 inline comments as done. zrthxn retitled this revision from "[wip][intelpt] Refactor timestamps out of `IntelPTInstruction`" to "[intelpt] Refactor timestamps out of IntelPTInstruction". zrthxn added a comment. Change TscRange to class

[Lldb-commits] [PATCH] D122684: [lldb] Use the selected and host platform to disambiguate between fat binary architectures

JDevlieghere created this revision. JDevlieghere added reviewers: labath, jingham, clayborg, jasonmolenda. Herald added subscribers: mgrang, mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Currently we error out if multiple platforms can supports the architectu

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/OnDemand/shared-lib-globals-hydration.test:4 + +# REQUIRES: system-linux + yinghuitan wrote: > labath wrote: > > yinghuitan wrote: > > > labath wrote: > > > > Is this here because there is no p

[Lldb-commits] [lldb] dfde354 - NFC. Fixing warnings from adding DXContainer

Author: Chris Bieneman Date: 2022-03-29T14:46:24-05:00 New Revision: dfde354958ca49138349e1428bf2fc0414a73a43 URL: https://github.com/llvm/llvm-project/commit/dfde354958ca49138349e1428bf2fc0414a73a43 DIFF: https://github.com/llvm/llvm-project/commit/dfde354958ca49138349e1428bf2fc0414a73a43.diff

[Lldb-commits] [PATCH] D122680: Add a setting to force overwriting commands in "command script add"

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When I added containers it seemed like it would be easier to accidentally overwrite

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan added inline comments. Comment at: lldb/test/Shell/SymbolFile/OnDemand/shared-lib-globals-hydration.test:4 + +# REQUIRES: system-linux + labath wrote: > yinghuitan wrote: > > labath wrote: > > > Is this here because there is no portable way to create

[Lldb-commits] [PATCH] D122603: [wip][intelpt] Refactor timestamps out of `IntelPTInstruction`

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. I'm proposing a new interface for the TscRange. Let me know if you have questions Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:95 + m_instru

[Lldb-commits] [PATCH] D122603: [wip][intelpt] Refactor timestamps out of `IntelPTInstruction`

zrthxn updated this revision to Diff 418937. zrthxn marked 12 inline comments as done. zrthxn added a comment. Introduced TscRange for quicker operation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122603/new/ https://reviews.llvm.org/D122603 Fil

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/OnDemand/shared-lib-globals-hydration.test:4 + +# REQUIRES: system-linux + yinghuitan wrote: > labath wrote: > > Is this here because there is no portable way to create shared libraries in > >

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

yinghuitan marked an inline comment as done. yinghuitan added inline comments. Comment at: lldb/test/Shell/SymbolFile/OnDemand/shared-lib-globals-hydration.test:4 + +# REQUIRES: system-linux + labath wrote: > Is this here because there is no portable way to crea

[Lldb-commits] [lldb] 13a3b0b - [lldb] Remove usages of case-insensitive c-string functions

Author: Pavel Labath Date: 2022-03-29T17:59:17+02:00 New Revision: 13a3b0bb4b64fea08f26c654b7a810f9ca217c7a URL: https://github.com/llvm/llvm-project/commit/13a3b0bb4b64fea08f26c654b7a810f9ca217c7a DIFF: https://github.com/llvm/llvm-project/commit/13a3b0bb4b64fea08f26c654b7a810f9ca217c7a.diff

[Lldb-commits] [PATCH] D122660: [lldb] Avoid duplicate vdso modules when opening core files

labath created this revision. labath added reviewers: mgorny, clayborg, JDevlieghere. Herald added subscribers: pmatos, asb, sunfish, sbc100. Herald added a project: All. labath requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: LLDB. When opening core f

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

labath added a comment. In D121631#3387077 , @clayborg wrote: > In D121631#3386244 , @labath wrote: > >> In D121631#3384124 , @yinghuitan >> wrote: >> unify with `ta