[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 417832. zrthxn added a comment. A few changes to remove redundant things Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace/intel-pt/De

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp:149 +thread.AppendError(insn_index, make_error(time_error, insn.ip)); +thread.AppendInstruction(IntelPTInstruction(insn)); break; zrthxn wro

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn marked 8 inline comments as done. zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/IntelPTDecoder.cpp:149 +thread.AppendError(insn_index, make_error(time_error, insn.ip)); +thread.AppendInstruction(IntelPTInstruction(insn));

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 417828. wallace added a comment. nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.org/D122254 Files: lldb/include/lldb/Target/TraceCursor.h lldb/include/lldb/Target/Trace

[Lldb-commits] [PATCH] D122254: [trace][intelpt] Introduce instruction Ids

wallace updated this revision to Diff 417827. wallace added a comment. - improve documentation - use lldb::user_id_t - add the new TraceInstructionDumperOptions struct Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122254/new/ https://reviews.llvm.o

[Lldb-commits] [lldb] 4ad19b8 - [lldb] Test parsing the symtab with indirect symbols from the shared cache

Author: Jonas Devlieghere Date: 2022-03-23T21:13:55-07:00 New Revision: 4ad19b80eafa1505b8bb86eef84ffefcd20410a3 URL: https://github.com/llvm/llvm-project/commit/4ad19b80eafa1505b8bb86eef84ffefcd20410a3 DIFF: https://github.com/llvm/llvm-project/commit/4ad19b80eafa1505b8bb86eef84ffefcd20410a3.d

[Lldb-commits] [PATCH] D122041: [llvm][utils] Fix llvm::Optional summary provider

aprantl added a comment. We don't at the moment. We could add a test to the LLDB testsuite that compiles a test program against Support. There's some CMake trickery necessary for this, which is probably why we've shied away from it thus far. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D122347: Expose GetAddressingBits() in the Process API

aprantl added a comment. This turned out to be unnecessary, because Process already exposes this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122347/new/ https://reviews.llvm.org/D122347 ___ lldb-commi

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

wallace requested changes to this revision. wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.cpp:103-105 +std::unordered_map DecodedThread::GetErrors() const { + return m_errors; +} remove this Commen

[Lldb-commits] [lldb] 9a8a0a3 - Load dyld manually with 'main bin spec' userland corefiles

Author: Jason Molenda Date: 2022-03-23T17:12:17-07:00 New Revision: 9a8a0a38613ae190740923a7dcdf381a1b6fc55e URL: https://github.com/llvm/llvm-project/commit/9a8a0a38613ae190740923a7dcdf381a1b6fc55e DIFF: https://github.com/llvm/llvm-project/commit/9a8a0a38613ae190740923a7dcdf381a1b6fc55e.diff

[Lldb-commits] [lldb] b0dc2fa - [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset

Author: Jonas Devlieghere Date: 2022-03-23T16:39:53-07:00 New Revision: b0dc2fae602579114525353c8403d6e6d128ad73 URL: https://github.com/llvm/llvm-project/commit/b0dc2fae602579114525353c8403d6e6d128ad73 DIFF: https://github.com/llvm/llvm-project/commit/b0dc2fae602579114525353c8403d6e6d128ad73.d

[Lldb-commits] [PATCH] D122349: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0dc2fae6025: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D122025: [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0f1f3b95cd5: [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [lldb] a765f2a - [lldb] Support class_ro_t pointer authentication

Author: Jonas Devlieghere Date: 2022-03-23T16:19:49-07:00 New Revision: a765f2a04460c5a8b814382ff969a8085e36269b URL: https://github.com/llvm/llvm-project/commit/a765f2a04460c5a8b814382ff969a8085e36269b DIFF: https://github.com/llvm/llvm-project/commit/a765f2a04460c5a8b814382ff969a8085e36269b.d

[Lldb-commits] [lldb] b0f1f3b - [lldb] Remove lldbassert from CommandInterpreter::PrintCommandOutput

Author: Jonas Devlieghere Date: 2022-03-23T16:19:50-07:00 New Revision: b0f1f3b95cd5f3e951e316fea39feca9a2878942 URL: https://github.com/llvm/llvm-project/commit/b0f1f3b95cd5f3e951e316fea39feca9a2878942 DIFF: https://github.com/llvm/llvm-project/commit/b0f1f3b95cd5f3e951e316fea39feca9a2878942.d

[Lldb-commits] [PATCH] D122349: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ah, good catch. Yes this looks correct to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122349/new/ https://reviews.llvm.org/D122349

[Lldb-commits] [PATCH] D122349: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset

JDevlieghere added a comment. PS: I don't think we should ever parse the symbol table more than onceafter D114288 , but this patch is still the right thing to do imho. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122349/new/ https://reviews.llvm.org/

[Lldb-commits] [lldb] 12606d1 - Revert "Expose GetAddressingBits() in the Process API."

Author: Adrian Prantl Date: 2022-03-23T15:28:34-07:00 New Revision: 12606d16bc3e1c75eefc781863b199b930137068 URL: https://github.com/llvm/llvm-project/commit/12606d16bc3e1c75eefc781863b199b930137068 DIFF: https://github.com/llvm/llvm-project/commit/12606d16bc3e1c75eefc781863b199b930137068.diff

[Lldb-commits] [PATCH] D122347: Expose GetAddressingBits() in the Process API

kastiglione added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:216 +llvm::Optional ProcessGDBRemote::GetAddressingBits() { + return m_gdb_comm.GetAddressingBits(); +} Thought: should this API return a mask instead? R

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added a comment. > Can you say (in english) what are the properties that you are trying to check > there? Maybe we can find a better way to do that... I'm trying to check for local variables values in inline functions by printing them (see inline comment on `PdbAstBuilder::ParseBlockCh

[Lldb-commits] [PATCH] D122347: Expose GetAddressingBits() in the Process API

This revision was automatically updated to reflect the committed changes. Closed by commit rG7504dd5e00f5: Expose GetAddressingBits() in the Process API. (authored by aprantl). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [lldb] 7504dd5 - Expose GetAddressingBits() in the Process API.

Author: Adrian Prantl Date: 2022-03-23T14:22:26-07:00 New Revision: 7504dd5e00f514628614db8ee07514c73220e597 URL: https://github.com/llvm/llvm-project/commit/7504dd5e00f514628614db8ee07514c73220e597 DIFF: https://github.com/llvm/llvm-project/commit/7504dd5e00f514628614db8ee07514c73220e597.diff

[Lldb-commits] [PATCH] D122347: Expose GetAddressingBits() in the Process API

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122347/new/ https://reviews.llvm.org/D122347 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D122349: [lldb] Don't persist the LINKEDIT slide in the indirect symbol offset

JDevlieghere created this revision. JDevlieghere added reviewers: friss, jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. The current code increment the indirect symbol offset with the LINKEDIT slide every time `ObjectFileMachO::ParseSymtab` is called. Th

[Lldb-commits] [PATCH] D122347: Expose GetAddressingBits() in the Process API

aprantl created this revision. aprantl added reviewers: JDevlieghere, jasonmolenda. Herald added a project: All. aprantl requested review of this revision. See https://github.com/apple/llvm-project/pull/4110 for motivation and context. https://reviews.llvm.org/D122347 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:152 + /// The errors of the trace. + std::unordered_map GetErrors() const; + jj10306 wrote: > Return a reference here to avoid potential expensive copy when returning

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

jj10306 added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:152 + /// The errors of the trace. + std::unordered_map GetErrors() const; + Return a reference here to avoid potential expensive copy when returning. Something els

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:172 std::vector m_instructions; + std::vector m_errors; + jj10306 wrote: > wallace wrote: > > you need to have something like > > std::unordered_map m_errors; > >

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:172 std::vector m_instructions; + std::vector m_errors; + wallace wrote: >

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

labath added a comment. In D121967#3400827 , @zequanwu wrote: >> I'd consider writing the live test case in c++ (with judicious use of >> always_inline, noinline, etc. attributes) > > I think it's better to just add live test case on compiled `inline_sit

[Lldb-commits] [PATCH] D122193: [lldb/test] Add events listener helper function to lldbtest

This revision was automatically updated to reflect the committed changes. mib marked 2 inline comments as done. Closed by commit rG9216baf87d88: [lldb/test] Add events listener helper function to lldbtest (authored by mib). Changed prior to commit: https://reviews.llvm.org/D122193?vs=417474&id=

[Lldb-commits] [lldb] 9216baf - [lldb/test] Add events listener helper function to lldbtest

Author: Med Ismail Bennani Date: 2022-03-23T12:30:09-07:00 New Revision: 9216baf87d887b75d114e9621cf2ccfa0f19a386 URL: https://github.com/llvm/llvm-project/commit/9216baf87d887b75d114e9621cf2ccfa0f19a386 DIFF: https://github.com/llvm/llvm-project/commit/9216baf87d887b75d114e9621cf2ccfa0f19a386.

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew added a comment. It's easy to detect in the debugee as it can check which hardware capabilities are passed to it from the kernel. Another option could be to have a build tool that prints these capabilities and have the test decide based on it as they are identical on FreeBSD and Linux.

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn updated this revision to Diff 417709. zrthxn added a comment. Introduced unordered map for errors in DecodedThread Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122293/new/ https://reviews.llvm.org/D122293 Files: lldb/source/Plugins/Trace

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

labath added a comment. Can you detect it from inside the debugee? You could have it exit with some predefined error code if the feature is not available (and then skip the test based on that)... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12048

[Lldb-commits] [PATCH] D122283: [lldb] Add a Stream variant that escapes null bytes

labath added a comment. Although I can't say exactly what would be the problem with this, this seems like a strange thing to do, and I'm not aware of any other stream class which would handle nul (and _only_ nul) characters specially. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12228

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1124 + // Inlinee is the id index to the function id record that is inlined. + PdbTypeSymId func_id(inline_site.Inlinee, true); + // Look up the function decl by the id index

[Lldb-commits] [PATCH] D121967: [LLDB][NativePDB] Create inline function decls

zequanwu updated this revision to Diff 417701. zequanwu marked an inline comment as done. zequanwu added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121967/new/ https://reviews.llvm.org/D121967 Files: lldb/source/Pl

[Lldb-commits] [PATCH] D122193: [lldb/test] Add events listener helper function to lldbtest

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:1265 + +def fetch_next_event(test, listener, broadcaster, timeout=1): +"""Fetch one event from the listene

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:172 std::vector m_instructions; + std::vector m_errors; + you need to have something like std::unordered_map m_errors; that way, you'll be able to quickly look fo

[Lldb-commits] [lldb] 9a88c2b - [lldb] Fixup tagged pointers ISAs

Author: Jonas Devlieghere Date: 2022-03-23T09:59:34-07:00 New Revision: 9a88c2b639411db37ad6fb37d144702df52694e8 URL: https://github.com/llvm/llvm-project/commit/9a88c2b639411db37ad6fb37d144702df52694e8 DIFF: https://github.com/llvm/llvm-project/commit/9a88c2b639411db37ad6fb37d144702df52694e8.d

[Lldb-commits] [PATCH] D122283: [lldb] Add a Stream variant that escapes null bytes

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Nice! Thanks for doing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122283/new/ https://reviews.llvm.org/D122283 ___ lldb-commit

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew added a comment. In D120485#3343538 , @emaste wrote: > We need to make sure a test covers this as well, perhaps just enabling > lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py? I have a local change to use the test

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

emaste added inline comments. Herald added a project: All. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:128 + +#ifdef NT_ARM_ADDR_MASK + if (m_addr_mask_is_valid) andrew wrote: > emaste wrote: > > This `#define` is comi

[Lldb-commits] [lldb] a749e32 - Replace links to archived mailing lists by links to Discourse forums

Author: Danny Mösch Date: 2022-03-23T10:10:20-04:00 New Revision: a749e3295df4aee18a0ad723875a6501f30ac744 URL: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744 DIFF: https://github.com/llvm/llvm-project/commit/a749e3295df4aee18a0ad723875a6501f30ac744.diff L

[Lldb-commits] [lldb] 84caf73 - [lldb/docs] Fixed minor ugly links

Author: Alisamar Husain Date: 2022-03-23T13:00:18+05:30 New Revision: 84caf73c5287ab7ab32c669075133d3bcd719bf7 URL: https://github.com/llvm/llvm-project/commit/84caf73c5287ab7ab32c669075133d3bcd719bf7 DIFF: https://github.com/llvm/llvm-project/commit/84caf73c5287ab7ab32c669075133d3bcd719bf7.dif

[Lldb-commits] [PATCH] D122293: [wip][intelpt] Refactoring instruction decoding for flexibility

zrthxn created this revision. zrthxn added reviewers: wallace, jj10306. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Refactored (but not yet tested) version of the instruction decoding code Repositor