[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

This revision was automatically updated to reflect the committed changes. Closed by commit rG8271220a9981: [trace][intelpt] Instruction count in trace info (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122076/new/ https://revie

[Lldb-commits] [lldb] 8271220 - [trace][intelpt] Instruction count in trace info

Author: Alisamar Husain Date: 2022-03-20T11:28:16+05:30 New Revision: 8271220a9981d0cb3186e8fc25477f622ea5c2c9 URL: https://github.com/llvm/llvm-project/commit/8271220a9981d0cb3186e8fc25477f622ea5c2c9 DIFF: https://github.com/llvm/llvm-project/commit/8271220a9981d0cb3186e8fc25477f622ea5c2c9.dif

[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122076/new/ https://reviews.llvm.org/D122076

[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

zrthxn updated this revision to Diff 416756. zrthxn added a comment. Using arrow op and made it inline. I think creating a variable looks a bit better but this is fine too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122076/new/ https://reviews.

[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. just some minor details and good to go Comment at: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp:108 Optional raw_size = GetRawTraceSize(thread); + size

[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

zrthxn updated this revision to Diff 416736. zrthxn added a comment. Fix failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122076/new/ https://reviews.llvm.org/D122076 Files: lldb/source/Plugins/Trace/intel-pt/TraceIntelPT.cpp lldb/te

[Lldb-commits] [PATCH] D122076: [trace][intelpt] Instruction count in trace info

zrthxn created this revision. zrthxn added a reviewer: wallace. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Added a line to `thread trace dump info` results which shows total number of instructions e

[Lldb-commits] [PATCH] D122073: [docs] Fixed minor ordering issue

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bcc28b884ff: [docs] Fixed minor ordering issue (authored by zrthxn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122073/new/ https://reviews.llvm.org/D12

[Lldb-commits] [lldb] 1bcc28b - [docs] Fixed minor ordering issue

Author: Alisamar Husain Date: 2022-03-19T22:23:42+05:30 New Revision: 1bcc28b884ff4fbe2ecc011b8ea2b84e7987167b URL: https://github.com/llvm/llvm-project/commit/1bcc28b884ff4fbe2ecc011b8ea2b84e7987167b DIFF: https://github.com/llvm/llvm-project/commit/1bcc28b884ff4fbe2ecc011b8ea2b84e7987167b.dif

[Lldb-commits] [PATCH] D122073: [docs] Fixed minor ordering issue

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122073/new/ https://reviews.llvm.org/D122073 _

[Lldb-commits] [PATCH] D122073: [docs] Fixed minor ordering issue

zrthxn created this revision. zrthxn added a reviewer: wallace. Herald added a subscriber: arphaman. Herald added a project: All. zrthxn requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.

[Lldb-commits] [lldb] 752e9cd - [trace][intelpt][docs] Added intel-pt build instructions for lldb

Author: Alisamar Husain Date: 2022-03-19T15:26:59+05:30 New Revision: 752e9cdbb06affae5c082c31c4f5ea53e46e92c6 URL: https://github.com/llvm/llvm-project/commit/752e9cdbb06affae5c082c31c4f5ea53e46e92c6 DIFF: https://github.com/llvm/llvm-project/commit/752e9cdbb06affae5c082c31c4f5ea53e46e92c6.dif