[Lldb-commits] [PATCH] D121252: [lldb] Add SBType::IsAggregateType

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121252/new/ https://reviews.llvm.org/D121252 ___

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added a comment. In D120972#3369002 , @thakis wrote: > This breaks building on Windows where GetMessage is defined to GetMessageW: > http://45.33.8.238/win/54664/step_4.txt > > Please fix (just rename to something else), or revert for now if

[Lldb-commits] [PATCH] D121155: [lldb] Add --exists flag to `settings set`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a0fa4db39d8: [lldb] Add --exists flag to `settings set` (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D121155?vs=413615&id=414016#toc Repo

[Lldb-commits] [lldb] 8a0fa4d - [lldb] Add --exists flag to `settings set`

Author: Jonas Devlieghere Date: 2022-03-08T22:59:26-08:00 New Revision: 8a0fa4db39d862b99eb5d440a211c5c0228e13ce URL: https://github.com/llvm/llvm-project/commit/8a0fa4db39d862b99eb5d440a211c5c0228e13ce DIFF: https://github.com/llvm/llvm-project/commit/8a0fa4db39d862b99eb5d440a211c5c0228e13ce.d

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:455 +//}], +//"tsc_conversion"?: Optional<{ +// "kind": , The ? After the key name makes Optional<> redundant. Just keep the ? Comment at: lldb/docs/lldb-gdb-

[Lldb-commits] [lldb] e618eb8 - [lldb] A few small changes to HandleProgressEvent

Author: Jonas Devlieghere Date: 2022-03-08T20:27:40-08:00 New Revision: e618eb8727b0f9aebb54d48f6978c0bd3a4cf010 URL: https://github.com/llvm/llvm-project/commit/e618eb8727b0f9aebb54d48f6978c0bd3a4cf010 DIFF: https://github.com/llvm/llvm-project/commit/e618eb8727b0f9aebb54d48f6978c0bd3a4cf010.d

[Lldb-commits] [lldb] 43374be - [lldb] Undef GetMessage when including Windows.h

Author: Jonas Devlieghere Date: 2022-03-08T20:07:49-08:00 New Revision: 43374bee0e0641be417f22fc73c46a914de5ea71 URL: https://github.com/llvm/llvm-project/commit/43374bee0e0641be417f22fc73c46a914de5ea71 DIFF: https://github.com/llvm/llvm-project/commit/43374bee0e0641be417f22fc73c46a914de5ea71.d

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

thakis added a comment. This breaks building on Windows where GetMessage is defined to GetMessageW: http://45.33.8.238/win/54664/step_4.txt Please fix (just rename to something else), or revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

jj10306 updated this revision to Diff 413985. jj10306 marked 2 inline comments as done. jj10306 edited the summary of this revision. jj10306 added a comment. Addressed most of the previous diff's comments (other than the ones from @wallace and @davidca that were explicitly mentioned in my previou

[Lldb-commits] [lldb] 1167152 - [lldb] Always move the cursor back after printing progress

Author: Jonas Devlieghere Date: 2022-03-08T18:35:09-08:00 New Revision: 116715270d07d18d101ff8d1b4a42cfd76c5cc55 URL: https://github.com/llvm/llvm-project/commit/116715270d07d18d101ff8d1b4a42cfd76c5cc55 DIFF: https://github.com/llvm/llvm-project/commit/116715270d07d18d101ff8d1b4a42cfd76c5cc55.d

[Lldb-commits] [PATCH] D121062: [lldb] Add a setting to change the progress ANSI escape codes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG097d46f41c46: [lldb] Add a setting to change the progress color (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D121

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a27b99825a5: [lldb] Show progress events in the command line driver (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [lldb] 097d46f - [lldb] Add a setting to change the progress color

Author: Jonas Devlieghere Date: 2022-03-08T18:25:10-08:00 New Revision: 097d46f41c46a5e03bac673d264754628775b055 URL: https://github.com/llvm/llvm-project/commit/097d46f41c46a5e03bac673d264754628775b055 DIFF: https://github.com/llvm/llvm-project/commit/097d46f41c46a5e03bac673d264754628775b055.d

[Lldb-commits] [lldb] 5a27b99 - [lldb] Show progress events in the command line driver

Author: Jonas Devlieghere Date: 2022-03-08T18:24:26-08:00 New Revision: 5a27b99825a5ba3a7a2eec3d35aea381a3ba9a31 URL: https://github.com/llvm/llvm-project/commit/5a27b99825a5ba3a7a2eec3d35aea381a3ba9a31 DIFF: https://github.com/llvm/llvm-project/commit/5a27b99825a5ba3a7a2eec3d35aea381a3ba9a31.d

[Lldb-commits] [lldb] bfab18d - [lldb] Remove "(i.e. ANSI)" from several property descriptions.

Author: Jonas Devlieghere Date: 2022-03-08T18:24:24-08:00 New Revision: bfab18d86b2784364227631f51735fe17ee82b40 URL: https://github.com/llvm/llvm-project/commit/bfab18d86b2784364227631f51735fe17ee82b40 DIFF: https://github.com/llvm/llvm-project/commit/bfab18d86b2784364227631f51735fe17ee82b40.d

[Lldb-commits] [PATCH] D121062: [lldb] Add a setting to change the progress ANSI escape codes

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Core/CoreProperties.td:141 +DefaultStringValue<"${ansi.faint}">, +Desc<"When displaying progress in a color-enabled (i.e. ANSI) terminal

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

mib updated this revision to Diff 413972. mib marked an inline comment as done. mib added a comment. Use context manager pattern CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121038/new/ https://reviews.llvm.org/D121038 Files: lldb/examples/python/crashlog.py lldb/test/Shell/Script

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/examples/python/crashlog.py:1023-1024 + +async_state = debugger.GetAsync() +debugger.SetAsync(False) + JDevlieghere wrote: > This is the perfect pattern for a context manag

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

JDevlieghere added a comment. LGTM. I left a comment with a suggestion for a context manager but that's up to you. Comment at: lldb/examples/python/crashlog.py:1023-1024 + +async_state = debugger.GetAsync() +debugger.SetAsync(False) + This is the perf

[Lldb-commits] [PATCH] D121155: [lldb] Add --exists flag to `settings set`

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I suggested what seems to me a slightly clearer error message, but the added option seems useful. I wondered briefly about whether it might be better as a setting `settings set ignore-missi

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. In D120972#3368244 , @JDevlieghere wrote: > In D120972#3368055 , @jingham wrote: > >> In D120972#3368008

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

mib updated this revision to Diff 413943. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121038/new/ https://reviews.llvm.org/D121038 Files: lldb/examples/python/crashlog.py lldb/test/Shell/ScriptInterpreter/Python/Crashlog/scripted_crashlog_json.test Index: lldb/test/Shell/ScriptI

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

mib updated this revision to Diff 413941. mib added a comment. Change implementation to emulate lldb's driver Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121038/new/ https://reviews.llvm.org/D121038 Files: lldb/examples/python/crashlog.py ll

[Lldb-commits] [PATCH] D121252: [lldb] Add SBType::IsAggregateType

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add `IsAggregateType` to the SB API. I'd like to use this from tests, a

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

shafik added a comment. In D121161#3368117 , @JDevlieghere wrote: > In D121161#3367806 , @labath wrote: > >> The class has a constexpr constructor. I thought that would be enough to >> avoid runtime initializati

[Lldb-commits] [PATCH] D121131: [lldb] Support "bright" ANSI colors

aprantl added inline comments. Comment at: lldb/include/lldb/Utility/AnsiTerminal.h:12 + #define ANSI_FG_COLOR_BLACK 30 #define ANSI_FG_COLOR_RED 31 Nice! Should we convert this to enums? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D121226: [lldb] Removed scoped timer from ReadMemoryFromFileCache

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. These are not meant to be on hot code paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121226/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added a comment. In D120972#3368055 , @jingham wrote: > In D120972#3368008 , @clayborg > wrote: > >> This is fine as a starting point, my only question is if the setting should >> be "interpreter.sh

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

JDevlieghere added a comment. In D121161#3367806 , @labath wrote: > The class has a constexpr constructor. I thought that would be enough to > avoid runtime initialization. Is this being flagged by something? It is getting flagged by -Wglobal-constructo

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

jingham added a comment. In D120972#3368008 , @clayborg wrote: > This is fine as a starting point, my only question is if the setting should > be "interpreter.show-progress" Whether you see this output is really dependent on how the debugger's I/O is s

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

clayborg added a comment. This is fine as a starting point, my only question is if the setting should be "interpreter.show-progress" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 ___ lldb-commits

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

labath added a comment. The class has a constexpr constructor. I thought that would be enough to avoid runtime initialization. Is this being flagged by something? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121161/new/ https://reviews.llvm.org/D121161 ___

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

labath added a comment. It worked. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119797/new/ https://reviews.llvm.org/D119797 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3366825 , @aaron.ballman wrote: > In D121078#3366025 , @tonic wrote: > >> In D121078#3365542 , @SimplyDanny >> wrote: >> >>> In D121078

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3365542 , @SimplyDanny wrote: > In D121078#3363856 , @aaron.ballman > wrote: > >> I think we need to retain *some* references to the existing mailing list >> archives. The migr

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3366025 , @tonic wrote: > In D121078#3365542 , @SimplyDanny > wrote: > >> In D121078#3363856 , >> @aaron.ballman wrote: >> >>>

[Lldb-commits] [PATCH] D121168: Cleanup includes: LLVMTarget

RKSimon added a comment. Please add a reference to https://discourse.llvm.org/t/include-what-you-use-include-cleanup/5831 in the summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121168/new/ https://reviews.llvm.org/D121168

[Lldb-commits] [PATCH] D121168: Cleanup includes: LLVMTarget

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, RKSimon, lenary. Herald added subscribers: kerbowa, Jim, atanasyan, jrtc27, hiraditya, nhaehnle, jvesely, sdardis, dylanmckay. Herald added a project: All. serge-sans-paille requested review of this revision. Hera

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny updated this revision to Diff 413642. SimplyDanny added a comment. Removed duplicate target names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.llvm.org/D121078 Files: clang-tools-extra/README.txt clang

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. In D121078#3363856 , @aaron.ballman wrote: > I think we need to retain *some* references to the existing mailing list > archives. The migration to Discourse worked fairly well, but there were still > data migration issues.

[Lldb-commits] [PATCH] D121226: [lldb] Removed scoped timer from ReadMemoryFromFileCache

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `ReadMemoryFromFileCache` can be called at a high r

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

jj10306 marked 41 inline comments as done. jj10306 added a comment. Addressed comments locally, waiting to post update until the couple minor discussions with @wallace and @davidca in the comments are complete. Comment at: lldb/docs/lldb-gdb-remote.txt:469 +// +//tsc_rate:

[Lldb-commits] [lldb] de0b4f4 - [LLDB] Skip TestIOHandlerProcessSTDIO.py for Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2022-03-08T14:15:41+05:00 New Revision: de0b4f4b86fdba0c41723484221575c21bc24ab2 URL: https://github.com/llvm/llvm-project/commit/de0b4f4b86fdba0c41723484221575c21bc24ab2 DIFF: https://github.com/llvm/llvm-project/commit/de0b4f4b86fdba0c41723484221575c21bc24a