[Lldb-commits] [lldb] 94ec0b6 - Change "target.save-jit-objects" to "target.save-jit-objects-dir".

Author: Jim Ingham Date: 2022-03-07T17:44:51-08:00 New Revision: 94ec0b6c5ab8b5cd2f418f872ae2bbb2be3c550e URL: https://github.com/llvm/llvm-project/commit/94ec0b6c5ab8b5cd2f418f872ae2bbb2be3c550e DIFF: https://github.com/llvm/llvm-project/commit/94ec0b6c5ab8b5cd2f418f872ae2bbb2be3c550e.diff LO

[Lldb-commits] [PATCH] D121036: Fix target.save-jit-objects when the CWD is not writeable

This revision was automatically updated to reflect the committed changes. Closed by commit rG94ec0b6c5ab8: Change "target.save-jit-objects" to "target.save-jit-objects-dir". (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121036/

[Lldb-commits] [PATCH] D121036: Fix target.save-jit-objects when the CWD is not writeable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121036/new/ https://reviews.llvm.org/D121036 ___

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere added a comment. Thanks for the review Greg! Comment at: lldb/source/Core/CoreProperties.td:137 +DefaultTrue, +Desc<"Whether to show progress or not.">; def UseSourceCache: Property<"use-source-cache", "Boolean">, clayborg wrote: > Might

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

JDevlieghere updated this revision to Diff 413654. JDevlieghere marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120972/new/ https://reviews.llvm.org/D120972 Files: lldb/include/lldb/Core/Debugger.h lldb/source/Core/CoreProperties.td lldb/source/Core/

[Lldb-commits] [PATCH] D121036: Fix target.save-jit-objects when the CWD is not writeable

jingham updated this revision to Diff 413648. jingham added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121036/new/ https://reviews.llvm.org/D121036 Files: lldb/include/lldb/Interpreter/OptionValue.h lldb/

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

clayborg added inline comments. Comment at: lldb/source/Core/CoreProperties.td:137 +DefaultTrue, +Desc<"Whether to show progress or not.">; def UseSourceCache: Property<"use-source-cache", "Boolean">, Might be nice to clarify that this is for the CLI o

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

clayborg added a comment. I verified that my linux server was failing the attach in the same way and it is now fixed with the Buildbot patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120755/new/ https://reviews.llvm.org/D120755 __

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added inline comments. Comment at: clang/README.txt:22 If you have questions or comments about Clang, a great place to discuss them is -on the Clang development mailing list: - http://lists.llvm.org/mailman/listinfo/cfe-dev +in the Clang forum: + https://discourse.

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny updated this revision to Diff 413630. SimplyDanny marked 9 inline comments as done. SimplyDanny added a comment. Updated revision according to review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121078/new/ https://reviews.ll

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic requested changes to this revision. tonic added a comment. Thank you so much for doing this! I have added some comments inline that I would like changed. Comment at: clang/README.txt:22 If you have questions or comments about Clang, a great place to discuss them is -on

[Lldb-commits] [PATCH] D121161: [lldb] Avoid global constructor in LLDBLog.cpp

JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a project: All. JDevlieghere requested review of this revision. Avoid a static initializer for Log::Channel in LLDBLog.cpp https://reviews.llvm.org/D121161 Files: lldb/source/Utility/LLDBLog.cpp Index: l

[Lldb-commits] [PATCH] D121155: [lldb] Add --exists flag to `settings set`

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, jasonmolenda, mib. Herald added a subscriber: dang. Herald added a project: All. JDevlieghere requested review of this revision. Add a --exists/-e flag to `settings set` that sets the setting if it exists, but doesn't print

[Lldb-commits] [lldb] 4b093cd - [lldb] Format g_color_tokens as a table (NFC)

Author: Jonas Devlieghere Date: 2022-03-07T12:13:38-08:00 New Revision: 4b093cdc2886654d8a4fc308dfbb64644e137d2e URL: https://github.com/llvm/llvm-project/commit/4b093cdc2886654d8a4fc308dfbb64644e137d2e DIFF: https://github.com/llvm/llvm-project/commit/4b093cdc2886654d8a4fc308dfbb64644e137d2e.d

[Lldb-commits] [PATCH] D121131: [lldb] Support "bright" ANSI colors

This revision was automatically updated to reflect the committed changes. Closed by commit rG0acc9e4b5edd: [lldb] Support "bright" ANSI colors (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D121131?vs=413511&id=413585#toc Repository: rG LLVM Github Monorepo CH

[Lldb-commits] [lldb] 0acc9e4 - [lldb] Support "bright" ANSI colors

Author: Jonas Devlieghere Date: 2022-03-07T12:09:53-08:00 New Revision: 0acc9e4b5edd8b39ff3d4c6d0e17f02007671c4e URL: https://github.com/llvm/llvm-project/commit/0acc9e4b5edd8b39ff3d4c6d0e17f02007671c4e DIFF: https://github.com/llvm/llvm-project/commit/0acc9e4b5edd8b39ff3d4c6d0e17f02007671c4e.d

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

clayborg added a comment. The problem seemed to be we had a test case that was kind of bogus that was running attach commands with: "target create ..." followed by "process launch". There was no synchronization before, but now that is. The problem is that the "process launch" was run, but the

[Lldb-commits] [PATCH] D121036: Fix target.save-jit-objects when the CWD is not writeable

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Interpreter/OptionValue.h:314 void SetValueChangedCallback(std::function callback) { -assert(!m_callback); m_callback = std::move(callback); That's a weird assert Com

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

clayborg added a comment. https://reviews.llvm.org/rGc41c57468949 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120755/new/ https://reviews.llvm.org/D120755 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

clayborg added a comment. Herald added a project: All. Here is the diff that should fix things: https://reviews.llvm.org/rGc41c57468949 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119797/new/ https://reviews.llvm.org/D119797 ___

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

clayborg added a comment. I think I found the root cause of the issue in linux and it might fix this test for many other platforms: commit c41c57468949036a06695f06a97a8e14e8b252bd (HEAD -> main) Author: Greg Clayton Date:

[Lldb-commits] [lldb] c41c574 - Fix buildbots after https://reviews.llvm.org/D120755.

Author: Greg Clayton Date: 2022-03-07T11:46:56-08:00 New Revision: c41c57468949036a06695f06a97a8e14e8b252bd URL: https://github.com/llvm/llvm-project/commit/c41c57468949036a06695f06a97a8e14e8b252bd DIFF: https://github.com/llvm/llvm-project/commit/c41c57468949036a06695f06a97a8e14e8b252bd.diff

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

clayborg added a comment. In D120755#3364802 , @labath wrote: > Greg, this is still causing the TestVSCode_attach.py test to fail on > lldb-x86_64-debian > (it would probably fail elsewhere as

[Lldb-commits] [PATCH] D120755: Fix race condition when launching and attaching.This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797This version only wait

labath added a comment. Greg, this is still causing the TestVSCode_attach.py test to fail on lldb-x86_64-debian (it would probably fail elsewhere as well, but the test is already disabled everywhere else). Judging by the error message

[Lldb-commits] [PATCH] D121131: [lldb] Support "bright" ANSI colors

JDevlieghere added a comment. Adding @aprantl as a reviewer because he also likes colors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121131/new/ https://reviews.llvm.org/D121131 ___ lldb-commits maili

[Lldb-commits] [PATCH] D120690: [PDB] Add char8_t type

zequanwu added inline comments. Comment at: lldb/include/lldb/lldb-enumerations.h:752 eBasicTypeChar32, + eBasicTypeChar8, eBasicTypeShort, ljmf00 wrote: > You forgot to add it to the Python API. It should also be added at the end to > avoid user-code bre

[Lldb-commits] [PATCH] D121064: [lldb] Add a setting to change the autosuggestion ANSI escape codes

JDevlieghere added a comment. In D121064#3362890 , @teemperor wrote: > LGTM, thanks! FWIW, if you have `fish` installed you might wanna check what > they are doing on your terminal for its autosuggestions (and we might wanna > steal their default, even

[Lldb-commits] [PATCH] D121131: [lldb] Support "bright" ANSI colors

JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLDB. Support ANSI escape codes for bright colors variants. Most modern terminals support them. Still LLDB is

[Lldb-commits] [PATCH] D121064: [lldb] Add a setting to change the autosuggestion ANSI escape codes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG080635ef2791: [lldb] Add a setting to change the autosuggestion ANSI escape codes (authored by JDevlieghere). Herald added a project: LLDB. Reposito

[Lldb-commits] [lldb] 080635e - [lldb] Add a setting to change the autosuggestion ANSI escape codes

Author: Jonas Devlieghere Date: 2022-03-07T08:54:37-08:00 New Revision: 080635ef27914c3f0c20d221bc2f02ab6f13e6b4 URL: https://github.com/llvm/llvm-project/commit/080635ef27914c3f0c20d221bc2f02ab6f13e6b4 DIFF: https://github.com/llvm/llvm-project/commit/080635ef27914c3f0c20d221bc2f02ab6f13e6b4.d

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny created this revision. SimplyDanny added a reviewer: tonic. Herald added subscribers: libcxx-commits, arphaman. Herald added a reviewer: sscalpone. Herald added projects: libunwind, Flang, All. Herald added a reviewer: libunwind. SimplyDanny requested review of this revision. Herald add

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. Thanks for doing this! We need to fix a few undefined references, though. Comment at: libcxx/docs/index.rst:223 * `libcxx-commits Mailing List`_ * `libcxx-dev M

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. I think we need to retain *some* references to the existing mailing list archives. The migration to Discourse worked fairly well, but there were still data migration issues. For example: https://discourse.llvm.org/t/memory-barrier-problem/57493 https://lists.llvm