[Lldb-commits] [PATCH] D119131: [lldb] List platform plugin *instances* in "platform list"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Commands/CommandObjectPlatform.cpp:243 +OS << " "; +llvm::ListSeparator LS; +for (const PlatformSP &platform

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I don't feel super strongly, I was just curious. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119146/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D119046: Add a repeat command option for "thread backtrace --count N".

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Jim. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119046/new/ https://reviews.llvm.org/D119046 __

[Lldb-commits] [PATCH] D119046: Add a repeat command option for "thread backtrace --count N".

jingham updated this revision to Diff 407023. jingham added a comment. Ran clang-format over the diff Added a simpler test that doesn't try to rendezvous the two threads so they are in known states, but just does a repeated backtrace on the first thread that hits the breakpoint. Hopefully the

[Lldb-commits] [PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

shafik added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4667 + + SmallVector Expr; + AppendAddressSpaceXDeref(AddressSpace, Expr); aprantl wrote: > 13 seems to be unnecessarily high. Shouldn't 1 be enough for the expected > single DW_OP_der

[Lldb-commits] [PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4647 +const bool UsePointerValue) { + assert(CGM.getCodeGenOpts().hasReducedDebugInfo()); + assert(!LexicalBlockStack.empty() && "Region stack mismatch,

[Lldb-commits] [PATCH] D118494: [lldb] Observe SG_READ_ONLY flag in MachO binaries

kastiglione added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1436 result |= ePermissionsReadable; - if (seg_cmd.initprot & VM_PROT_WRITE) + if ((seg_cmd.initprot & VM_PROT_WRITE) && !(seg_cmd.flags & SG_READ_ONLY)) result |=

[Lldb-commits] [PATCH] D119298: [lldb] Fix step-avoid-regexp logging

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Ensure step-avoid-regexp logs are emitted in the case where the regex has no capture groups. Without this

[Lldb-commits] [PATCH] D119297: "thread until": make sure the current function is valid before asking it questions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119297/new/ https://reviews.llvm.org/D119297 _

[Lldb-commits] [PATCH] D119297: "thread until": make sure the current function is valid before asking it questions

jingham created this revision. jingham added a reviewer: JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thread until was assuming that if you have debug information, you will have a function. Apparently some hand-cr

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

clayborg added a comment. Sorry I am late to making comments on this patch. This patch wants to add "llvm::StringRef scope" to the FindTypes calls, but this is what "const CompilerDeclContext &parent_decl_ctx" is actually for. If "parent_decl_ctx" is set, it is a declaration context that each t

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. I believe this a program like this int main() { int arr[2]{0}; return arr[1]; } and an expression like this `expr arr[0]` will give us the constant expression `getelementptr`

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119168/new/ https://reviews.llvm.org/D119168 ___

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

mib updated this revision to Diff 406899. mib added a comment. Address @shafik comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119168/new/ https://reviews.llvm.org/D119168 Files: lldb/examples/python/crashlog.py Index: lldb/examples/pyt

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

mib added inline comments. Comment at: lldb/examples/python/crashlog.py:529 +if key == "x": +registers.update(self.parse_thread_registers({ str(idx) : reg + for idx,reg in sh

[Lldb-commits] [PATCH] D119178: Add support for generating debug-info for structured bindings of structs and arrays

aprantl added a comment. I think this looks pretty good! I have a few questions inside. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4667 + + SmallVector Expr; + AppendAddressSpaceXDeref(AddressSpace, Expr); 13 seems to be unnecessarily high. Shouldn't 1 be

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

shafik added inline comments. Comment at: lldb/examples/python/crashlog.py:529 +if key == "x": +registers.update(self.parse_thread_registers({ str(idx) : reg + for idx,reg in

[Lldb-commits] [lldb] 81cde47 - Cleanup LLVMDebugInfoCodeView headers

Author: serge-sans-paille Date: 2022-02-08T16:00:36+01:00 New Revision: 81cde474e2c5a6280cb693b777ddcf473825ae8a URL: https://github.com/llvm/llvm-project/commit/81cde474e2c5a6280cb693b777ddcf473825ae8a DIFF: https://github.com/llvm/llvm-project/commit/81cde474e2c5a6280cb693b777ddcf473825ae8a.d

[Lldb-commits] [PATCH] D119092: Cleanup LLVMDebugInfoCodeView headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81cde474e2c5: Cleanup LLVMDebugInfoCodeView headers (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/tools/lldb-server/main.cpp:144 +#elif defined(__aarch64__) + asm volatile("brk #0xf000"); +#elif defined(__arm__) --

[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

labath updated this revision to Diff 406761. labath marked 2 inline comments as done. labath added a comment. Use a trap opcode instead of a signal. This has two main drawbacks: - needs some architecture-specific code (gcc does not have __builtin_debugtrap) - if we ever need to resume from this s

[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

labath planned changes to this revision. labath marked an inline comment as done. labath added a comment. Speaking of windows, I just realized that this method will (obviously) not work there. I should have occurred to me there was a reason I didn't do this earlier. Let me try a different synchr

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

mceier added a comment. In D119186#3303744 , @sylvestre.ledru wrote: > Log: > https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console I downloaded build artifacts and it doesn't

[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

DavidSpickett added a comment. I'm pretty sure I've seen this sort of failure before but can't remember if it was locally or on one of many bots. (which probably means all of them!) This seems like a good improvement. Comment at: lldb/packages/Python/lldbsuite/test/tools/lld

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

labath added a comment. Well.. technically, I suppose I could make the constructors take a std::string, since at that point we're committed to creating the object, but the CreateInstance functions would still need to take a StringRef -- but the net effect is still one string copy. Repository:

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

labath added a comment. The main reason for that is because the platform objects are generally created in a loop (`for (factory : plugins) { result = factory(cantMove(name), ...)}`), so we can't make use of the move semantics because we don't know which construction will stick. Repository:

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

sylvestre.ledru added a comment. Log: https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119186/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

sylvestre.ledru added a comment. Debian is still broken with this patch on -14: lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'i

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. @JDevlieghere @shafik friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

labath added a comment. In D119009#3302354 , @JDevlieghere wrote: > I believe it's generally considered bad practice to install signal handlers > in a library. This is why the initialization currently happens in the driver. > If you look at other tools