[Lldb-commits] [PATCH] D118972: Increase preallocated buffer for scanning the process objc classes

This revision was automatically updated to reflect the committed changes. Closed by commit rGa37c38176a5a: Increase memory buffer for scanning objc classes on darwin systems (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [lldb] a37c381 - Increase memory buffer for scanning objc classes on darwin systems

Author: Jason Molenda Date: 2022-02-04T23:53:27-08:00 New Revision: a37c38176a5a1f797e6bc2b8771be017394e8e32 URL: https://github.com/llvm/llvm-project/commit/a37c38176a5a1f797e6bc2b8771be017394e8e32 DIFF: https://github.com/llvm/llvm-project/commit/a37c38176a5a1f797e6bc2b8771be017394e8e32.diff

[Lldb-commits] [PATCH] D118972: Increase preallocated buffer for scanning the process objc classes

jasonmolenda updated this revision to Diff 406165. jasonmolenda added a comment. Update to address Jonas' feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118972/new/ https://reviews.llvm.org/D118972 Files: lldb/source/Plugins/LanguageRu

[Lldb-commits] [PATCH] D119046: Add a repeat command option for "thread backtrace --count N".

jingham created this revision. jingham added a reviewer: JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This way if you have a long stack, you can issue "thread backtrace --count 10" and then subsequent -s will page y

[Lldb-commits] [PATCH] D118972: Increase preallocated buffer for scanning the process objc classes

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the nits about the comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2011 - const uint32_t num_

[Lldb-commits] [PATCH] D119044: Add a cases Rust in LLDB's PDB reading

arlosi created this revision. arlosi added reviewers: rnk, zturner, compnerd. Herald added a subscriber: JDevlieghere. arlosi requested review of this revision. Herald added a project: LLDB. D115300 added Rust as a new PDB language type. This change allows LLDB

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

shafik accepted this revision. shafik added a comment. LGTM after addressing Jonas's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 ___ lldb-commits

[Lldb-commits] [lldb] edbb0f6 - [lldb] Rename DemangleWithRichManglingInfo to GetRichManglingInfo (NFC)

Author: Jonas Devlieghere Date: 2022-02-04T10:40:33-08:00 New Revision: edbb0f6df76b04100357c7c9438f3b5b978e0200 URL: https://github.com/llvm/llvm-project/commit/edbb0f6df76b04100357c7c9438f3b5b978e0200 DIFF: https://github.com/llvm/llvm-project/commit/edbb0f6df76b04100357c7c9438f3b5b978e0200.d

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:237-239 + // Find types in a specific scope. + // \param scope + // Must be either the scope prefix (with leading ::) or empty Comment at: lldb/includ

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

This revision was automatically updated to reflect the committed changes. Closed by commit rGaed965d55d46: [lldb] Don't construct the demangled strings while indexing the symbol table (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D118953: [lldb] Improve RichManglingContext ergonomics (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa52788b7a6d: [lldb] Improve RichManglingContext ergonomics (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D118953?vs=405823&id=406031#

[Lldb-commits] [lldb] aed965d - [lldb] Don't construct the demangled strings while indexing the symbol table

Author: Jonas Devlieghere Date: 2022-02-04T10:17:39-08:00 New Revision: aed965d55d460ebcc2b442b9d799b4c1ab929157 URL: https://github.com/llvm/llvm-project/commit/aed965d55d460ebcc2b442b9d799b4c1ab929157 DIFF: https://github.com/llvm/llvm-project/commit/aed965d55d460ebcc2b442b9d799b4c1ab929157.d

[Lldb-commits] [lldb] fa52788 - [lldb] Improve RichManglingContext ergonomics (NFC)

Author: Jonas Devlieghere Date: 2022-02-04T10:17:39-08:00 New Revision: fa52788b7a6da1eab9fec0f2db5f74a8db555196 URL: https://github.com/llvm/llvm-project/commit/fa52788b7a6da1eab9fec0f2db5f74a8db555196 DIFF: https://github.com/llvm/llvm-project/commit/fa52788b7a6da1eab9fec0f2db5f74a8db555196.d

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

jingham added a comment. In D118814#3297198 , @JDevlieghere wrote: > In D118814#3297075 , @jingham wrote: > >> In D118814#3296008 , @labath wrote: >> >>> This seems fine,

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. In D118814#3297075 , @jingham wrote: > In D118814#3296008 , @labath wrote: > >> This seems fine, though it's not clear to me what is the

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

jingham added a comment. In D118814#3296008 , @labath wrote: > This seems fine, though it's not clear to me what is the effect of this patch > in terms of functionality. Does the "side-effect" mentioned by Jim still > apply here, or is this NFC now? Eit

[Lldb-commits] [PATCH] D118794: [lldb][AArch64] Remove non-address bits from addresses passed to ptrace on Linux

DavidSpickett added a comment. > I would have expected that lldb would strip these tags before the address > makes it's way over here (I'm pretty sure it needs to do that for other uses > anyway). Why is that not happening? So far we remove non-address bits for commands that need to diff pointe

[Lldb-commits] [lldb] 13b58f9 - [lldb] Remove Log:Channel::GetLogIfAll

Author: Pavel Labath Date: 2022-02-04T13:31:14+01:00 New Revision: 13b58f9710564b7abff1b62dc87e48de70df7f7c URL: https://github.com/llvm/llvm-project/commit/13b58f9710564b7abff1b62dc87e48de70df7f7c DIFF: https://github.com/llvm/llvm-project/commit/13b58f9710564b7abff1b62dc87e48de70df7f7c.diff

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

werat accepted this revision. werat added a comment. This revision is now accepted and ready to land. Looks good to me, I'm going to land it soon unless there are objections from other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627

[Lldb-commits] [PATCH] D118814: [lldb] Don't keep demangled names in memory after indexing

labath added a comment. This seems fine, though it's not clear to me what is the effect of this patch in terms of functionality. Does the "side-effect" mentioned by Jim still apply here, or is this NFC now? Either is probably fine, but I'd like to understand what is going on. It seems like it s