[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos (NFC)

2022-01-01 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: jingham, aprantl, augusto2112. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes incomplete command names in `apropos` results. The full command names given by

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

2022-01-01 Thread John Ericson via Phabricator via lldb-commits
Ericson2314 added inline comments. Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:115 set(LLVM_MAIN_INCLUDE_DIR "@LLVM_CONFIG_MAIN_INCLUDE_DIR@") -set(LLVM_LIBRARY_DIR "@LLVM_CONFIG_LIBRARY_DIRS@") @beanz > it would definitely break many uses of `LLVM_LI

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

2022-01-01 Thread Chris Bieneman via Phabricator via lldb-commits
beanz added a comment. `LLVM_LIBRARY_DIR` and `LLVM_LIBRARY_DIRS` aren’t intended to serve the same purpose. The `S` in `DIRS` is intentional to convey that it is a list of directories, not necessarily a single value, and it would definitely break many uses of `LLVM_LIBRARY_DIR` if it was a lis

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

2022-01-01 Thread John Ericson via Phabricator via lldb-commits
Ericson2314 added inline comments. Comment at: llvm/cmake/modules/CMakeLists.txt:58 set(LLVM_CONFIG_TOOLS_BINARY_DIR "${LLVM_TOOLS_BINARY_DIR}") +set(LLVM_CONFIG_LIBRARY_DIR "${LLVM_LIBRARY_DIR}") mstorsjo wrote: > Curious: Why the reordering? I presume you're

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2022-01-01 Thread Ben Jackson via Phabricator via lldb-commits
puremourning added a comment. Friendly ping to get this landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] 8b649f9 - [lldb] Add NOLINT(modernize-use-nullptr)

2022-01-01 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-01-01T13:14:59-08:00 New Revision: 8b649f98f68c5fe6e39f0d3666bb2dfef4543beb URL: https://github.com/llvm/llvm-project/commit/8b649f98f68c5fe6e39f0d3666bb2dfef4543beb DIFF: https://github.com/llvm/llvm-project/commit/8b649f98f68c5fe6e39f0d3666bb2dfef4543beb.diff L

[Lldb-commits] [PATCH] D116467: Deprecate `LLVM_LIBRARY_DIRS`

2022-01-01 Thread Martin Storsjö via Phabricator via lldb-commits
mstorsjo added subscribers: beanz, mstorsjo. mstorsjo added a reviewer: beanz. mstorsjo added a comment. This looks reasonable to me, but I'm not sure if I know all the aspects that might be at play here, so I don't think I'm comfortable with accepting it on my own. Adding @beanz who should know

[Lldb-commits] [lldb] f4ffcab - Remove redundant string initialization (NFC)

2022-01-01 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-01-01T12:34:11-08:00 New Revision: f4ffcab1787ad19ad9c2596688306de8a45f904a URL: https://github.com/llvm/llvm-project/commit/f4ffcab1787ad19ad9c2596688306de8a45f904a DIFF: https://github.com/llvm/llvm-project/commit/f4ffcab1787ad19ad9c2596688306de8a45f904a.diff L

[Lldb-commits] [lldb] b833628 - [lldb] Use nullptr instead of 0 or NULL (NFC)

2022-01-01 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-01-01T11:54:25-08:00 New Revision: b8336280d8244039a648ffde06b1e857cb664b15 URL: https://github.com/llvm/llvm-project/commit/b8336280d8244039a648ffde06b1e857cb664b15 DIFF: https://github.com/llvm/llvm-project/commit/b8336280d8244039a648ffde06b1e857cb664b15.diff L

[Lldb-commits] [lldb] 95f7112 - Revert "[lldb] Use nullptr instead of 0 or NULL (NFC)"

2022-01-01 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-01-01T11:15:14-08:00 New Revision: 95f7112be8daa521e607fb3c231012a6d5eafa96 URL: https://github.com/llvm/llvm-project/commit/95f7112be8daa521e607fb3c231012a6d5eafa96 DIFF: https://github.com/llvm/llvm-project/commit/95f7112be8daa521e607fb3c231012a6d5eafa96.diff L

[Lldb-commits] [lldb] 913457a - [lldb] Use nullptr instead of 0 or NULL (NFC)

2022-01-01 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-01-01T10:48:56-08:00 New Revision: 913457acf07be7f22d71ac41ad1076517d7f45c6 URL: https://github.com/llvm/llvm-project/commit/913457acf07be7f22d71ac41ad1076517d7f45c6 DIFF: https://github.com/llvm/llvm-project/commit/913457acf07be7f22d71ac41ad1076517d7f45c6.diff L

[Lldb-commits] [lldb] 4f2eeb6 - Revert "[lldb] Use nullptr instead of 0 or NULL (NFC)"

2022-01-01 Thread Nico Weber via lldb-commits
Author: Nico Weber Date: 2022-01-01T13:35:54-05:00 New Revision: 4f2eeb6a657abf82d13e95c7ab0d7d02fab98ed1 URL: https://github.com/llvm/llvm-project/commit/4f2eeb6a657abf82d13e95c7ab0d7d02fab98ed1 DIFF: https://github.com/llvm/llvm-project/commit/4f2eeb6a657abf82d13e95c7ab0d7d02fab98ed1.diff LO

[Lldb-commits] [lldb] 24d2405 - [lldb] Use nullptr instead of 0 or NULL (NFC)

2022-01-01 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2022-01-01T08:54:05-08:00 New Revision: 24d240558811604354a8d6080405f6bad8d15b5c URL: https://github.com/llvm/llvm-project/commit/24d240558811604354a8d6080405f6bad8d15b5c DIFF: https://github.com/llvm/llvm-project/commit/24d240558811604354a8d6080405f6bad8d15b5c.diff L