[Lldb-commits] [PATCH] D116012: Fix "settings set -g" so it works again.

clayborg created this revision. clayborg added reviewers: teemperor, JDevlieghere, jingham. Herald added a subscriber: dang. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When we switched options over to use the Options.td file,

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

clayborg added inline comments. Comment at: lldb/docs/use/variable.rst:77 +which is what the user would expect from a good debugger. + There are several features related to data visualization: formats, summaries, jingham wrote: > jingham wrote: > > This is a nic

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/Symtab.h:279 m_mutex; // Provide thread safety for this symbol table - bool m_file_addr_to_index_computed : 1, m_name_indexes_computed : 1; + bool m_file_addr_to_index_computed : 1, m_name_indexes_compu

[Lldb-commits] [PATCH] D116006: [lldb/gdb-remote] remove junk bytes, then decode the packet

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:650-676 +// Check if we have an unexpected byte and we need to flush all bad data +// that is in m_bytes, so we need to find the first byte that is a '+' +//

[Lldb-commits] [PATCH] D116009: [lldb/gdb-remote] drop all junk bytes in incoming packet

clayborg added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:689-706 const size_t bytes_len = m_bytes.size(); bool done = false; uint32_t idx; - for (idx = 1; !done && idx < bytes_len; ++idx) { + for

[Lldb-commits] [PATCH] D116009: [lldb/gdb-remote] drop all junk bytes in incoming packet

clayborg added a comment. It would be nice to add a test case for this if possible. The solution looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116009/new/ https://reviews.llvm.org/D116009 __

[Lldb-commits] [PATCH] D116009: [lldb/gdb-remote] drop all junk bytes in incoming packet

borneoa created this revision. borneoa added a reviewer: clayborg. borneoa requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The loop that detects the junk bytes exits: a) when it reaches the last byte in m_bytes, or b) when it finds a valid

[Lldb-commits] [PATCH] D116006: [lldb/gdb-remote] remove junk bytes, then decode the packet

borneoa abandoned this revision. borneoa added a comment. Sorry, very first time user of arcanist and phabricator. This revision was actually made by two independent patches that get squashed! Abandoned, I will try to send the patches separately Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D116006: [lldb/gdb-remote] remove junk bytes, then decode the packet

borneoa updated this revision to Diff 395347. borneoa added a comment. resend it on top of its dependency [lldb/gdb-remote] drop all junk bytes in incoming packet Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116006/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D116006: [lldb/gdb-remote] remove junk bytes, then decode the packet

borneoa created this revision. borneoa requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In case of receiving, in a single packet, some junk byte followed by a complete gdb-remote reply, e.g. "junk+$OK#9a", the current implementation of Check

[Lldb-commits] [PATCH] D116005: [lldb] [Process/FreeBSDKernel] Introduce libkvm support

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Introduce initial support for using libkvm on FreeBSD. The library can be used as an alternate implementation for processing kernel