[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG223e8ca02616: Set a default number of address bits on Darwin arm64 systems (authored by jasonmolenda). Changed prior to c

[Lldb-commits] [lldb] 223e8ca - Set a default number of address bits on Darwin arm64 systems

Author: Jason Molenda Date: 2021-12-09T22:53:01-08:00 New Revision: 223e8ca02616dd9353da230d95589954927025c9 URL: https://github.com/llvm/llvm-project/commit/223e8ca02616dd9353da230d95589954927025c9 DIFF: https://github.com/llvm/llvm-project/commit/223e8ca02616dd9353da230d95589954927025c9.diff

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

shafik added a comment. I would also like to know where this duplicate insertion is happening. Can you walk us through the steps that lead to the duplicate entries? thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115308/new/ https://revie

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

stella.stamenova added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/test/Shell/SymbolFile/PDB/enums-layout.test:13 -ENUM: Type{{.*}} , name = "Enum", size = 4, decl = simpletypestest.cpp:19, compiler_type = {{.*}} enum Enum { +ENUM: Type

[Lldb-commits] [PATCH] D115482: [lldb] Update the PDB tests to pass with the VS2019 toolset

stella.stamenova created this revision. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The pdb lldb tests do not work correctly with both the VS2019 and VS2017 toolsets at the moment. This change updates several of the te

[Lldb-commits] [PATCH] D115474: [lldb] Refactor & update of EditlineTest

nealsid created this revision. Herald added a subscriber: kristof.beyls. nealsid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch has a few minor cleanups and a restructuring of the EditlineTest class: Cleanups: - Adds some comm

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

mib added a comment. In D115313#3182258 , @DavidSpickett wrote: >> Thanks for clarifying @DavidSpickett ! I'll change the warning accordingly. > > Too many Davids :) 😅😅 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D115461: [lldb/Target] Refine source display warning for artificial locations (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG20db8e07f9d5: [lldb/Target] Refine source display warning for artificial locations (NFC) (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[Lldb-commits] [lldb] 20db8e0 - [lldb/Target] Refine source display warning for artificial locations (NFC)

Author: Med Ismail Bennani Date: 2021-12-09T14:38:14-08:00 New Revision: 20db8e07f9d5e4378839602752099e0ff2f703a9 URL: https://github.com/llvm/llvm-project/commit/20db8e07f9d5e4378839602752099e0ff2f703a9 DIFF: https://github.com/llvm/llvm-project/commit/20db8e07f9d5e4378839602752099e0ff2f703a9.

[Lldb-commits] [PATCH] D115461: [lldb/Target] Refine source display warning for artificial locations (NFC)

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks, I think this is much easier to understand! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115461/new/ https://reviews.llvm.org/D115461

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

mgorny updated this revision to Diff 393276. mgorny added a comment. Add tests for other vmcores. Fix assert in arm64, and turn it into static_assert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114911/new/ https://reviews.llvm.org/D114911 Files: lldb/cmake/modules/LLDBConfig.cmak

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

wallace added a comment. committed as cfb075089128b2e5918afd0ce21ec10bf455e5ab Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115178/new/ https://reviews.llvm.org/D115178 __

[Lldb-commits] [lldb] cfb0750 - Unify libstdcpp and libcxx formatters for `std::optional`

Author: Alisamar Husain Date: 2021-12-09T13:10:43-08:00 New Revision: cfb075089128b2e5918afd0ce21ec10bf455e5ab URL: https://github.com/llvm/llvm-project/commit/cfb075089128b2e5918afd0ce21ec10bf455e5ab DIFF: https://github.com/llvm/llvm-project/commit/cfb075089128b2e5918afd0ce21ec10bf455e5ab.dif

[Lldb-commits] [PATCH] D115178: Unify libstdcpp and libcxx formatters for `std::optional`

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfb075089128: Unify libstdcpp and libcxx formatters for `std::optional` (authored by zrthxn, committed by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.org/D115178?v

[Lldb-commits] [PATCH] D114008: [formatters] Add a deque formatter for libstdcpp and fix the libcxx one

wallace closed this revision. wallace added a comment. committed as 2ea3c8a50add5436cf939d59c3235408ca0255c1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114008/new/ https://re

[Lldb-commits] [PATCH] D115461: [lldb/Target] Refine source display warning for artificial locations (NFC)

mib created this revision. mib added a reviewer: aprantl. mib added a project: LLDB. Herald added a subscriber: JDevlieghere. mib requested review of this revision. Herald added a subscriber: lldb-commits. This is a post-review update for D115313 , to rephrase so

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

nealsid updated this revision to Diff 393228. nealsid added a comment. Remove extra header and using decl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115126/new/ https://reviews.llvm.org/D115126 Files: lldb/include/lldb/Host/Editline.h lldb/

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

nealsid added a comment. Thanks, Pavel. Comment at: lldb/unittests/Editline/EditlineTest.cpp:133-139 + // We have to set the output stream we pass to Editline as not using + // buffered I/O. Otherwise we are missing editline's output when we + // close the stream in the key

[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

jasonmolenda updated this revision to Diff 393213. jasonmolenda marked 3 inline comments as done. jasonmolenda added a comment. Update patchset to address David's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115431/new/ https://reviews.l

[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

jasonmolenda marked 12 inline comments as done. jasonmolenda added a comment. Thanks so much for the thorough review Davide, I really appreciate the help and time you spent doing this. I addressed the comments and will update the patch momentarily. I have another small change I want to make so

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

aprantl added a comment. Thanks! I have some late wording suggestions. Comment at: lldb/source/Target/StackFrame.cpp:1904 + strm.Printf("Warning: the current PC is an artificial location " + "in function %s.", + fn_

[Lldb-commits] [PATCH] D115438: [lldb] Remove unused lldb.cpp

JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115438/new/ https://reviews.llvm.org/D115438 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

nealsid updated this revision to Diff 393200. nealsid added a comment. Patch to address CR feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115126/new/ https://reviews.llvm.org/D115126 Files: lldb/include/lldb/Host/Editline.h lldb/sourc

[Lldb-commits] [lldb] eaf4f60 - [lldb] Remove unused lldb.cpp

Author: Haojian Wu Date: 2021-12-09T17:54:27+01:00 New Revision: eaf4f60507fd7e5d20c5dcee711ca12f13f1acc1 URL: https://github.com/llvm/llvm-project/commit/eaf4f60507fd7e5d20c5dcee711ca12f13f1acc1 DIFF: https://github.com/llvm/llvm-project/commit/eaf4f60507fd7e5d20c5dcee711ca12f13f1acc1.diff LO

[Lldb-commits] [PATCH] D115438: [lldb] Remove unused lldb.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGeaf4f60507fd: [lldb] Remove unused lldb.cpp (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115438/new/ https://reviews.llvm.org/D115438

[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

DavidSpickett added a comment. > General question, is yaml2obj not flexible enough to do this? I guess the > issue would be even if it does do MachO the test could only work on a > precompiled file, this way allows you to build a.out each time. Plus you get all the Mach specific constant values

[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. Glad to see this, it will be useful on AArch64 Linux as well. General question, is yaml2obj not flexible enough to do this? I guess the issue would be even if it does do MachO the test could only work on a precompiled

[Lldb-commits] [PATCH] D115110: [lldb][nfc] clang-format some files as preperation for https://reviews.llvm.org/D114627

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2e2eece9aa8: [lldb][NFC] clang-format some files as preparation for https://reviews.llvm. (authored by lassefolger, committed by werat). Changed prior to commit: https://reviews.llvm.org/D115110?vs=39

[Lldb-commits] [lldb] b2e2eec - [lldb][NFC] clang-format some files as preparation for https://reviews.llvm.org/D114627

Author: Lasse Folger Date: 2021-12-09T12:38:00+01:00 New Revision: b2e2eece9aa8db4bcc47c7fed0a9b999a3d96baf URL: https://github.com/llvm/llvm-project/commit/b2e2eece9aa8db4bcc47c7fed0a9b999a3d96baf DIFF: https://github.com/llvm/llvm-project/commit/b2e2eece9aa8db4bcc47c7fed0a9b999a3d96baf.diff

[Lldb-commits] [PATCH] D115438: [lldb] Remove unused lldb.cpp

hokein created this revision. hokein added a reviewer: labath. hokein requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb.cpp is unused after https://github.com/llvm/llvm-project/commit/ccf1469a4cdb03cb2bc7868f76164e85d90ebee1 Repositor

[Lldb-commits] [lldb] e04fc2d - [llvm][lldb] Remove unused SmallVectorMemoryBuffer.h includes

Author: Jan Svoboda Date: 2021-12-09T11:32:13+01:00 New Revision: e04fc2d88efa60ed5527b90c15d8fc188739e989 URL: https://github.com/llvm/llvm-project/commit/e04fc2d88efa60ed5527b90c15d8fc188739e989 DIFF: https://github.com/llvm/llvm-project/commit/e04fc2d88efa60ed5527b90c15d8fc188739e989.diff L

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

DavidSpickett added a comment. > Thanks for clarifying @DavidSpickett ! I'll change the warning accordingly. Too many Davids :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115313/new/ https://reviews.llvm.org/D115313 ___

[Lldb-commits] [PATCH] D115431: Set a default number of addressing bits for Darwin arm64 systems

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added subscribers: omjavaid, kristof.beyls. jasonmolenda requested review of this revision. For ARMv8.3 pointer auth signing, lldb needs to know how many bits are valid for