[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

2021-11-28 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd updated this revision to Diff 390249. compnerd added a comment. Add missing null-terminators. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platform/Windows/CMakeLists.txt lldb/source/Plugins/Platform/Wi

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

2021-11-28 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd updated this revision to Diff 390246. compnerd added a comment. Herald added a subscriber: mgorny. Fix build rules Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77287/new/ https://reviews.llvm.org/D77287 Files: lldb/source/Plugins/Platf

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

2021-11-28 Thread Saleem Abdulrasool via Phabricator via lldb-commits
compnerd updated this revision to Diff 390245. compnerd retitled this revision from "Windows: add very basic support for `DoLoadImage`" to "Windows: support `DoLoadImage`". compnerd edited the summary of this revision. compnerd added a comment. This is a more complete implementation that allows f

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

2021-11-28 Thread Luís Ferreira via Phabricator via lldb-commits
ljmf00 added a comment. In D112564#3089399 , @labath wrote: > What exactly do you need the test to do? Is printing a global variable > (`char8_t_ish foo[] = "my string"`) sufficient? > If so, you can take a look at the tests in `test/Shell/SymbolFile/DWA

[Lldb-commits] [lldb] 6488bd1 - test: add a lit configuration for Windows subdirectory

2021-11-28 Thread Saleem Abdulrasool via lldb-commits
Author: Saleem Abdulrasool Date: 2021-11-28T18:27:47-08:00 New Revision: 6488bd1d51715501632778e3c9a1d4eedfac2998 URL: https://github.com/llvm/llvm-project/commit/6488bd1d51715501632778e3c9a1d4eedfac2998 DIFF: https://github.com/llvm/llvm-project/commit/6488bd1d51715501632778e3c9a1d4eedfac2998.

[Lldb-commits] [PATCH] D114668: [lldb] Move generic DWARFASTParser code out of Clang-specific code

2021-11-28 Thread Luís Ferreira via Phabricator via lldb-commits
ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:77 + default: + case DW_AT_abstract_origin: + case DW_AT_accessibility: Why we are including just these specific attributes? Maybe we shou

[Lldb-commits] [PATCH] D114675: [lldb] [Target] Support fallback to file address in ReadMemory()

2021-11-28 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Add a fallback to `GetFileAddress()` when `GetLoadAddress()` fails in `ReadMemory()`. This is consistent with how expression evaluat