[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu updated this revision to Diff 389927. RamNalamothu added a comment. Remove the unnecessary `if {}` gaurding around range for loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114448/new/ https://reviews.llvm.org/D114448 Files: lld

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu updated this revision to Diff 389884. RamNalamothu edited the summary of this revision. RamNalamothu added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114448/new/ https://reviews.llvm.org/D114448

[Lldb-commits] [PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5162b558d8c0: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to… (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 5162b55 - [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

Author: Zarko Todorovski Date: 2021-11-25T16:21:06-05:00 New Revision: 5162b558d8c0b542e752b037e72a69d5fd51eb1e URL: https://github.com/llvm/llvm-project/commit/5162b558d8c0b542e752b037e72a69d5fd51eb1e DIFF: https://github.com/llvm/llvm-project/commit/5162b558d8c0b542e752b037e72a69d5fd51eb1e.di

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu added a comment. In D114448#3150900 , @DavidSpickett wrote: > Not sure if you're a regular contributor and already know this but in case > not, I tend to use > https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting > f

[Lldb-commits] [PATCH] D114029: [clang][NFC] Inclusive terms: rename AccessDeclContextSanity to AccessDeclContextCheck

quinnp accepted this revision. quinnp added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114029/new/ https://reviews.llvm.org/D114029 ___

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

This revision was automatically updated to reflect the committed changes. Closed by commit rG1aab5e653d2c: [LLDB] Provide target specific directories to libclang (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110827/new/ https:

[Lldb-commits] [lldb] 1aab5e6 - [LLDB] Provide target specific directories to libclang

Author: Pavel Kosov Date: 2021-11-25T21:27:02+03:00 New Revision: 1aab5e653d2cf8b147748d014c5fb513a4670418 URL: https://github.com/llvm/llvm-project/commit/1aab5e653d2cf8b147748d014c5fb513a4670418 DIFF: https://github.com/llvm/llvm-project/commit/1aab5e653d2cf8b147748d014c5fb513a4670418.diff L

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 added a comment. In D113604#3138107 , @JDevlieghere wrote: > LGTM modulo the inline comment. I addressed what you requested. Please review. If it is good to land, please do, as I don't have permissions. Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D113604: [lldb] Format lldb/include/lldb/Symbol/Type.h

ljmf00 updated this revision to Diff 389836. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 Files: lldb/include/lldb/Symbol/Type.h lldb/source/Symbol/Type.cpp Index: lldb/source/Symbol/Type.cpp =

[Lldb-commits] [PATCH] D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents

RamNalamothu marked 6 inline comments as done. RamNalamothu added a comment. Thanks for the comments. I wasn't familiar with the Pyhton test infrastructure so I took the files from `commands/memory/read` and updated as needed here. All the comments etc came from that. I think I addressed all t

[Lldb-commits] [PATCH] D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents

RamNalamothu updated this revision to Diff 389821. RamNalamothu added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114544/new/ https://reviews.llvm.org/D114544 Files: lldb/source/Commands/CommandObjectMemory.

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D114520: [lldb/gdb-remote] Ignore spurious ACK packets

This revision was automatically updated to reflect the committed changes. Closed by commit rG165545c7a431: [lldb/gdb-remote] Ignore spurious ACK packets (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114520/new/ https://reviews.

[Lldb-commits] [PATCH] D114529: [lldb/gdb-remote] Remove initial pipe-draining workaround

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6fedbf20c8f: [lldb/gdb-remote] Remove initial pipe-draining workaround (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114529/new/ http

[Lldb-commits] [lldb] 165545c - [lldb/gdb-remote] Ignore spurious ACK packets

Author: Pavel Labath Date: 2021-11-25T12:34:08+01:00 New Revision: 165545c7a431aa3682fd9468014771c1c5228226 URL: https://github.com/llvm/llvm-project/commit/165545c7a431aa3682fd9468014771c1c5228226 DIFF: https://github.com/llvm/llvm-project/commit/165545c7a431aa3682fd9468014771c1c5228226.diff

[Lldb-commits] [lldb] a6fedbf - [lldb/gdb-remote] Remove initial pipe-draining workaround

Author: Pavel Labath Date: 2021-11-25T12:33:23+01:00 New Revision: a6fedbf20c8f87061f333169120790e2c6f22806 URL: https://github.com/llvm/llvm-project/commit/a6fedbf20c8f87061f333169120790e2c6f22806 DIFF: https://github.com/llvm/llvm-project/commit/a6fedbf20c8f87061f333169120790e2c6f22806.diff

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath added a comment. In D114509#3151035 , @mgorny wrote: > That said, I wonder if we should use some formatter (e.g. `black`) for Python > files. While I can't really say I like black's coding style, it's quite > popular and using some formatter woul

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath updated this revision to Diff 389717. labath marked an inline comment as done. labath added a comment. feedback David Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 Files: lldb/packages/Python/l

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath marked 4 inline comments as done. labath added a comment. In D114509#3151461 , @DavidSpickett wrote: >> qemu also does not support macOS > > Do you mean qemu-user here? Yes, definitely. In D114509#3151581

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

labath added a comment. In D114008#3153211 , @danilashtefan wrote: > As we discussed offline, I add the print tests, since SBValue.GetValue() > doesn't work for complex structures There are different ways you can do that depending on what you want to t

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan updated this revision to Diff 389700. danilashtefan added a comment. As we discussed offline, I add the print tests, since SBValue.GetValue() doesn't work for complex structures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114008/new

[Lldb-commits] [PATCH] D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents

DavidSpickett added inline comments. Comment at: lldb/source/Interpreter/CommandObject.cpp:457 : OptSetFiltered(opt_set_mask, m_arguments[i]); +if (arg_entry.empty()) + continue; (like I said on the other diff) What does it mean for an arg_

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

DavidSpickett added a comment. > David, did you get any breakage emails about that commit ? I did not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114554/new/ https://reviews.llvm.org/D114554 ___ lldb

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

labath added a comment. In D114288#3152709 , @clayborg wrote: > Do all .dwo files claim the main executable that references them is their > owning module? The short answer is "yes". The reason for that is that the dwo files do not constitute a module i

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

PatriosTheGreat added a comment. Hi Pavel. Got it, Thanks for fixing and clarification. In D114554#3152953 , @labath wrote: > I've fixed this in rGc0e3bb4d4ba306 > . > >> Not sure if

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

labath added a comment. I've fixed this in rGc0e3bb4d4ba306 . > Not sure if it's better to revert original commit > (https://reviews.llvm.org/rGf23b829a2635a6d833bdc81a12d6217b52ae9e45) and > then re-commit the change with th